| Message ID | 1555384609-7030-1-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [V12,1/5] dt-bindings: fsl: scu: add thermal binding | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
> From: Anson Huang > Sent: Tuesday, April 16, 2019 11:22 AM > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > controller, the system controller is in charge of system power, clock and > thermal sensors etc. management, Linux kernel has to communicate with > system controller via MU (message unit) IPC to get temperature from thermal > sensors, this patch adds binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > No changes. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 5d7dbab..f4fb6d5 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -133,6 +133,17 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See > Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. Better to have an explicit value here. e.g. Must be 1. See xxx for a description. Otherwise: Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Dong Aisheng
Best Regards! Anson Huang > -----Original Message----- > From: Aisheng Dong > Sent: Wednesday, April 17, 2019 11:32 AM > To: Anson Huang <anson.huang@nxp.com>; robh+dt@kernel.org; > mark.rutland@arm.com; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; catalin.marinas@arm.com; > will.deacon@arm.com; rui.zhang@intel.com; edubezval@gmail.com; > daniel.lezcano@linaro.org; ulf.hansson@linaro.org; Daniel Baluta > <daniel.baluta@nxp.com>; Peng Fan <peng.fan@nxp.com>; > heiko@sntech.de; horms+renesas@verge.net.au; agross@kernel.org; > olof@lixom.net; bjorn.andersson@linaro.org; jagan@amarulasolutions.com; > enric.balletbo@collabora.com; marc.w.gonzalez@free.fr; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-pm@vger.kernel.org > Cc: dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding > > > From: Anson Huang > > Sent: Tuesday, April 16, 2019 11:22 AM > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and thermal sensors etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get temperature > > from thermal sensors, this patch adds binding doc for i.MX system > controller thermal driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > No changes. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > > ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index 5d7dbab..f4fb6d5 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -133,6 +133,17 @@ RTC bindings based on SCU Message Protocol > > Required properties: > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > +Thermal bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See > > Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > Better to have an explicit value here. > e.g. > Must be 1. See xxx for a description. OK, will add it in next version. Anson. > > Otherwise: > Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> > > Regards > Dong Aisheng
On Tue, 16 Apr 2019 03:22:09 +0000, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > No changes. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt index 5d7dbab..f4fb6d5 100644 --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt @@ -133,6 +133,17 @@ RTC bindings based on SCU Message Protocol Required properties: - compatible: should be "fsl,imx8qxp-sc-rtc"; +Thermal bindings based on SCU Message Protocol +------------------------------------------------------------ + +Required properties: +- compatible: Should be : + "fsl,imx8qxp-sc-thermal" + followed by "fsl,imx-sc-thermal"; + +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt + for a description. + Example (imx8qxp): ------------- aliases { @@ -185,6 +196,11 @@ firmware { rtc: rtc { compatible = "fsl,imx8qxp-sc-rtc"; }; + + tsens: thermal-sensor { + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal"; + #thermal-sensor-cells = <1>; + }; }; };
NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system controller, the system controller is in charge of system power, clock and thermal sensors etc. management, Linux kernel has to communicate with system controller via MU (message unit) IPC to get temperature from thermal sensors, this patch adds binding doc for i.MX system controller thermal driver. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- No changes. --- .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)