| Message ID | 20190409174535.31768-1-giulio.benetti@micronovasrl.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | package/vdr-plugin-vnsiserver: package needs host-gettext to build correctly | expand |
Hello Giulio, On Tue, 9 Apr 2019 19:45:35 +0200 Giulio Benetti <giulio.benetti@micronovasrl.com> wrote: > During building msgmerge is used, so at the moment if build environment > doesn't provide it, build will fail. > > Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES. > > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> In retrospect, I think http://patchwork.ozlabs.org/patch/1074926/ is better. In fact, my analysis of Fabrice's patch was wrong. Even if the gettext-tiny issue gets resolved, vdr-plugin-vnsiserver (apparently) still needs msgfmt/msgmerge unconditionally, so we would indeed need a host-gettext dependency. But Fabrice's patch makes that not necessary, by only installing the i18n files when BR2_SYSTEM_ENABLE_NLS=y. Thomas
Il 09/04/2019 23:21, Thomas Petazzoni ha scritto: > Hello Giulio, > > On Tue, 9 Apr 2019 19:45:35 +0200 > Giulio Benetti <giulio.benetti@micronovasrl.com> wrote: > >> During building msgmerge is used, so at the moment if build environment >> doesn't provide it, build will fail. >> >> Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> > > In retrospect, I think http://patchwork.ozlabs.org/patch/1074926/ is better. > > In fact, my analysis of Fabrice's patch was wrong. Even if the > gettext-tiny issue gets resolved, vdr-plugin-vnsiserver (apparently) > still needs msgfmt/msgmerge unconditionally, so we would indeed need a > host-gettext dependency. > > But Fabrice's patch makes that not necessary, by only installing the > i18n files when BR2_SYSTEM_ENABLE_NLS=y. Ah ok, this is clever, since gettext-tiny maintainers pointed they only provide stubs and not complete gettext support(this is why it's called tiny): https://github.com/sabotage-linux/gettext-tiny/issues/42#issuecomment-480127106 Thanks for the explanation. Best regards
Hello Thomas, Il 10/04/2019 12:05, Giulio Benetti ha scritto: > Il 09/04/2019 23:21, Thomas Petazzoni ha scritto: >> Hello Giulio, >> >> On Tue, 9 Apr 2019 19:45:35 +0200 >> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote: >> >>> During building msgmerge is used, so at the moment if build environment >>> doesn't provide it, build will fail. >>> >>> Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES. >>> >>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> >> >> In retrospect, I think http://patchwork.ozlabs.org/patch/1074926/ is better. >> >> In fact, my analysis of Fabrice's patch was wrong. Even if the >> gettext-tiny issue gets resolved, vdr-plugin-vnsiserver (apparently) >> still needs msgfmt/msgmerge unconditionally, so we would indeed need a >> host-gettext dependency. >> >> But Fabrice's patch makes that not necessary, by only installing the >> i18n files when BR2_SYSTEM_ENABLE_NLS=y. So you mean we need to avoid build step using msgfmt/msgmerge and need to copy i18n files with something like "cp i18n-files target/i18n-files" ? > > Ah ok, this is clever, since gettext-tiny maintainers pointed they only > provide stubs and not complete gettext support(this is why it's called > tiny): > https://github.com/sabotage-linux/gettext-tiny/issues/42#issuecomment-480127106 > > Thanks for the explanation. > Best regards >
diff --git a/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk b/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk index 20644d3f6b..86c99c422b 100644 --- a/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk +++ b/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk @@ -8,7 +8,7 @@ VDR_PLUGIN_VNSISERVER_VERSION = v1.8.0 VDR_PLUGIN_VNSISERVER_SITE = $(call github,FernetMenta,vdr-plugin-vnsiserver,$(VDR_PLUGIN_VNSISERVER_VERSION)) VDR_PLUGIN_VNSISERVER_LICENSE = GPL-2.0+ VDR_PLUGIN_VNSISERVER_LICENSE_FILES = COPYING -VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr +VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr host-gettext VDR_PLUGIN_VNSISERVER_CXXFLAGS = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11 -fPIC"
During building msgmerge is used, so at the moment if build environment doesn't provide it, build will fail. Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES. Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> --- package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)