| Message ID | 20190313142040.26694-1-cquast@hanoverdisplays.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X* | expand |
On Wed, 13 Mar 2019 15:20:40 +0100, Christina Quast wrote: > In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from > the documentation. > > Changes since v2: > * Changed patch title to 'dt-bindings: pinctrl: imx7d:' > > Signed-off-by: Christina Quast <cquast@hanoverdisplays.com> > --- > .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
> From: Christina Quast [mailto:cquast@hanoverdisplays.com] > Sent: Wednesday, March 13, 2019 10:21 PM > > In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from the > documentation. > > Changes since v2: > * Changed patch title to 'dt-bindings: pinctrl: imx7d:' > > Signed-off-by: Christina Quast <cquast@hanoverdisplays.com> Acked-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Dong Aisheng > --- > .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > index 6666277c3acb..8ac1d0851a0f 100644 > --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > @@ -48,9 +48,9 @@ PAD_CTL_HYS (1 << 3) > PAD_CTL_SRE_SLOW (1 << 2) > PAD_CTL_SRE_FAST (0 << 2) > PAD_CTL_DSE_X1 (0 << 0) > -PAD_CTL_DSE_X2 (1 << 0) > -PAD_CTL_DSE_X3 (2 << 0) > -PAD_CTL_DSE_X4 (3 << 0) > +PAD_CTL_DSE_X4 (1 << 0) > +PAD_CTL_DSE_X2 (2 << 0) > +PAD_CTL_DSE_X6 (3 << 0) > > Examples: > While iomuxc-lpsr is intended to be used by dedicated peripherals to take > -- > 2.20.1
Hi Linus, I assume this will go via your tree. Let me know if you think differently. Shawn On Wed, Mar 13, 2019 at 03:20:40PM +0100, Christina Quast wrote: > In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from > the documentation. > > Changes since v2: > * Changed patch title to 'dt-bindings: pinctrl: imx7d:' > > Signed-off-by: Christina Quast <cquast@hanoverdisplays.com> > --- > .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > index 6666277c3acb..8ac1d0851a0f 100644 > --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt > @@ -48,9 +48,9 @@ PAD_CTL_HYS (1 << 3) > PAD_CTL_SRE_SLOW (1 << 2) > PAD_CTL_SRE_FAST (0 << 2) > PAD_CTL_DSE_X1 (0 << 0) > -PAD_CTL_DSE_X2 (1 << 0) > -PAD_CTL_DSE_X3 (2 << 0) > -PAD_CTL_DSE_X4 (3 << 0) > +PAD_CTL_DSE_X4 (1 << 0) > +PAD_CTL_DSE_X2 (2 << 0) > +PAD_CTL_DSE_X6 (3 << 0) > > Examples: > While iomuxc-lpsr is intended to be used by dedicated peripherals to take > -- > 2.20.1 >
On Wed, Mar 13, 2019 at 3:20 PM Christina Quast <cquast@hanoverdisplays.com> wrote: > In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from > the documentation. > > Changes since v2: > * Changed patch title to 'dt-bindings: pinctrl: imx7d:' > > Signed-off-by: Christina Quast <cquast@hanoverdisplays.com> Patch applied with the ACKs. Yours, Linus Walleij
On Wed, Apr 3, 2019 at 10:43 AM Shawn Guo <shawnguo@kernel.org> wrote: > I assume this will go via your tree. Let me know if you think > differently. OK I applied it, if you're not merging any device trees using these defines this cycle it's fine I suppose. Yours, Linus Walleij
> From: Linus Walleij [mailto:linus.walleij@linaro.org] > Sent: Monday, April 8, 2019 8:10 PM > On Wed, Apr 3, 2019 at 10:43 AM Shawn Guo <shawnguo@kernel.org> wrote: > > > I assume this will go via your tree. Let me know if you think > > differently. > > OK I applied it, if you're not merging any device trees using these defines this > cycle it's fine I suppose. > IMX device tree does not use it. So it's safe. Regards Dong Aisheng > Yours, > Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt index 6666277c3acb..8ac1d0851a0f 100644 --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt @@ -48,9 +48,9 @@ PAD_CTL_HYS (1 << 3) PAD_CTL_SRE_SLOW (1 << 2) PAD_CTL_SRE_FAST (0 << 2) PAD_CTL_DSE_X1 (0 << 0) -PAD_CTL_DSE_X2 (1 << 0) -PAD_CTL_DSE_X3 (2 << 0) -PAD_CTL_DSE_X4 (3 << 0) +PAD_CTL_DSE_X4 (1 << 0) +PAD_CTL_DSE_X2 (2 << 0) +PAD_CTL_DSE_X6 (3 << 0) Examples: While iomuxc-lpsr is intended to be used by dedicated peripherals to take
In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from the documentation. Changes since v2: * Changed patch title to 'dt-bindings: pinctrl: imx7d:' Signed-off-by: Christina Quast <cquast@hanoverdisplays.com> --- .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)