| Message ID | 20190407015447.39292-1-cai@lca.pw (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e663e1e06089773cdab03023563aead65cfed042 |
| Headers | show |
| Series | powerpc/pseries/pmem: fix a set but not used value | expand |
On 4/7/2019 7:24 AM, Qian Cai wrote: > The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory > support") set a local variable "count" in dlpar_hp_pmem() but never > use it. > > arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem': > arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count' > set but not used [-Wunused-but-set-variable] > > Signed-off-by: Qian Cai <cai@lca.pw> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > arch/powerpc/platforms/pseries/pmem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c > index 27f0a915c8a9..f860a897a9e0 100644 > --- a/arch/powerpc/platforms/pseries/pmem.c > +++ b/arch/powerpc/platforms/pseries/pmem.c > @@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index) > > int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog) > { > - u32 count, drc_index; > + u32 drc_index; > int rc; > > /* slim chance, but we might get a hotplug event while booting */ > @@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog) > return -EINVAL; > } > > - count = hp_elog->_drc_u.drc_count; > drc_index = hp_elog->_drc_u.drc_index; > > lock_device_hotplug();
diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c index 27f0a915c8a9..f860a897a9e0 100644 --- a/arch/powerpc/platforms/pseries/pmem.c +++ b/arch/powerpc/platforms/pseries/pmem.c @@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index) int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog) { - u32 count, drc_index; + u32 drc_index; int rc; /* slim chance, but we might get a hotplug event while booting */ @@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog) return -EINVAL; } - count = hp_elog->_drc_u.drc_count; drc_index = hp_elog->_drc_u.drc_index; lock_device_hotplug();
The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory support") set a local variable "count" in dlpar_hp_pmem() but never use it. arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem': arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count' set but not used [-Wunused-but-set-variable] Signed-off-by: Qian Cai <cai@lca.pw> --- arch/powerpc/platforms/pseries/pmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)