| Message ID | 20190405103224.16223-1-luca@lucaceresoli.net |
|---|---|
| State | Superseded |
| Delegated to: | Heiko Schocher |
| Headers | show |
| Series | [U-Boot,1/3] i2c: muxes: pca954x: update list of supported devices | expand |
On 05. 04. 19 12:32, Luca Ceresoli wrote: > The Kconfig help has not been updated while adding PCA9547 and PCA9646. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > drivers/i2c/muxes/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig > index b0da67ce2c6b..26be78f685de 100644 > --- a/drivers/i2c/muxes/Kconfig > +++ b/drivers/i2c/muxes/Kconfig > @@ -33,7 +33,7 @@ config I2C_MUX_PCA954x > I2C mux/switch devices. It is x width I2C multiplexer which enables to > partitioning I2C bus and connect multiple devices with the same address > to the same I2C controller where driver handles proper routing to > - target i2c device. PCA9544 and PCA9548 are supported. > + target i2c device. PCA9544, PCA9547 PCA9548 and PCA9646 are supported. missing comma there. M > > config I2C_MUX_GPIO > tristate "GPIO-based I2C multiplexer" >
Hi Michal, On 05/04/19 12:58, Michal Simek wrote: > On 05. 04. 19 12:32, Luca Ceresoli wrote: >> The Kconfig help has not been updated while adding PCA9547 and PCA9646. >> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> >> --- >> drivers/i2c/muxes/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig >> index b0da67ce2c6b..26be78f685de 100644 >> --- a/drivers/i2c/muxes/Kconfig >> +++ b/drivers/i2c/muxes/Kconfig >> @@ -33,7 +33,7 @@ config I2C_MUX_PCA954x >> I2C mux/switch devices. It is x width I2C multiplexer which enables to >> partitioning I2C bus and connect multiple devices with the same address >> to the same I2C controller where driver handles proper routing to >> - target i2c device. PCA9544 and PCA9548 are supported. >> + target i2c device. PCA9544, PCA9547 PCA9548 and PCA9646 are supported. > > missing comma there. Thank you for your very prompt reviews. I'll wait a few more days in case of more comments and then resend with the fixes you suggested.
Hello Luca, Am 05.04.2019 um 12:32 schrieb Luca Ceresoli: > The Kconfig help has not been updated while adding PCA9547 and PCA9646. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > --- > drivers/i2c/muxes/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) beside the comments from Michal, Reviewed-by: Heiko Schocher<hs@denx.de> bye, Heiko
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index b0da67ce2c6b..26be78f685de 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -33,7 +33,7 @@ config I2C_MUX_PCA954x I2C mux/switch devices. It is x width I2C multiplexer which enables to partitioning I2C bus and connect multiple devices with the same address to the same I2C controller where driver handles proper routing to - target i2c device. PCA9544 and PCA9548 are supported. + target i2c device. PCA9544, PCA9547 PCA9548 and PCA9646 are supported. config I2C_MUX_GPIO tristate "GPIO-based I2C multiplexer"
The Kconfig help has not been updated while adding PCA9547 and PCA9646. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- drivers/i2c/muxes/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)