| Message ID | 1302601774-24289-1-git-send-email-Joakim.Tjernlund@transmode.se |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> Date: Tue, 12 Apr 2011 11:49:34 +0200 > controlling igmp_max_membership is useful even when IP_MULTICAST > is off. > Quagga(an OSPF deamon) uses multicast addresses for all interfaces > using a single socket and hits igmp_max_membership limit when > there are 20 interfaces or more. > Always export sysctl igmp_max_memberships in proc, just like > igmp_max_msf > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> I really like your commit message, a full justification and a reference to existing similar behavior. If only every patch submitter did this :-/ Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller <davem@davemloft.net> wrote on 2011/04/12 23:00:16: > > From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> > Date: Tue, 12 Apr 2011 11:49:34 +0200 > > > controlling igmp_max_membership is useful even when IP_MULTICAST > > is off. > > Quagga(an OSPF deamon) uses multicast addresses for all interfaces > > using a single socket and hits igmp_max_membership limit when > > there are 20 interfaces or more. > > Always export sysctl igmp_max_memberships in proc, just like > > igmp_max_msf > > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> > > I really like your commit message, a full justification and a > reference to existing similar behavior. > > If only every patch submitter did this :-/ Thanks, I really wish all my commit msgs are like the above. Jocke -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index d96c1da..9cc2824 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -306,7 +306,6 @@ static struct ctl_table ipv4_table[] = { .mode = 0644, .proc_handler = proc_do_large_bitmap, }, -#ifdef CONFIG_IP_MULTICAST { .procname = "igmp_max_memberships", .data = &sysctl_igmp_max_memberships, @@ -314,8 +313,6 @@ static struct ctl_table ipv4_table[] = { .mode = 0644, .proc_handler = proc_dointvec }, - -#endif { .procname = "igmp_max_msf", .data = &sysctl_igmp_max_msf,
controlling igmp_max_membership is useful even when IP_MULTICAST is off. Quagga(an OSPF deamon) uses multicast addresses for all interfaces using a single socket and hits igmp_max_membership limit when there are 20 interfaces or more. Always export sysctl igmp_max_memberships in proc, just like igmp_max_msf Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> --- net/ipv4/sysctl_net_ipv4.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)