Message ID | 1297120981-29885-1-git-send-email-loic.minier@linaro.org |
---|---|
State | Changes Requested |
Headers | show |
Dear =?UTF-8?q?Lo=C3=AFc=20Minier?=, In message <1297120981-29885-1-git-send-email-loic.minier@linaro.org> you wrote: > mtd/mtd-user.h is missing on FreeBSD hosts; add a macro to test whether > a specific host header is present and use it to decide to build > fw_printenv if mtd/mtd-user.h is present. > --- Sorry for the delay. I understand thi is just a RFC, not a patch (yet) intended for inclusion? [In that case it would miss your SoB line...] > How about this approach? > > If it's ok, then I could extend it to handle the MTD_VERSION=old case as well, > perhaps replacing this MTD_VERSION with a test for linux/mtd/mtd.h. I'm fine with that. Thanks! Best regards, Wolfgang Denk
On Tue, Apr 12, 2011, Wolfgang Denk wrote: > I understand thi is just a RFC, not a patch (yet) intended for > inclusion? [In that case it would miss your SoB line...] Correct! was just a RFC (albeit I did include it in the Debian packaging for now, until we have an upstreamable way of doing it) > > How about this approach? If it's ok, then I could extend it to > > handle the MTD_VERSION=old case as well, perhaps replacing this > > MTD_VERSION with a test for linux/mtd/mtd.h. > I'm fine with that. Thanks! Ok, will resubmit; thanks for the comment :-) I'll likely replace MTD_OLD with similar logic and hence avoid passing it down; it will just be autodetected.
diff --git a/tools/env/Makefile b/tools/env/Makefile index 2f7a59c..294bb95 100644 --- a/tools/env/Makefile +++ b/tools/env/Makefile @@ -36,7 +36,18 @@ ifeq ($(MTD_VERSION),old) HOSTCPPFLAGS += -DMTD_OLD endif +# macro to check whether a host header is present; outputs 1 if present, 0 if +# not +check_include = $(shell echo | $(HOSTCC) $(HOSTCFLAGS_NOPED) -E -include $(1) -o /dev/null - 2>/dev/null && echo 1 || echo 0) + +# whether to build tools/env or not +has_mtd_user := $(call check_include, mtd/mtd-user.h) + +ifeq ($(has_mtd_user),1) all: $(obj)fw_printenv +else +all: +endif # Some files complain if compiled with -pedantic, use HOSTCFLAGS_NOPED $(obj)fw_printenv: $(HOSTSRCS) $(HEADERS)