diff mbox series

[U-Boot] pci: pci_mvebu: Add comment about missing of_n_addr_cells() call

Message ID 20190211065334.27609-1-sr@denx.de
State Accepted
Commit 0df62e8da8f48d8bbabd1d92512173cbb424e3c5
Delegated to: Stefan Roese
Headers show
Series [U-Boot] pci: pci_mvebu: Add comment about missing of_n_addr_cells() call | expand

Commit Message

Stefan Roese Feb. 11, 2019, 6:53 a.m. UTC 
This patch adds a comment to explain the use of the hardcoded value for
the number of address cells in mvebu_get_tgt_attr(). This should help to
rework this function, once CONFIG_OF_LIVE is enabled for MVEBU in
general.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Bin Meng <bmeng.cn@gmail.com>
---
 drivers/pci/pci_mvebu.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stefan Roese March 19, 2019, 12:36 p.m. UTC | #1 
On 11.02.19 07:53, Stefan Roese wrote:
> This patch adds a comment to explain the use of the hardcoded value for
> the number of address cells in mvebu_get_tgt_attr(). This should help to
> rework this function, once CONFIG_OF_LIVE is enabled for MVEBU in
> general.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot-marvell/master.

Thanks,
Stefan
diff mbox series

Patch

diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
index 6026fa67f9..e21dc10c2f 100644
--- a/drivers/pci/pci_mvebu.c
+++ b/drivers/pci/pci_mvebu.c
@@ -369,6 +369,12 @@  static int mvebu_get_tgt_attr(ofnode node, int devfn,
 	if (!range)
 		return -EINVAL;
 
+	/*
+	 * Linux uses of_n_addr_cells() to get the number of address cells
+	 * here. Currently this function is only available in U-Boot when
+	 * CONFIG_OF_LIVE is enabled. Until this is enabled for MVEBU in
+	 * general, lets't hardcode the "pna" value in the U-Boot code.
+	 */
 	pna = 2; /* hardcoded for now because of lack of of_n_addr_cells() */
 	rangesz = pna + na + ns;
 	nranges = rlen / sizeof(__be32) / rangesz;