Message ID | 20190130035935.235565-13-sjg@chromium.org |
---|---|
State | Superseded |
Delegated to: | Bin Meng |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OQNo5QMa"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43q8wL1jQPz9sBQ for <incoming@patchwork.ozlabs.org>; Wed, 30 Jan 2019 15:07:46 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id BDA4FC21C93; Wed, 30 Jan 2019 04:02:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BA693C21C2C; Wed, 30 Jan 2019 04:00:46 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id C6190C21E12; Wed, 30 Jan 2019 04:00:31 +0000 (UTC) Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) by lists.denx.de (Postfix) with ESMTPS id CB046C21DFF for <u-boot@lists.denx.de>; Wed, 30 Jan 2019 04:00:27 +0000 (UTC) Received: by mail-it1-f197.google.com with SMTP id p66so17760033itc.0 for <u-boot@lists.denx.de>; Tue, 29 Jan 2019 20:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=vBEk/CkFognQA8yUPwp4crt4SizgiyEVcBX/bC97tLw=; b=OQNo5QMa+xk52pf+OrGnvqvgBioaetpZWPSj5CqJJmpcY3RuHx7ArQk1sOOLevfbem MEBCoApY4VAMTYqud5D5Wa0fOIbTe4s5RSxevgoplf6CGQHMx4bRxj/0iUWYc3b+4WeR 5Iy3YipGuY7OTxc6PhFdp+3F/KYoo9C7oVyaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=vBEk/CkFognQA8yUPwp4crt4SizgiyEVcBX/bC97tLw=; b=YdxZLyrXZpQqLS/J1WXepXDKh3dG3iEti1KDYrxymNwQY+JAFRVHRpbF3D0atwV4m7 m1sVUWCMuFbZ+tjIP91GiDAuznfz1ud+TLUIsX2l836p3NZN0evydgowyp7ebl5i4SoW 4rxGksBqH0+yk4AoVbuvo70r5jfcrM74nnKdeWf2aHcFVMfnZMSOuJaSCWFcWZ8qQKuO HwMnsnw039ZSCEchrweG/2JoWYvvi3Sn7W8zC5PzfGWeJmSmVaPHoZr0Up5EmO/RwYul JgVTQqMbrSVQe8yvadKs6q2OUWjwk0ZcWzMsUQ3CCi4/5ufwM8PUSZ6q+mV9liYV6s1Z Ay0w== X-Gm-Message-State: AHQUAuYqiIS+TPbyQZ3V5j6EUfLRr5hhRZnEF+649GmT6dQqK/70LHJC v0Nm8K6iDUW7Pi2/Q9TQuPoW3+oeCvRRXB1m X-Google-Smtp-Source: AHgI3IZ5kAL2EubJBuSWh0UiK4msmgyzxXsa5go8dVrI8aJcag2LzcFqDu5T++etq6EueW1U7SYITB6KOB22E8YN X-Received: by 2002:a24:a945:: with SMTP id x5mr5002226iti.26.1548820826874; Tue, 29 Jan 2019 20:00:26 -0800 (PST) Date: Tue, 29 Jan 2019 20:59:07 -0700 In-Reply-To: <20190130035935.235565-1-sjg@chromium.org> Message-Id: <20190130035935.235565-13-sjg@chromium.org> Mime-Version: 1.0 References: <20190130035935.235565-1-sjg@chromium.org> X-Mailer: git-send-email 2.20.1.495.gaa96b0ce6b-goog From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Subject: [U-Boot] [PATCH 12/40] x86: Update a stale comment about ifdtool X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
Series |
x86: Add support for booting from TPL
|
expand
|
Hi Simon, On Wed, Jan 30, 2019 at 12:00 PM Simon Glass <sjg@chromium.org> wrote: > > We use binman to build the x86 image now. Update a comment which still > refers to ifdtool. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/intel_common/car.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> But we should apply the same change in arch/x86/lib/fsp/fsp_car.S too. Regards, Bin
diff --git a/arch/x86/cpu/intel_common/car.S b/arch/x86/cpu/intel_common/car.S index 52a77bb2d1..00308dbdef 100644 --- a/arch/x86/cpu/intel_common/car.S +++ b/arch/x86/cpu/intel_common/car.S @@ -235,7 +235,7 @@ mtrr_table_end: .align 4 _dt_ucode_base_size: - /* These next two fields are filled in by ifdtool */ + /* These next two fields are filled in by binman */ .globl ucode_base ucode_base: /* Declared in microcode.h */ .long 0 /* microcode base */
We use binman to build the x86 image now. Update a comment which still refers to ifdtool. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/intel_common/car.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)