| Message ID | 20190218125930.87548-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64be | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
On Mon, 18 Feb 2019, YueHaibing wrote: > Remove .owner field if calls are used which set it automatically > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/platforms/pseries/papr_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > index bba281b1fe1b..e3f5c1a01950 100644 > --- a/arch/powerpc/platforms/pseries/papr_scm.c > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > @@ -21,6 +21,7 @@ > (1ul << ND_CMD_GET_CONFIG_DATA) | \ > (1ul << ND_CMD_SET_CONFIG_DATA)) > > + No need to add a blank line. julia > struct papr_scm_priv { > struct platform_device *pdev; > struct device_node *dn; > @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = { > .remove = papr_scm_remove, > .driver = { > .name = "papr_scm", > - .owner = THIS_MODULE, > .of_match_table = papr_scm_match, > }, > }; > > > >
On 2019/2/18 20:53, Julia Lawall wrote: > > > On Mon, 18 Feb 2019, YueHaibing wrote: > >> Remove .owner field if calls are used which set it automatically >> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> arch/powerpc/platforms/pseries/papr_scm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c >> index bba281b1fe1b..e3f5c1a01950 100644 >> --- a/arch/powerpc/platforms/pseries/papr_scm.c >> +++ b/arch/powerpc/platforms/pseries/papr_scm.c >> @@ -21,6 +21,7 @@ >> (1ul << ND_CMD_GET_CONFIG_DATA) | \ >> (1ul << ND_CMD_SET_CONFIG_DATA)) >> >> + > > No need to add a blank line. Yes, will fix it. > > julia > >> struct papr_scm_priv { >> struct platform_device *pdev; >> struct device_node *dn; >> @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = { >> .remove = papr_scm_remove, >> .driver = { >> .name = "papr_scm", >> - .owner = THIS_MODULE, >> .of_match_table = papr_scm_match, >> }, >> }; >> >> >> >> > > . >
diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c index bba281b1fe1b..e3f5c1a01950 100644 --- a/arch/powerpc/platforms/pseries/papr_scm.c +++ b/arch/powerpc/platforms/pseries/papr_scm.c @@ -21,6 +21,7 @@ (1ul << ND_CMD_GET_CONFIG_DATA) | \ (1ul << ND_CMD_SET_CONFIG_DATA)) + struct papr_scm_priv { struct platform_device *pdev; struct device_node *dn; @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = { .remove = papr_scm_remove, .driver = { .name = "papr_scm", - .owner = THIS_MODULE, .of_match_table = papr_scm_match, }, };
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)