| Message ID | 20190130115552.9610-1-bbrezillon@kernel.org |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtd: Make sure mtd->erasesize is valid even if the partition is of size 0 | expand |
Hi Boris, On Wed, Jan 30, 2019 at 12:56 PM Boris Brezillon <bbrezillon@kernel.org> wrote: > Commit 33f45c44d68b ("mtd: Do not allow MTD devices with inconsistent > erase properties") introduced a check to make sure ->erasesize and > ->_erase values are consistent with the MTD_NO_ERASE flag. > This patch did not take the 0 bytes partition case into account which > can happen when the defined partition is outside the flash device memory > range. Fix that by setting the partition erasesize to the parent > erasesize. > > Fixes: 33f45c44d68b ("mtd: Do not allow MTD devices with inconsistent erase properties") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: <stable@vger.kernel.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Boris Brezillon <bbrezillon@kernel.org> Thanks, that made the warning disappear. Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
From: Your Name <patch-notifications@your-domain.com> On Wed, 2019-01-30 at 11:55:52 UTC, Boris Brezillon wrote: > Commit 33f45c44d68b ("mtd: Do not allow MTD devices with inconsistent > erase properties") introduced a check to make sure ->erasesize and > ->_erase values are consistent with the MTD_NO_ERASE flag. > This patch did not take the 0 bytes partition case into account which > can happen when the defined partition is outside the flash device memory > range. Fix that by setting the partition erasesize to the parent > erasesize. > > Fixes: 33f45c44d68b ("mtd: Do not allow MTD devices with inconsistent erase properties") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: <stable@vger.kernel.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Boris Brezillon <bbrezillon@kernel.org> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks. y'all come back now!
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index e6d9467f6be0..37f174ccbcec 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -480,6 +480,10 @@ static struct mtd_part *allocate_partition(struct mtd_info *parent, /* let's register it anyway to preserve ordering */ slave->offset = 0; slave->mtd.size = 0; + + /* Initialize ->erasesize to make add_mtd_device() happy. */ + slave->mtd.erasesize = parent->erasesize; + printk(KERN_ERR"mtd: partition \"%s\" is out of reach -- disabled\n", part->name); goto out_register;
Commit 33f45c44d68b ("mtd: Do not allow MTD devices with inconsistent erase properties") introduced a check to make sure ->erasesize and ->_erase values are consistent with the MTD_NO_ERASE flag. This patch did not take the 0 bytes partition case into account which can happen when the defined partition is outside the flash device memory range. Fix that by setting the partition erasesize to the parent erasesize. Fixes: 33f45c44d68b ("mtd: Do not allow MTD devices with inconsistent erase properties") Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: <stable@vger.kernel.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Boris Brezillon <bbrezillon@kernel.org> --- drivers/mtd/mtdpart.c | 4 ++++ 1 file changed, 4 insertions(+)