[v2,4/6] ffmpeg: bump to version 4.1. ffserver is not supported anymore.

Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
---
 package/ffmpeg/0001-ffmpeg-pthreads.patch | 34 -----------------------
 package/ffmpeg/Config.in                  |  6 ----
 package/ffmpeg/ffmpeg.hash                |  2 +-
 package/ffmpeg/ffmpeg.mk                  |  8 +-----
 4 files changed, 2 insertions(+), 48 deletions(-)
 delete mode 100644 package/ffmpeg/0001-ffmpeg-pthreads.patch

Hello,

The commit title should be just:

	package/ffmpeg: bump to version 4.1

The fact that ffserver is removed should be part of the commit log.

On Thu, 31 Jan 2019 13:15:24 +0100
Louis-Paul Cordier <lpdev@cordier.org> wrote:

> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>

I'd like to hear from Bernd about this ffmpeg bump. If I remember well,
major ffmpeg bumps are typically breaking some APIs, causing build
issues with packages that use ffmpeg.

Have you verified that other Buildroot packages that use ffmpeg do not
break after this ffmpeg version bump ?

>  package/ffmpeg/0001-ffmpeg-pthreads.patch | 34 -----------------------

Would be good to mention in the sommit log why this patch is removed
(accepted upstream ? no longer relevant ?)


> -config BR2_PACKAGE_FFMPEG_FFSERVER
> -	bool "Build ffserver"
> -	depends on BR2_USE_MMU # fork()
> -	help
> -	  FFserver is a streaming server for both audio and video.

If ffserver is no longer supported, we want to move this option to
Config.in.legacy so that users who have configurations with this
enabled are aware.

Thanks!

Thomas

Am Sat, 02 Feb 2019 15:54:00 +0100 schrieb Thomas Petazzoni:

> I'd like to hear from Bernd about this ffmpeg bump. If I remember well,
> major ffmpeg bumps are typically breaking some APIs, causing build
> issues with packages that use ffmpeg.

Hi Thomas,

afaik the only package left over to be fixed before we bump ffmpeg to 4.x 
is gstreamer1/gst1-libav, see my patch:
http://patchwork.ozlabs.org/patch/962138/

In the meantime upstream released version 1.15.1 as unstable release so 
we have two choices: Apply my patch or bump gstreamer1 to an unstable 
version.

Regards, Bernd

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Am Sat, 02 Feb 2019 15:54:00 +0100 schrieb Thomas Petazzoni:
 >> I'd like to hear from Bernd about this ffmpeg bump. If I remember well,
 >> major ffmpeg bumps are typically breaking some APIs, causing build
 >> issues with packages that use ffmpeg.

 > Hi Thomas,

 > afaik the only package left over to be fixed before we bump ffmpeg to 4.x 
 > is gstreamer1/gst1-libav, see my patch:
 > http://patchwork.ozlabs.org/patch/962138/

 > In the meantime upstream released version 1.15.1 as unstable release so 
 > we have two choices: Apply my patch or bump gstreamer1 to an unstable 
 > version.

I would prefer to stick with the stable versions if possible.

> De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> À : Louis-Paul Cordier <lpdev@cordier.org>
> Sujet : Re: [Buildroot] [PATCH v2 4/6] ffmpeg: bump to version 4.1. ffserver is not supported anymore.
> Date : 02/02/2019 15:54:00 Europe/Paris
> Copie à : buildroot@buildroot.org;
>    Bernd Kuhls <bernd.kuhls@t-online.de>;
>    MahyarKoshkouei <mahyar.koshkouei@gmail.com>
>
> Hello,
>
> The commit title should be just:
>
> package/ffmpeg: bump to version 4.1
>
> The fact that ffserver is removed should be part of the commit log.
>

Will be added.

> On Thu, 31 Jan 2019 13:15:24 +0100
> Louis-Paul Cordier <lpdev@cordier.org> wrote:
>
> > Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
>
> I'd like to hear from Bernd about this ffmpeg bump. If I remember well,
> major ffmpeg bumps are typically breaking some APIs, causing build
> issues with packages that use ffmpeg.
>

According to my experience with FFMpeg, API are marked as deprecated. They can still be used and linked correctly against all application. However, the behaviour of the program can differ. What about creating a ffmpeg4 package, just like opencv2/3 packages?

> Have you verified that other Buildroot packages that use ffmpeg do not
> break after this ffmpeg version bump ?
>
> > package/ffmpeg/0001-ffmpeg-pthreads.patch | 34 -----------------------
>
> Would be good to mention in the sommit log why this patch is removed
> (accepted upstream ? no longer relevant ?)
>

The patch did not apply to ffmpeg4. To be honest, I did not investigate this. Thank you for pointing this out I will rework this.

>
> > -config BR2_PACKAGE_FFMPEG_FFSERVER
> > - bool "Build ffserver"
> > - depends on BR2_USE_MMU # fork()
> > - help
> > - FFserver is a streaming server for both audio and video.
>
> If ffserver is no longer supported, we want to move this option to
> Config.in.legacy so that users who have configurations with this
> enabled are aware.
>

This does not appear in the official documentation. Would it be possible to add it?

> Thanks!
>
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Hello,

On Sun, 03 Feb 2019 09:48:22 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> afaik the only package left over to be fixed before we bump ffmpeg to 4.x 
> is gstreamer1/gst1-libav, see my patch:
> http://patchwork.ozlabs.org/patch/962138/

OK, I see this patch is marked as Changes Requested. Louis-Paul:
before we can update ffmpeg to 4.x, we need to solve this issue. So we
need to have a solution to this gstreamer1/gst1-libav ffmpeg 4.x
compatibiility issue in your patch series, prior to the ffmpeg 4.x bump.

Best regards,

Thomas

Hello,

On Mon,  4 Feb 2019 10:30:54 +0100 (CET)
lpdev@cordier.org wrote:

> > I'd like to hear from Bernd about this ffmpeg bump. If I remember well,
> > major ffmpeg bumps are typically breaking some APIs, causing build
> > issues with packages that use ffmpeg.
> 
> According to my experience with FFMpeg, API are marked as deprecated.
> They can still be used and linked correctly against all application.

Did you see the feedback from Bernd ? I know Bernd always forgets to Cc
people when replying, so make sure to check the mailing list for his
reply.

> However, the behaviour of the program can differ. What about creating
> a ffmpeg4 package, just like opencv2/3 packages?

Apparently, except for gstreamer1/gst1-libav that needs to be fixed for
ffmpeg 4.x, all other packages have already been fixed to work with
ffmpeg 4.x. So there is no reason to introduce a separate ffmpeg4
package. It would create more complexity/

> > If ffserver is no longer supported, we want to move this option to
> > Config.in.legacy so that users who have configurations with this
> > enabled are aware.
> 
> This does not appear in the official documentation. Would it be
> possible to add it?

Patches welcome ! :-)

Thomas