| Message ID | 1300768049-12982-1-git-send-email-chander.kashyap@linaro.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Dear Chander Kashyap, On 22 March 2011 13:27, Chander Kashyap <chander.kashyap@linaro.org> wrote: > MMC controller "control4" register offset set to > 0x8C as per data sheet. > Added missed out reserved field. > Updated padding field size. > > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> > --- > arch/arm/include/asm/arch-s5pc1xx/mmc.h | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > Your patches are OK. But, please make single patch including s5pc1xx and s5pc2xx. Thanks Minkyu Kang.
Hi, On 22 March 2011 14:33, Minkyu Kang <promsoft@gmail.com> wrote: > Dear Chander Kashyap, > > On 22 March 2011 13:27, Chander Kashyap <chander.kashyap@linaro.org> wrote: >> MMC controller "control4" register offset set to >> 0x8C as per data sheet. >> Added missed out reserved field. >> Updated padding field size. >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >> --- >> arch/arm/include/asm/arch-s5pc1xx/mmc.h | 5 +++-- >> 1 files changed, 3 insertions(+), 2 deletions(-) >> > > Your patches are OK. > But, please make single patch including s5pc1xx and s5pc2xx. > We will re-submit a single patch with both the changes. > Thanks > Minkyu Kang. > -- > from. prom. > www.promsoft.net > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
diff --git a/arch/arm/include/asm/arch-s5pc1xx/mmc.h b/arch/arm/include/asm/arch-s5pc1xx/mmc.h index 48de64d..d458d3b 100644 --- a/arch/arm/include/asm/arch-s5pc1xx/mmc.h +++ b/arch/arm/include/asm/arch-s5pc1xx/mmc.h @@ -53,10 +53,11 @@ struct s5p_mmc { unsigned char res3[0x34]; unsigned int control2; unsigned int control3; + unsigned char res4[4]; unsigned int control4; - unsigned char res4[0x6e]; + unsigned char res5[0x6e]; unsigned short hcver; - unsigned char res5[0xFFF02]; + unsigned char res6[0xFFF00]; }; struct mmc_host {
MMC controller "control4" register offset set to 0x8C as per data sheet. Added missed out reserved field. Updated padding field size. Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> --- arch/arm/include/asm/arch-s5pc1xx/mmc.h | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)