| Message ID | 20190112092459.21382-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Commit | 838b9b6979496d297b1f6c64d9942cc3e9cfcef4 |
| Headers | show |
| Series | [1/1] sunxi-cedarx: needs -fPIC | expand |
Hello, On Sat, 12 Jan 2019 10:24:59 +0100, Fabrice Fontaine wrote: > Fixes: > - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Could you explain why we are seeing such build errors since December 5th, 2018, while the package hasn't been touched since 2016 ? What changed that makes those errors visible now ? Thanks, Thomas
Dear Thomas, Le sam. 12 janv. 2019 à 14:55, Thomas Petazzoni <thomas.petazzoni@bootlin.com> a écrit : > > Hello, > > On Sat, 12 Jan 2019 10:24:59 +0100, Fabrice Fontaine wrote: > > Fixes: > > - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > Could you explain why we are seeing such build errors since December > 5th, 2018, while the package hasn't been touched since 2016 ? What > changed that makes those errors visible now ? Yes, the issue is raised only when BR2_OPTIMIZE_2 is set and autobuilders test -O2 only since December 3rd: https://git.buildroot.net/buildroot/commit/?id=aa556e2035c023d4328185a46e15df532e566067. > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Best Regards, Fabrice
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Fixes: > - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed, thanks.
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > Fixes: > - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2018.02.x and 2018.11.x, thanks.
diff --git a/package/sunxi-cedarx/sunxi-cedarx.mk b/package/sunxi-cedarx/sunxi-cedarx.mk index 219f1bc74b..5b99f04181 100644 --- a/package/sunxi-cedarx/sunxi-cedarx.mk +++ b/package/sunxi-cedarx/sunxi-cedarx.mk @@ -19,7 +19,7 @@ SUNXI_CEDARX_BIN_DIR = $(@D)/libcedarv/linux-armel2 endif define SUNXI_CEDARX_BUILD_AVHEAP - $(TARGET_CC) $(TARGET_CFLAGS) \ + $(TARGET_CC) $(TARGET_CFLAGS) -fPIC \ -c $(SUNXI_CEDARX_BIN_DIR)/adapter/avheap/avheap.c \ -o $(SUNXI_CEDARX_BIN_DIR)/adapter/avheap/avheap.o \ -I $(SUNXI_CEDARX_BIN_DIR)/adapter/avheap \
Fixes: - http://autobuild.buildroot.org/results/c17062e1558f26c2db837883a0c33ef39dd031a2 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/sunxi-cedarx/sunxi-cedarx.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)