mbox series

[V2,0/5] i2c:ocores: improvements

Message ID 20181029145051.31984-1-federico.vaga@cern.ch
Headers show
Series i2c:ocores: improvements | expand

Message

Federico Vaga Oct. 29, 2018, 2:50 p.m. UTC
This patch set provides improvements to the i2c-ocore driver.

[V1 -> V2]
- replaced usleep_range() with udelay() so that the polling version can be
  used in atomic context.
- added dedicated patch for minor style issues
- fixed delay computation
- use spin_lock_irqsave(), instead of spin_trylock_irqsave(). IACK is always
  necessary and a trylock would generate an extra interrupt for nothing
- make the driver ready for an eventual master_xfer_irqless()

Comments

Wolfram Sang Nov. 27, 2018, 11:38 a.m. UTC | #1
> This patch set provides improvements to the i2c-ocore driver.
> 
> [V1 -> V2]
> - replaced usleep_range() with udelay() so that the polling version can be
>   used in atomic context.
> - added dedicated patch for minor style issues
> - fixed delay computation
> - use spin_lock_irqsave(), instead of spin_trylock_irqsave(). IACK is always
>   necessary and a trylock would generate an extra interrupt for nothing
> - make the driver ready for an eventual master_xfer_irqless()

Peter, do you have a time slot to review this?
Federico Vaga Jan. 15, 2019, 4:37 p.m. UTC | #2
Hi there,

I just want to ask if there has been any update about this patchset that I'm 
not aware off. Thanks

On Tuesday, November 27, 2018 12:38:22 PM CET Wolfram Sang wrote:
> > This patch set provides improvements to the i2c-ocore driver.
> > 
> > [V1 -> V2]
> > - replaced usleep_range() with udelay() so that the polling version can be
> > 
> >   used in atomic context.
> > 
> > - added dedicated patch for minor style issues
> > - fixed delay computation
> > - use spin_lock_irqsave(), instead of spin_trylock_irqsave(). IACK is
> > always> 
> >   necessary and a trylock would generate an extra interrupt for nothing
> > 
> > - make the driver ready for an eventual master_xfer_irqless()
> 
> Peter, do you have a time slot to review this?
Wolfram Sang Jan. 15, 2019, 10:49 p.m. UTC | #3
On Tue, Jan 15, 2019 at 05:37:07PM +0100, Federico Vaga wrote:
> Hi there,
> 
> I just want to ask if there has been any update about this patchset that I'm 
> not aware off. Thanks

I don't think so. Peter, what is the status of this series?