Message ID | AANLkTin=7j_UNw6cgHeNHjusMebB8NVMLUtzsPQGDsJX@mail.gmail.com |
---|---|
State | New |
Headers | show |
On Sat, Mar 19, 2011 at 10:45:34AM +0200, Blue Swirl wrote: > Remove a write-only variable, spotted by GCC 4.6.0: > /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init': > /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial' > set but not used [-Werror=unused-but-set-variable] Thanks, feel free to apply. Cheers > > Signed-off-by: Blue Swirl <blauwirbel@gmail.com> > --- > hw/petalogix_ml605_mmu.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c > index ca0986a..8213902 100644 > --- a/hw/petalogix_ml605_mmu.c > +++ b/hw/petalogix_ml605_mmu.c > @@ -150,7 +150,6 @@ petalogix_ml605_init(ram_addr_t ram_size, > ram_addr_t phys_ram; > ram_addr_t phys_flash; > qemu_irq irq[32], *cpu_irq; > - void *serial = NULL; > > /* init CPUs */ > if (cpu_model == NULL) { > @@ -185,8 +184,8 @@ petalogix_ml605_init(ram_addr_t ram_size, > irq[i] = qdev_get_gpio_in(dev, i); > } > > - serial = serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], > - 115200, serial_hds[0], 1, 0); > + serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], 115200, > + serial_hds[0], 1, 0); > > /* 2 timers at irq 2 @ 100 Mhz. */ > xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000); > -- > 1.6.2.4
On Sun, Mar 20, 2011 at 12:53 AM, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > On Sat, Mar 19, 2011 at 10:45:34AM +0200, Blue Swirl wrote: >> Remove a write-only variable, spotted by GCC 4.6.0: >> /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init': >> /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial' >> set but not used [-Werror=unused-but-set-variable] > > Thanks, feel free to apply. OK, applied.
diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c index ca0986a..8213902 100644 --- a/hw/petalogix_ml605_mmu.c +++ b/hw/petalogix_ml605_mmu.c @@ -150,7 +150,6 @@ petalogix_ml605_init(ram_addr_t ram_size, ram_addr_t phys_ram; ram_addr_t phys_flash; qemu_irq irq[32], *cpu_irq; - void *serial = NULL; /* init CPUs */ if (cpu_model == NULL) { @@ -185,8 +184,8 @@ petalogix_ml605_init(ram_addr_t ram_size, irq[i] = qdev_get_gpio_in(dev, i); } - serial = serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], - 115200, serial_hds[0], 1, 0); + serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], 115200, + serial_hds[0], 1, 0); /* 2 timers at irq 2 @ 100 Mhz. */ xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
Remove a write-only variable, spotted by GCC 4.6.0: /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init': /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Blue Swirl <blauwirbel@gmail.com> --- hw/petalogix_ml605_mmu.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)