| Message ID | 20181231103126.3679-1-sun_lianwen@163.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Alexey Kodanev |
| Headers | show |
| Series | network/busy_poll: Change the "ethtool --show-features to "ethtool -k" | expand |
Hi Sun, > To keep the same struct of "ethtool -i $(tst_iface)", > change the "ethtool --show-features" to "ethtool -k". --show-features is the same as -k, so what is the improvement? Kind regards, Petr
diff --git a/testcases/network/busy_poll/busy_poll_lib.sh b/testcases/network/busy_poll/busy_poll_lib.sh index 5270a1bbd..2a24ff262 100755 --- a/testcases/network/busy_poll/busy_poll_lib.sh +++ b/testcases/network/busy_poll/busy_poll_lib.sh @@ -22,8 +22,7 @@ busy_poll_check_config() fi if tst_kvcmp -lt "4.5"; then - ethtool --show-features $(tst_iface) | \ - grep -q 'busy-poll.*on' || \ + ethtool -k $(tst_iface) | grep -q 'busy-poll.*on' || \ tst_brk TCONF "busy poll not supported by driver" else drvs="bnx2x|bnxt|cxgb4|enic|benet|ixgbe|ixgbevf|mlx4|mlx5|myri10ge|sfc|virtio"
To keep the same struct of "ethtool -i $(tst_iface)", change the "ethtool --show-features" to "ethtool -k". Signed-off-by: Sun Lianwen <sun_lianwen@163.com> --- testcases/network/busy_poll/busy_poll_lib.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)