| Message ID | 1300345860-16574-1-git-send-email-Hong-Xing.Zhu@freescale.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Thu, Mar 17, 2011 at 03:10:58PM +0800, Richard Zhu wrote: > Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com> > --- > include/linux/ahci_platform.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h > index be3d9a7..86b5e24 100644 > --- a/include/linux/ahci_platform.h > +++ b/include/linux/ahci_platform.h > @@ -26,6 +26,8 @@ struct ahci_platform_data { > const struct ata_port_info *ata_port_info; > unsigned int force_port_map; > unsigned int mask_port_map; > + struct clk *sata_clk; > + struct clk *sata_ref_clk; No, ahci_platform_data shouldn't be the dump place for arbitrary board data. Keep this to your board. Sascha
Hi Sascha: Thanks for your comments. Best Regards Richard Zhu > -----Original Message----- > From: Sascha Hauer [mailto:s.hauer@pengutronix.de] > Sent: Thursday, March 17, 2011 4:37 PM > To: Zhu Richard-R65037 > Cc: linux-arm-kernel@lists.infradead.org; jgarzik@pobox.com; > kernel@pengutronix.de; linux-ide@vger.kernel.org; > avorontsov@ru.mvista.com; eric@eukrea.com; eric.miao@linaro.org > Subject: Re: [PATCH V1 1/3] ahci_platform: add two clk pointer member > into ahci_platform_data struct > > On Thu, Mar 17, 2011 at 03:10:58PM +0800, Richard Zhu wrote: > > Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com> > > --- > > include/linux/ahci_platform.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/ahci_platform.h > > b/include/linux/ahci_platform.h index be3d9a7..86b5e24 100644 > > --- a/include/linux/ahci_platform.h > > +++ b/include/linux/ahci_platform.h > > @@ -26,6 +26,8 @@ struct ahci_platform_data { > > const struct ata_port_info *ata_port_info; > > unsigned int force_port_map; > > unsigned int mask_port_map; > > + struct clk *sata_clk; > > + struct clk *sata_ref_clk; > > No, ahci_platform_data shouldn't be the dump place for arbitrary board > data. Keep this to your board. Accepted, these modifications would be discarded. > > Sascha > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | http://www.pengutronix.de/ > | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 > | -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h index be3d9a7..86b5e24 100644 --- a/include/linux/ahci_platform.h +++ b/include/linux/ahci_platform.h @@ -26,6 +26,8 @@ struct ahci_platform_data { const struct ata_port_info *ata_port_info; unsigned int force_port_map; unsigned int mask_port_map; + struct clk *sata_clk; + struct clk *sata_ref_clk; }; #endif /* _AHCI_PLATFORM_H */
Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com> --- include/linux/ahci_platform.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)