diff mbox series

[v2,1/2] dbus: Use dbus_bool_t, not int for boolean function arguments

Message ID 20181007123151.27506-1-andrew.shadura@collabora.co.uk
State Accepted
Headers show
Series [v2,1/2] dbus: Use dbus_bool_t, not int for boolean function arguments | expand

Commit Message

Andrej Shadura Oct. 7, 2018, 12:31 p.m. UTC 
Properties argument specifies whether to add object’s properties
or not, hence it doesn’t need to be int.

Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
---
 wpa_supplicant/dbus/dbus_new.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Andrej Shadura Nov. 8, 2018, 6:08 p.m. UTC | #1 
On 07/10/2018 14:31, Andrej Shadura wrote:
> Properties argument specifies whether to add object’s properties
> or not, hence it doesn’t need to be int.

Any comments on this patch?
Andrej Shadura Nov. 28, 2018, 2:11 p.m. UTC | #2 
On 08/11/2018 19:08, Andrej Shadura wrote:
> On 07/10/2018 14:31, Andrej Shadura wrote:
>> Properties argument specifies whether to add object’s properties
>> or not, hence it doesn’t need to be int.
> 
> Any comments on this patch?

Jouni, could you please have a look at these two patches? It seems
they’ve fallen through cracks somewhere :)
Jouni Malinen Dec. 23, 2018, 3:30 p.m. UTC | #3 
On Sun, Oct 07, 2018 at 02:31:50PM +0200, Andrej Shadura wrote:
> Properties argument specifies whether to add object’s properties
> or not, hence it doesn’t need to be int.

Thanks, applied.
diff mbox series

Patch

diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
index e0f16bbda..24115fcbc 100644
--- a/wpa_supplicant/dbus/dbus_new.c
+++ b/wpa_supplicant/dbus/dbus_new.c
@@ -128,7 +128,7 @@  void wpas_dbus_unsubscribe_noc(struct wpas_dbus_priv *priv)
  * Notify listeners about event related with interface
  */
 static void wpas_dbus_signal_interface(struct wpa_supplicant *wpa_s,
-				       const char *sig_name, int properties)
+				       const char *sig_name, dbus_bool_t properties)
 {
 	struct wpas_dbus_priv *iface;
 	DBusMessage *msg;
@@ -230,7 +230,7 @@  void wpas_dbus_signal_scan_done(struct wpa_supplicant *wpa_s, int success)
  */
 static void wpas_dbus_signal_bss(struct wpa_supplicant *wpa_s,
 				 const char *bss_obj_path,
-				 const char *sig_name, int properties)
+				 const char *sig_name, dbus_bool_t properties)
 {
 	struct wpas_dbus_priv *iface;
 	DBusMessage *msg;
@@ -364,7 +364,7 @@  void wpas_dbus_signal_blob_removed(struct wpa_supplicant *wpa_s,
  */
 static void wpas_dbus_signal_network(struct wpa_supplicant *wpa_s,
 				     int id, const char *sig_name,
-				     int properties)
+				     dbus_bool_t properties)
 {
 	struct wpas_dbus_priv *iface;
 	DBusMessage *msg;
@@ -1882,7 +1882,7 @@  void wpas_dbus_signal_p2p_sd_response(struct wpa_supplicant *wpa_s,
  */
 static void wpas_dbus_signal_persistent_group(struct wpa_supplicant *wpa_s,
 					      int id, const char *sig_name,
-					      int properties)
+					      dbus_bool_t properties)
 {
 	struct wpas_dbus_priv *iface;
 	DBusMessage *msg;
@@ -4078,7 +4078,7 @@  static const struct wpa_dbus_signal_desc wpas_dbus_p2p_peer_signals[] = {
  */
 static void wpas_dbus_signal_peer(struct wpa_supplicant *wpa_s,
 				  const u8 *dev_addr, const char *interface,
-				  const char *sig_name, int properties)
+				  const char *sig_name, dbus_bool_t properties)
 {
 	struct wpas_dbus_priv *iface;
 	DBusMessage *msg;