Message ID | cover.1545194586.git.han_mao@c-sky.com |
---|---|
Headers | show |
Series | port C-SKY to glibc | expand |
This version of the port is OK (the whole port should go in a single commit). However, you need to review your ChangeLog entries and update them to reflect the current version of the port, as at present they refer to files that aren't actually added in the current version. You'll need to add yourself to <https://sourceware.org/glibc/wiki/MAINTAINERS> as port maintainer, to update <https://sourceware.org/glibc/wiki/ABIList> to list the ABIs and dynamic linker names for the port, to update <https://sourceware.org/glibc/wiki/PortStatus> to reflect whether ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA or static PIE support may be needed for this port, to update the template <https://sourceware.org/glibc/wiki/Release/X.Y> to include a section where results for this port would be reported in the copy of that page for each subsequent release, and to update <https://sourceware.org/glibc/wiki/Release/2.29> to include such a section for the current release cycle. Then, during each release's freeze period (January and July each year) you'll need to report test results for this port in that section on that release's wiki page.
On Thu, Dec 20, 2018 at 05:05:31PM +0000, Joseph Myers wrote: > This version of the port is OK (the whole port should go in a single > commit). However, you need to review your ChangeLog entries and update > them to reflect the current version of the port, as at present they refer > to files that aren't actually added in the current version. Committed within single commit, ChangeLog regenerated. Many thanks, to everyone who has helped review the C-SKY port. > You'll need to add yourself to > <https://sourceware.org/glibc/wiki/MAINTAINERS> as port maintainer, to > update <https://sourceware.org/glibc/wiki/ABIList> to list the ABIs and > dynamic linker names for the port, to update > <https://sourceware.org/glibc/wiki/PortStatus> to reflect whether > ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA or static PIE support may be needed > for this port, to update the template > <https://sourceware.org/glibc/wiki/Release/X.Y> to include a section where > results for this port would be reported in the copy of that page for each > subsequent release, and to update > <https://sourceware.org/glibc/wiki/Release/2.29> to include such a section > for the current release cycle. Then, during each release's freeze period > (January and July each year) you'll need to report test results for this > port in that section on that release's wiki page. Updated. Best Regards, Mao Han