mbox

[v3,00/12] Multi-AP support

Message ID 20181205102401.17810-1-arnout@mind.be
State Not Applicable
Headers show

Pull-request

https://github.com/prplfoundation/hostap.git multi-ap-v3

Message

Arnout Vandecappelle Dec. 5, 2018, 10:23 a.m. UTC
This series collects the different patches to add Multi-AP support to
wpa_supplicant and hostapd.

Patch 1 and 3 are new versions of
https://patchwork.ozlabs.org/patch/1006600/ and
https://patchwork.ozlabs.org/patch/1006601/ . The only changes are in
the commit message.

Patch 2 and 4-9 are gradual improvements on those two patches. I've
split them out to simplify review, but they can be squashed into patches
1 and 3 if that is preferred (I'm OK with dropping my authorship).

Patch 10 and 11 are new iterations of
https://patchwork.ozlabs.org/patch/999135/ and
https://patchwork.ozlabs.org/patch/978101/ . They are brought inline
with the changes introduced by patches 1 and 3, and all the things
discussed on the mailing list are taken into account. See the commit
message of those two patches for details.

Patch 12, finally, is an entirely new patch that adds a README for
Multi-AP.

I've build-tested each individual patch, but I've only functionally
tested the series as a whole, and only in OpenWRT context.

Please mark the old patches as Superseded in patchwork - I don't have
permission to do so.

Regards,
Arnout

----------------------------------------------------------------
The following changes since commit a3023841485e0e925236497cc777149b8dde7f18:

  tests: Call remove_group() after other cleanup is done (2018-11-26 01:00:00 +0200)

are available in the Git repository at:

  https://github.com/prplfoundation/hostap.git multi-ap-v3

for you to fetch changes up to 88d53d5a87f0b32dab165a1c7fa234c3dc1abdf6:

  hostapd: add README-MULTI-AP (2018-12-05 11:07:23 +0100)

----------------------------------------------------------------
Arnout Vandecappelle (Essensium/Mind) (8):
      hostapd: Remove CONFIG_MULTI_AP
      wpa_supplicant: Remove CONFIG_MULTI_AP
      wpa_supplicant: rename multiap_backhaul_sta -> multi_ap_backhaul_sta
      ieee802_11_common: factor out add_multi_ap_ie()
      wpa_supplicant.conf: improve documentation of multi_ap_backhaul_sta
      hostapd: fully validate multi-AP IE
      wpa_supplicant: SME: correct use of multi_ap_backhaul_sta
      hostapd: add README-MULTI-AP

Davina Lu (2):
      wpa_supplicant: support Multi-AP backhaul STA onboarding
      hostapd: support Multi-AP backhaul STA onboarding

Venkateswara Naralasetty (2):
      hostapd: Add Multi-AP protocol support
      wpa_supplicant: Add Multi-AP backhaul STA support

 hostapd/README-MULTI-AP            | 159 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 hostapd/config_file.c              |  53 +++++++++++++++++++++++++++++++++++++++++++++++
 hostapd/hostapd.conf               |  16 ++++++++++++++
 src/ap/ap_config.c                 |   2 ++
 src/ap/ap_config.h                 |   3 +++
 src/ap/ieee802_11.c                |  72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 src/ap/sta_info.c                  |   2 +-
 src/ap/sta_info.h                  |   1 +
 src/ap/wps_hostapd.c               |  26 +++++++++++++++++++++++
 src/common/ieee802_11_common.c     |  24 +++++++++++++++++++++
 src/common/ieee802_11_common.h     |   4 ++++
 src/common/ieee802_11_defs.h       |   8 +++++++
 src/drivers/driver.h               |   9 ++++++++
 src/drivers/driver_nl80211.c       |  41 ++++++++++++++++++++++++++++++++++++
 src/p2p/p2p_build.c                |   2 +-
 src/wps/wps.c                      |   6 +++---
 src/wps/wps.h                      |  38 ++++++++++++++++++++++++++++++++++
 src/wps/wps_attr_build.c           |  10 ++++++++-
 src/wps/wps_attr_parse.c           |  10 +++++++++
 src/wps/wps_attr_parse.h           |   1 +
 src/wps/wps_common.c               |  16 +++++++-------
 src/wps/wps_defs.h                 |   3 ++-
 src/wps/wps_dev_attr.c             |   5 +++++
 src/wps/wps_dev_attr.h             |   1 +
 src/wps/wps_enrollee.c             |  14 ++++++++-----
 src/wps/wps_er.c                   |   4 ++--
 src/wps/wps_i.h                    |   3 ++-
 src/wps/wps_registrar.c            |  40 ++++++++++++++++++++++++++++-------
 src/wps/wps_upnp.c                 |   2 +-
 wpa_supplicant/config.c            |   2 ++
 wpa_supplicant/config.h            |   2 ++
 wpa_supplicant/config_file.c       |   4 ++++
 wpa_supplicant/config_ssid.h       |   6 ++++++
 wpa_supplicant/driver_i.h          |   8 +++++++
 wpa_supplicant/events.c            |  49 +++++++++++++++++++++++++++++++++++++++++++
 wpa_supplicant/sme.c               |  13 +++++++++++-
 wpa_supplicant/wpa_supplicant.c    |  16 ++++++++++++++
 wpa_supplicant/wpa_supplicant.conf |  12 +++++++++++
 wpa_supplicant/wpa_supplicant_i.h  |   1 +
 wpa_supplicant/wps_supplicant.c    |  13 +++++++++++-
 40 files changed, 666 insertions(+), 35 deletions(-)
 create mode 100644 hostapd/README-MULTI-AP

Comments

Jouni Malinen Dec. 20, 2018, 4:28 p.m. UTC | #1
On Wed, Dec 05, 2018 at 11:23:50AM +0100, Arnout Vandecappelle (Essensium/Mind) wrote:
> This series collects the different patches to add Multi-AP support to
> wpa_supplicant and hostapd.

Thanks!

> Patch 1 and 3 are new versions of
> https://patchwork.ozlabs.org/patch/1006600/ and
> https://patchwork.ozlabs.org/patch/1006601/ . The only changes are in
> the commit message.
> 
> Patch 2 and 4-9 are gradual improvements on those two patches. I've
> split them out to simplify review, but they can be squashed into patches
> 1 and 3 if that is preferred (I'm OK with dropping my authorship).

Patches 1 and 3 needed number of cleanups and fixes and it was getting
really painful to do those changes with multiple other patches in the
series getting conflicts for each change.. I ended up having to squash
the other patches into 1 and 3 to maintain sanity. Anyway, the changes
from 1-9 are now applied with cleanup and couple of fixes. In addition,
I added tests/hwsim/test_multi_ap.py with test cases to cover these
association cases for Multi-AP.

> Patch 10 and 11 are new iterations of
> https://patchwork.ozlabs.org/patch/999135/ and
> https://patchwork.ozlabs.org/patch/978101/ . They are brought inline
> with the changes introduced by patches 1 and 3, and all the things
> discussed on the mailing list are taken into account. See the commit
> message of those two patches for details.
> 
> Patch 12, finally, is an entirely new patch that adds a README for
> Multi-AP.

I have open question on 10/12 and I dropped 11/12 and 12/12 from my
queue while waiting for 10/12 to get resolved first.

> I've build-tested each individual patch, but I've only functionally
> tested the series as a whole, and only in OpenWRT context.

In general, I would highly appreciate new test cases added to
tests/hwsim to cover all new functionality proposed for hostap.git. It
should be straightforward to extend test_multi_ap.py to cover the WPS
provisioning cases as well based on WPS examples from test_ap_wps.py.