| Message ID | 20181210102609.28819-1-fanjinke@hygon.cn |
|---|---|
| State | New |
| Headers | show |
| Series | x86: Add Hygon Dhyana support. | expand |
On 12/10/18 5:26 AM, fanjinke wrote: > This patch fix Hygon Dhyana processor CPU Vendor ID detection problem > in glibc sysdep module, current glibc codes doesn't recognize Dhyana > CPU Vendor ID("HygonGenuine") and set kind to arch_kind_other, which > result to incorrect zero value for __cache_sysconf() syscall. As Hygon > Dhyana share most architecture feature as AMD Family 17h, this patch > add Hygon CPU Vendor ID check and setup kind to arch_kind_amd and reuse > AMD code path, which lead to correct return value in __cache_sysconf() > syscall. we run the glibc test suite for both Hygon Dhyana and AMD EPYC > and found no failure case. > > Background: > Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture between > AMD and Haiguang Information Technology Co.,Ltd., aims at providing high > performance x86 processor for China server market. Its first generation > processor codename is Dhyana, which originates from AMD technology and > shares most of the architecture with AMD's family 17h, but with different > CPU Vendor ID("HygonGenuine")/Family series number(Family 18h). > > Related Hygon kernel patch can be found on > http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b. > 1538583282.git.puwen@hygon.cn > > Very appreciate everyone who has helped review and fix issues. Do you have copyright assignment papers filed with the FSF? This one-line change doesn't need copyright papers filed, but if you need to make more compilcated changes, then you will need them. > *Tested for Hygon:* > Before patching the results of hygon's tests: > Summary of test results: > 6 FAIL > 5927 PASS > 29 UNSUPPORTED > 17 XFAIL > 2 XPASS > Makefile:403: recipe for target 'tests' failed > make[1]: *** [tests] Error 1 > make[1]: Leaving directory > '/home/higon/space/src/opensrc/glibc/glibc/glibc' > Makefile:9: recipe for target 'check' failed > make: *** [check] Error 2 > > And the result of testing after patching: > Summary of test results: > 5945 PASS > 17 UNSUPPORTED > 17 XFAIL > 2 XPASS > make[1]: Leaving directory > '/home/higon/space/src/opensrc/glibc/glibc/glibc' > > *Tested for AMD:* > The test results did not change before and after patching: > Summary of test results: > 5951 PASS > 11 UNSUPPORTED > 17 XFAIL > 2 XPASS > make[1]: Leaving directory '/home/higon/glibc' > > ChangeLog: > > 2018-12-10 fanjinke <fanjinke@hygon.cn> > > * sysdeps/x86/cpu-features.c (init_cpu_features): > --- > sysdeps/x86/cpu-features.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c > index 5f9eefd408..86e78bfb78 100644 > --- a/sysdeps/x86/cpu-features.c > +++ b/sysdeps/x86/cpu-features.c > @@ -425,8 +425,9 @@ init_cpu_features (struct cpu_features *cpu_features) > cpu_features->feature[index_arch_Prefer_No_AVX512] > |= bit_arch_Prefer_No_AVX512; > } > - /* This spells out "AuthenticAMD". */ > - else if (ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65) > + /* This spells out "AuthenticAMD" or "HygonGenuine". */ > + else if ((ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65) > + || (ebx == 0x6f677948 && ecx == 0x656e6975 && edx == 0x6e65476e)) > { > unsigned int extended_model; This looks fine to me, and reuses the AMD code. I'd like to hear from Amit if this is OK for him, since he'll have to maintain this code as things diverge. Amit, Any objections? Reviewed-by: Carlos O'Donell <carlos@redhat.com>
On 12/11/2018 11:15 AM, Carlos O'Donell wrote: > On 12/10/18 5:26 AM, fanjinke wrote: >> This patch fix Hygon Dhyana processor CPU Vendor ID detection problem >> in glibc sysdep module, current glibc codes doesn't recognize Dhyana >> CPU Vendor ID("HygonGenuine") and set kind to arch_kind_other, which >> result to incorrect zero value for __cache_sysconf() syscall. As Hygon >> Dhyana share most architecture feature as AMD Family 17h, this patch >> add Hygon CPU Vendor ID check and setup kind to arch_kind_amd and reuse >> AMD code path, which lead to correct return value in __cache_sysconf() >> syscall. we run the glibc test suite for both Hygon Dhyana and AMD EPYC >> and found no failure case. >> >> Background: >> Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture between >> AMD and Haiguang Information Technology Co.,Ltd., aims at providing high >> performance x86 processor for China server market. Its first generation >> processor codename is Dhyana, which originates from AMD technology and >> shares most of the architecture with AMD's family 17h, but with different >> CPU Vendor ID("HygonGenuine")/Family series number(Family 18h). >> >> Related Hygon kernel patch can be found on >> http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b. >> 1538583282.git.puwen@hygon.cn >> >> Very appreciate everyone who has helped review and fix issues. > Do you have copyright assignment papers filed with the FSF? > > This one-line change doesn't need copyright papers filed, but if > you need to make more compilcated changes, then you will need > them. > >> *Tested for Hygon:* >> Before patching the results of hygon's tests: >> Summary of test results: >> 6 FAIL >> 5927 PASS >> 29 UNSUPPORTED >> 17 XFAIL >> 2 XPASS >> Makefile:403: recipe for target 'tests' failed >> make[1]: *** [tests] Error 1 >> make[1]: Leaving directory >> '/home/higon/space/src/opensrc/glibc/glibc/glibc' >> Makefile:9: recipe for target 'check' failed >> make: *** [check] Error 2 >> >> And the result of testing after patching: >> Summary of test results: >> 5945 PASS >> 17 UNSUPPORTED >> 17 XFAIL >> 2 XPASS >> make[1]: Leaving directory >> '/home/higon/space/src/opensrc/glibc/glibc/glibc' >> >> *Tested for AMD:* >> The test results did not change before and after patching: >> Summary of test results: >> 5951 PASS >> 11 UNSUPPORTED >> 17 XFAIL >> 2 XPASS >> make[1]: Leaving directory '/home/higon/glibc' >> >> ChangeLog: >> >> 2018-12-10 fanjinke<fanjinke@hygon.cn> >> >> * sysdeps/x86/cpu-features.c (init_cpu_features): >> --- >> sysdeps/x86/cpu-features.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c >> index 5f9eefd408..86e78bfb78 100644 >> --- a/sysdeps/x86/cpu-features.c >> +++ b/sysdeps/x86/cpu-features.c >> @@ -425,8 +425,9 @@ init_cpu_features (struct cpu_features *cpu_features) >> cpu_features->feature[index_arch_Prefer_No_AVX512] >> |= bit_arch_Prefer_No_AVX512; >> } >> - /* This spells out "AuthenticAMD". */ >> - else if (ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65) >> + /* This spells out "AuthenticAMD" or "HygonGenuine". */ >> + else if ((ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65) >> + || (ebx == 0x6f677948 && ecx == 0x656e6975 && edx == 0x6e65476e)) >> { >> unsigned int extended_model; > > This looks fine to me, and reuses the AMD code. > > I'd like to hear from Amit if this is OK for him, since he'll have to > maintain this code as things diverge. > > Amit, Any objections? > > Reviewed-by: Carlos O'Donell<carlos@redhat.com> > Hi Carlos, Thank you for your reply and reminder. The copyright issue is already under processing.
> -----Original Message----- > From: Carlos O'Donell <carlos@redhat.com> > Sent: Tuesday, December 11, 2018 8:45 AM > To: fanjinke <fanjinke@hygon.cn>; libc-alpha@sourceware.org; Pawar, Amit > <Amit.Pawar@amd.com> > Cc: H.J. Lu <hjl.tools@gmail.com> > Subject: Re: [PATCH] x86: Add Hygon Dhyana support. > > On 12/10/18 5:26 AM, fanjinke wrote: > > This patch fix Hygon Dhyana processor CPU Vendor ID detection problem > > in glibc sysdep module, current glibc codes doesn't recognize Dhyana > > CPU Vendor ID("HygonGenuine") and set kind to arch_kind_other, which > > result to incorrect zero value for __cache_sysconf() syscall. As Hygon > > Dhyana share most architecture feature as AMD Family 17h, this patch > > add Hygon CPU Vendor ID check and setup kind to arch_kind_amd and > > reuse AMD code path, which lead to correct return value in > > __cache_sysconf() syscall. we run the glibc test suite for both Hygon > > Dhyana and AMD EPYC and found no failure case. > > > > Background: > > Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture between > > AMD and Haiguang Information Technology Co.,Ltd., aims at providing > > high performance x86 processor for China server market. Its first > > generation processor codename is Dhyana, which originates from AMD > > technology and shares most of the architecture with AMD's family 17h, > > but with different CPU Vendor ID("HygonGenuine")/Family series > number(Family 18h). > > > > Related Hygon kernel patch can be found on > > http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b. > > 1538583282.git.puwen@hygon.cn > > > > Very appreciate everyone who has helped review and fix issues. > > Do you have copyright assignment papers filed with the FSF? > > This one-line change doesn't need copyright papers filed, but if you need to > make more compilcated changes, then you will need them. > > > *Tested for Hygon:* > > Before patching the results of hygon's tests: > > Summary of test results: > > 6 FAIL > > 5927 PASS > > 29 UNSUPPORTED > > 17 XFAIL > > 2 XPASS > > Makefile:403: recipe for target 'tests' failed > > make[1]: *** [tests] Error 1 > > make[1]: Leaving directory > > '/home/higon/space/src/opensrc/glibc/glibc/glibc' > > Makefile:9: recipe for target 'check' failed > > make: *** [check] Error 2 > > > > And the result of testing after patching: > > Summary of test results: > > 5945 PASS > > 17 UNSUPPORTED > > 17 XFAIL > > 2 XPASS > > make[1]: Leaving directory > > '/home/higon/space/src/opensrc/glibc/glibc/glibc' > > > > *Tested for AMD:* > > The test results did not change before and after patching: > > Summary of test results: > > 5951 PASS > > 11 UNSUPPORTED > > 17 XFAIL > > 2 XPASS > > make[1]: Leaving directory '/home/higon/glibc' > > > > ChangeLog: > > > > 2018-12-10 fanjinke <fanjinke@hygon.cn> > > > > * sysdeps/x86/cpu-features.c (init_cpu_features): > > --- > > sysdeps/x86/cpu-features.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c > > index 5f9eefd408..86e78bfb78 100644 > > --- a/sysdeps/x86/cpu-features.c > > +++ b/sysdeps/x86/cpu-features.c > > @@ -425,8 +425,9 @@ init_cpu_features (struct cpu_features > *cpu_features) > > cpu_features->feature[index_arch_Prefer_No_AVX512] > > |= bit_arch_Prefer_No_AVX512; > > } > > - /* This spells out "AuthenticAMD". */ > > - else if (ebx == 0x68747541 && ecx == 0x444d4163 && edx == > > 0x69746e65) > > + /* This spells out "AuthenticAMD" or "HygonGenuine". */ > > + else if ((ebx == 0x68747541 && ecx == 0x444d4163 && edx == > 0x69746e65) > > + || (ebx == 0x6f677948 && ecx == 0x656e6975 && edx == > 0x6e65476e)) > > { > > unsigned int extended_model; > > This looks fine to me, and reuses the AMD code. > > I'd like to hear from Amit if this is OK for him, since he'll have to maintain this > code as things diverge. > > Amit, Any objections? No objection from my side. > > Reviewed-by: Carlos O'Donell <carlos@redhat.com> > > -- > Cheers, > Carlos. Thanks, Amit Pawar
On 12/12/18 2:21 AM, Jinke Fan wrote: > Thank you for your reply and reminder. > > The copyright issue is already under processing. Jinke, Please review the attached patch. It is what I plan to commit for you. I notice you use 'fanjinke' as your ChangeLog name, is that correct? I added a 'Signed-off-by' for you in the commit message, is that OK? The only changes I made to your patch: * Finished the ChangeLog entry which was missing text after the identified function change. * Added space after '.' in comment in cpu-features.c (two spaces after period is GNU coding convention). If everything looks OK to you I will commit this for you.
On 12/12/2018 10:32 PM, Carlos O'Donell wrote: > On 12/12/18 2:21 AM, Jinke Fan wrote: >> Thank you for your reply and reminder. >> >> The copyright issue is already under processing. > > Jinke, > > Please review the attached patch. It is what I plan to commit for you. > > I notice you use 'fanjinke' as your ChangeLog name, is that correct? > > I added a 'Signed-off-by' for you in the commit message, is that OK? > > The only changes I made to your patch: > > * Finished the ChangeLog entry which was missing text after the > identified function change. > > * Added space after '.' in comment in cpu-features.c (two spaces after > period is GNU coding convention). > > If everything looks OK to you I will commit this for you. > Carlos, Yes, everything looks OK to me. Thank you very much!
On 12/12/18 10:28 PM, Jinke Fan wrote: > On 12/12/2018 10:32 PM, Carlos O'Donell wrote: >> On 12/12/18 2:21 AM, Jinke Fan wrote: >>> Thank you for your reply and reminder. >>> >>> The copyright issue is already under processing. >> Jinke, >> >> Please review the attached patch. It is what I plan to commit for you. >> >> I notice you use 'fanjinke' as your ChangeLog name, is that correct? >> >> I added a 'Signed-off-by' for you in the commit message, is that OK? >> >> The only changes I made to your patch: >> >> * Finished the ChangeLog entry which was missing text after the >> identified function change. >> >> * Added space after '.' in comment in cpu-features.c (two spaces after >> period is GNU coding convention). >> >> If everything looks OK to you I will commit this for you. >> > Carlos, > > Yes, everything looks OK to me. > > Thank you very much! It looks like you sent this message 7 times to the list. Please review your MUA settings, or your mail server settings.
On 12/12/18 10:28 PM, Jinke Fan wrote: > On 12/12/2018 10:32 PM, Carlos O'Donell wrote: >> On 12/12/18 2:21 AM, Jinke Fan wrote: >>> Thank you for your reply and reminder. >>> >>> The copyright issue is already under processing. >> Jinke, >> >> Please review the attached patch. It is what I plan to commit for you. >> >> I notice you use 'fanjinke' as your ChangeLog name, is that correct? >> >> I added a 'Signed-off-by' for you in the commit message, is that OK? >> >> The only changes I made to your patch: >> >> * Finished the ChangeLog entry which was missing text after the >> identified function change. >> >> * Added space after '.' in comment in cpu-features.c (two spaces after >> period is GNU coding convention). >> >> If everything looks OK to you I will commit this for you. >> > Carlos, > > Yes, everything looks OK to me. > > Thank you very much! > This is now pushed. I failed to set the commit author correctly, my apologies.
On 12/13/18 9:47 PM, Jinke Fan wrote: > On 12/14/2018 12:59 AM, Carlos O'Donell wrote: >> This is now pushed. >> >> I failed to set the commit author correctly, my apologies. >> > > It doesn't matter because it's "Signed-off-by" info. > > Thank you so much! My apologies again, I was distracted. I look forward to reviewing future patches from you. Please make sure you go through the FSF copyright assignment process such that we can make the reviews go smoothly :-)
On 12/14/2018 12:59 AM, Carlos O'Donell wrote: > On 12/12/18 10:28 PM, Jinke Fan wrote: >> On 12/12/2018 10:32 PM, Carlos O'Donell wrote: >>> On 12/12/18 2:21 AM, Jinke Fan wrote: >>>> Thank you for your reply and reminder. >>>> >>>> The copyright issue is already under processing. >>> Jinke, >>> >>> Please review the attached patch. It is what I plan to commit for you. >>> >>> I notice you use 'fanjinke' as your ChangeLog name, is that correct? >>> >>> I added a 'Signed-off-by' for you in the commit message, is that OK? >>> >>> The only changes I made to your patch: >>> >>> * Finished the ChangeLog entry which was missing text after the >>> identified function change. >>> >>> * Added space after '.' in comment in cpu-features.c (two spaces after >>> period is GNU coding convention). >>> >>> If everything looks OK to you I will commit this for you. >>> >> Carlos, >> >> Yes, everything looks OK to me. >> >> Thank you very much! >> > > This is now pushed. > > I failed to set the commit author correctly, my apologies. > It doesn't matter because it's "Signed-off-by" info. Thank you so much!
On 12/14/2018 11:16 AM, Carlos O'Donell wrote: > On 12/13/18 9:47 PM, Jinke Fan wrote: >> On 12/14/2018 12:59 AM, Carlos O'Donell wrote: >>> This is now pushed. >>> >>> I failed to set the commit author correctly, my apologies. >>> >> >> It doesn't matter because it's "Signed-off-by" info. >> >> Thank you so much! > > My apologies again, I was distracted. > > I look forward to reviewing future patches from you. > > Please make sure you go through the FSF copyright > assignment process such that we can make the reviews > go smoothly :-) > I will send the scanned copy of the copyright to ssign@gnu.org as soon as possible.
On 12/14/2018 11:41 AM, Jinke Fan wrote: > On 12/14/2018 11:16 AM, Carlos O'Donell wrote: >> On 12/13/18 9:47 PM, Jinke Fan wrote: >>> On 12/14/2018 12:59 AM, Carlos O'Donell wrote: >>>> This is now pushed. >>>> >>>> I failed to set the commit author correctly, my apologies. >>>> >>> >>> It doesn't matter because it's "Signed-off-by" info. >>> >>> Thank you so much! >> >> My apologies again, I was distracted. >> >> I look forward to reviewing future patches from you. >> >> Please make sure you go through the FSF copyright >> assignment process such that we can make the reviews >> go smoothly :-) >> > > I will send the scanned copy of the copyright to ssign@gnu.org as soon > as possible. > > The copyright signature has been sent to assign@gnu.org. Thank you for your reminder.
* Carlos O'Donell: > It looks like you sent this message 7 times to the list. > > Please review your MUA settings, or your mail server settings. I think this was a problem at your end. I doubt anyone else saw this duplication. 8-) It did not make it into the archives, either. Thanks, Florian
On 12/14/2018 3:46 PM, Florian Weimer wrote: > * Carlos O'Donell: > >> It looks like you sent this message 7 times to the list. >> >> Please review your MUA settings, or your mail server settings. > > I think this was a problem at your end. I doubt anyone else saw this > duplication. 8-) It did not make it into the archives, either. > > Thanks, > Florian > The resend was done manually when I received a failed send like this: " Hi. This is the qmail-send program at sourceware.org. I'm afraid I wasn't able to deliver your message to the following addresses. This is a permanent error; I've given up. Sorry it didn't work out. <libc-alpha@sourceware.org>: Invalid mime type "text/x-vcard" detected in message text or attachment. Please send plain text messages only. See http://sourceware.org/lists.html#sourceware-list-info for more information. ...... " It seems to be working normally now. Best Regards！
On Thu, Dec 13, 2018 at 11:45 PM Florian Weimer <fweimer@redhat.com> wrote: > > * Carlos O'Donell: > > > It looks like you sent this message 7 times to the list. > > > > Please review your MUA settings, or your mail server settings. > > I think this was a problem at your end. I doubt anyone else saw this > duplication. 8-) It did not make it into the archives, either. FWIW, I also got 7 copies :-).
diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c index 5f9eefd408..86e78bfb78 100644 --- a/sysdeps/x86/cpu-features.c +++ b/sysdeps/x86/cpu-features.c @@ -425,8 +425,9 @@ init_cpu_features (struct cpu_features *cpu_features) cpu_features->feature[index_arch_Prefer_No_AVX512] |= bit_arch_Prefer_No_AVX512; } - /* This spells out "AuthenticAMD". */ - else if (ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65) + /* This spells out "AuthenticAMD" or "HygonGenuine". */ + else if ((ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65) + || (ebx == 0x6f677948 && ecx == 0x656e6975 && edx == 0x6e65476e)) { unsigned int extended_model;
This patch fix Hygon Dhyana processor CPU Vendor ID detection problem in glibc sysdep module, current glibc codes doesn't recognize Dhyana CPU Vendor ID("HygonGenuine") and set kind to arch_kind_other, which result to incorrect zero value for __cache_sysconf() syscall. As Hygon Dhyana share most architecture feature as AMD Family 17h, this patch add Hygon CPU Vendor ID check and setup kind to arch_kind_amd and reuse AMD code path, which lead to correct return value in __cache_sysconf() syscall. we run the glibc test suite for both Hygon Dhyana and AMD EPYC and found no failure case. Background: Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture between AMD and Haiguang Information Technology Co.,Ltd., aims at providing high performance x86 processor for China server market. Its first generation processor codename is Dhyana, which originates from AMD technology and shares most of the architecture with AMD's family 17h, but with different CPU Vendor ID("HygonGenuine")/Family series number(Family 18h). Related Hygon kernel patch can be found on http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b. 1538583282.git.puwen@hygon.cn Very appreciate everyone who has helped review and fix issues. *Tested for Hygon:* Before patching the results of hygon's tests: Summary of test results: 6 FAIL 5927 PASS 29 UNSUPPORTED 17 XFAIL 2 XPASS Makefile:403: recipe for target 'tests' failed make[1]: *** [tests] Error 1 make[1]: Leaving directory '/home/higon/space/src/opensrc/glibc/glibc/glibc' Makefile:9: recipe for target 'check' failed make: *** [check] Error 2 And the result of testing after patching: Summary of test results: 5945 PASS 17 UNSUPPORTED 17 XFAIL 2 XPASS make[1]: Leaving directory '/home/higon/space/src/opensrc/glibc/glibc/glibc' *Tested for AMD:* The test results did not change before and after patching: Summary of test results: 5951 PASS 11 UNSUPPORTED 17 XFAIL 2 XPASS make[1]: Leaving directory '/home/higon/glibc' ChangeLog: 2018-12-10 fanjinke <fanjinke@hygon.cn> * sysdeps/x86/cpu-features.c (init_cpu_features): --- sysdeps/x86/cpu-features.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)