| Message ID | 20181204090457.15597-1-wens@csie.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11 | expand |
On Tue, Dec 04, 2018 at 05:04:57PM +0800, Chen-Yu Tsai wrote: > Pin PH11 is used on various A83T board to detect a change in the OTG > port's ID pin, as in when an OTG host cable is plugged in. > > The incorrect offset meant the gpiochip/irqchip was activating the wrong > pin for interrupts. > > Fixes: 4730f33f0d82 ("pinctrl: sunxi: add allwinner A83T PIO controller support") > Cc: <stable@vger.kernel.org> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> Maxime
On Tue, Dec 4, 2018 at 10:05 AM Chen-Yu Tsai <wens@csie.org> wrote: > Pin PH11 is used on various A83T board to detect a change in the OTG > port's ID pin, as in when an OTG host cable is plugged in. > > The incorrect offset meant the gpiochip/irqchip was activating the wrong > pin for interrupts. > > Fixes: 4730f33f0d82 ("pinctrl: sunxi: add allwinner A83T PIO controller support") > Cc: <stable@vger.kernel.org> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Patch applied for fixes with Maxime's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c index 6624499eae72..4ada80317a3b 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c @@ -568,7 +568,7 @@ static const struct sunxi_desc_pin sun8i_a83t_pins[] = { SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 11), SUNXI_FUNCTION(0x0, "gpio_in"), SUNXI_FUNCTION(0x1, "gpio_out"), - SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 1)), /* PH_EINT11 */ + SUNXI_FUNCTION_IRQ_BANK(0x6, 2, 11)), /* PH_EINT11 */ }; static const struct sunxi_pinctrl_desc sun8i_a83t_pinctrl_data = {
Pin PH11 is used on various A83T board to detect a change in the OTG port's ID pin, as in when an OTG host cable is plugged in. The incorrect offset meant the gpiochip/irqchip was activating the wrong pin for interrupts. Fixes: 4730f33f0d82 ("pinctrl: sunxi: add allwinner A83T PIO controller support") Cc: <stable@vger.kernel.org> Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- drivers/pinctrl/sunxi/pinctrl-sun8i-a83t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)