Message ID | 20181123181426.16116-1-richterphilipp.pops@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [1/2] package/libtorrent-rasterbar: new package | expand |
Hello, I'm really sorry that I only now get back to you, got distracted and forgot to send the revised patch series as promised. I followed your recommendations and comments and got rid of the all the unneeded options and switches. Style check passes and the tests too. Best Regards, Philipp Richter On Fri, 23 Nov 2018 at 19:14, Philipp Richter <richterphilipp.pops@gmail.com> wrote: > > libtorrent is a feature complete C++ bittorrent implementation > focusing on efficiency and scalability. > > https://www.libtorrent.org/ > > Signed-off-by: Philipp Richter <richterphilipp.pops@gmail.com> > --- > DEVELOPERS | 3 +++ > package/Config.in | 1 + > package/libtorrent-rasterbar/Config.in | 21 +++++++++++++++++ > .../libtorrent-rasterbar.hash | 3 +++ > .../libtorrent-rasterbar.mk | 23 +++++++++++++++++++ > 5 files changed, 51 insertions(+) > create mode 100644 package/libtorrent-rasterbar/Config.in > create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.hash > create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index 53467da489..e2bca31f7b 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -1698,6 +1698,9 @@ F: package/psplash/ > F: package/sispmctl/ > F: package/zsh/ > > +N: Philipp Richter <richterphilipp.pops@gmail.com> > +F: package/libtorrent-rasterbar/ > + > N: Philippe Proulx <eeppeliteloop@gmail.com> > F: package/lttng-babeltrace/ > F: package/lttng-libust/ > diff --git a/package/Config.in b/package/Config.in > index b60e7700ad..fb32ace8e7 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1550,6 +1550,7 @@ menu "Networking" > source "package/libstrophe/Config.in" > source "package/libtirpc/Config.in" > source "package/libtorrent/Config.in" > + source "package/libtorrent-rasterbar/Config.in" > source "package/libupnp/Config.in" > source "package/libupnp18/Config.in" > source "package/libupnpp/Config.in" > diff --git a/package/libtorrent-rasterbar/Config.in b/package/libtorrent-rasterbar/Config.in > new file mode 100644 > index 0000000000..30f7726d4a > --- /dev/null > +++ b/package/libtorrent-rasterbar/Config.in > @@ -0,0 +1,21 @@ > +comment "libtorrent-rasterbar needs a toolchain w/ C++, threads, wchar, gcc >= 4.8" > + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ > + !BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > + > +config BR2_PACKAGE_LIBTORRENT_RASTERBAR > + bool "libtorrent-rasterbar" > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_HOST_GCC_AT_LEAST_4_8 > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > + depends on BR2_TOOLCHAIN_HAS_THREADS > + depends on BR2_USE_WCHAR > + select BR2_PACKAGE_BOOST > + select BR2_PACKAGE_BOOST_CHRONO > + select BR2_PACKAGE_BOOST_SYSTEM > + select BR2_PACKAGE_BOOST_RANDOM > + select BR2_PACKAGE_OPENSSL > + help > + libtorrent is a feature complete C++ bittorrent implementation > + focusing on efficiency and scalability. > + > + https://www.libtorrent.org/ > diff --git a/package/libtorrent-rasterbar/libtorrent-rasterbar.hash b/package/libtorrent-rasterbar/libtorrent-rasterbar.hash > new file mode 100644 > index 0000000000..e38c0f4f1d > --- /dev/null > +++ b/package/libtorrent-rasterbar/libtorrent-rasterbar.hash > @@ -0,0 +1,3 @@ > +# Locally calculated > +sha256 7c23deba7fa279825642307587609d51c9935ac7606e0ef2f2d0ba10728b5847 libtorrent-rasterbar-1.1.11.tar.gz > +sha256 f3a5dd1558cce616b12edad521427ec8976ce2bb0af33f7f359cfa648bf55ad8 COPYING > diff --git a/package/libtorrent-rasterbar/libtorrent-rasterbar.mk b/package/libtorrent-rasterbar/libtorrent-rasterbar.mk > new file mode 100644 > index 0000000000..ee65cc5146 > --- /dev/null > +++ b/package/libtorrent-rasterbar/libtorrent-rasterbar.mk > @@ -0,0 +1,23 @@ > +################################################################################ > +# > +# libtorrent-rasterbar > +# > +################################################################################ > + > +LIBTORRENT_RASTERBAR_VERSION = 1.1.11 > +LIBTORRENT_RASTERBAR_SITE = https://github.com/arvidn/libtorrent/releases/download/libtorrent_$(subst .,_,$(LIBTORRENT_RASTERBAR_VERSION)) > +LIBTORRENT_RASTERBAR_LICENSE = BSD-2-Clause > +LIBTORRENT_RASTERBAR_LICENSE_FILES = COPYING > +LIBTORRENT_RASTERBAR_DEPENDENCIES = host-pkgconf boost openssl > +LIBTORRENT_RASTERBAR_INSTALL_STAGING = YES > +LIBTORRENT_RASTERBAR_CONF_OPTS += --with-boost-libdir=$(STAGING_DIR)/usr/lib --disable-invariant-checks > +LIBTORRENT_RASTERBAR_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" > + > +ifeq ($(BR2_ENABLE_LOCALE)$(BR2_PACKAGE_LIBICONV),y) > +LIBTORRENT_RASTERBAR_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv) > +LIBTORRENT_RASTERBAR_CONF_OPTS += --with-libiconv > +else > +LIBTORRENT_RASTERBAR_CONF_OPTS += --without-libiconv > +endif > + > +$(eval $(autotools-package)) > -- > 2.19.1 >
Hello, On Fri, 23 Nov 2018 19:14:25 +0100, Philipp Richter wrote: > libtorrent is a feature complete C++ bittorrent implementation > focusing on efficiency and scalability. > > https://www.libtorrent.org/ > > Signed-off-by: Philipp Richter <richterphilipp.pops@gmail.com> > --- > DEVELOPERS | 3 +++ > package/Config.in | 1 + > package/libtorrent-rasterbar/Config.in | 21 +++++++++++++++++ > .../libtorrent-rasterbar.hash | 3 +++ > .../libtorrent-rasterbar.mk | 23 +++++++++++++++++++ > 5 files changed, 51 insertions(+) > create mode 100644 package/libtorrent-rasterbar/Config.in > create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.hash > create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.mk Thanks, I've applied to next, with one significant change (and a few minor formatting fixes). See below. > +LIBTORRENT_RASTERBAR_VERSION = 1.1.11 > +LIBTORRENT_RASTERBAR_SITE = https://github.com/arvidn/libtorrent/releases/download/libtorrent_$(subst .,_,$(LIBTORRENT_RASTERBAR_VERSION)) > +LIBTORRENT_RASTERBAR_LICENSE = BSD-2-Clause The license text says BSD-3-Clause, not BSD-2-Clause, so I fixed that when applying. Thanks! Thomas
Hello, oh right my bad, thank you for correcting this. Best Regards, Philipp Richter On Sat, 1 Dec 2018 at 23:21, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Fri, 23 Nov 2018 19:14:25 +0100, Philipp Richter wrote: > > libtorrent is a feature complete C++ bittorrent implementation > > focusing on efficiency and scalability. > > > > https://www.libtorrent.org/ > > > > Signed-off-by: Philipp Richter <richterphilipp.pops@gmail.com> > > --- > > DEVELOPERS | 3 +++ > > package/Config.in | 1 + > > package/libtorrent-rasterbar/Config.in | 21 +++++++++++++++++ > > .../libtorrent-rasterbar.hash | 3 +++ > > .../libtorrent-rasterbar.mk | 23 +++++++++++++++++++ > > 5 files changed, 51 insertions(+) > > create mode 100644 package/libtorrent-rasterbar/Config.in > > create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.hash > > create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.mk > > Thanks, I've applied to next, with one significant change (and a few > minor formatting fixes). See below. > > > > +LIBTORRENT_RASTERBAR_VERSION = 1.1.11 > > +LIBTORRENT_RASTERBAR_SITE = https://github.com/arvidn/libtorrent/releases/download/libtorrent_$(subst .,_,$(LIBTORRENT_RASTERBAR_VERSION)) > > +LIBTORRENT_RASTERBAR_LICENSE = BSD-2-Clause > > The license text says BSD-3-Clause, not BSD-2-Clause, so I fixed that > when applying. > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/DEVELOPERS b/DEVELOPERS index 53467da489..e2bca31f7b 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1698,6 +1698,9 @@ F: package/psplash/ F: package/sispmctl/ F: package/zsh/ +N: Philipp Richter <richterphilipp.pops@gmail.com> +F: package/libtorrent-rasterbar/ + N: Philippe Proulx <eeppeliteloop@gmail.com> F: package/lttng-babeltrace/ F: package/lttng-libust/ diff --git a/package/Config.in b/package/Config.in index b60e7700ad..fb32ace8e7 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1550,6 +1550,7 @@ menu "Networking" source "package/libstrophe/Config.in" source "package/libtirpc/Config.in" source "package/libtorrent/Config.in" + source "package/libtorrent-rasterbar/Config.in" source "package/libupnp/Config.in" source "package/libupnp18/Config.in" source "package/libupnpp/Config.in" diff --git a/package/libtorrent-rasterbar/Config.in b/package/libtorrent-rasterbar/Config.in new file mode 100644 index 0000000000..30f7726d4a --- /dev/null +++ b/package/libtorrent-rasterbar/Config.in @@ -0,0 +1,21 @@ +comment "libtorrent-rasterbar needs a toolchain w/ C++, threads, wchar, gcc >= 4.8" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ + !BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + +config BR2_PACKAGE_LIBTORRENT_RASTERBAR + bool "libtorrent-rasterbar" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_HOST_GCC_AT_LEAST_4_8 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_WCHAR + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_CHRONO + select BR2_PACKAGE_BOOST_SYSTEM + select BR2_PACKAGE_BOOST_RANDOM + select BR2_PACKAGE_OPENSSL + help + libtorrent is a feature complete C++ bittorrent implementation + focusing on efficiency and scalability. + + https://www.libtorrent.org/ diff --git a/package/libtorrent-rasterbar/libtorrent-rasterbar.hash b/package/libtorrent-rasterbar/libtorrent-rasterbar.hash new file mode 100644 index 0000000000..e38c0f4f1d --- /dev/null +++ b/package/libtorrent-rasterbar/libtorrent-rasterbar.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 7c23deba7fa279825642307587609d51c9935ac7606e0ef2f2d0ba10728b5847 libtorrent-rasterbar-1.1.11.tar.gz +sha256 f3a5dd1558cce616b12edad521427ec8976ce2bb0af33f7f359cfa648bf55ad8 COPYING diff --git a/package/libtorrent-rasterbar/libtorrent-rasterbar.mk b/package/libtorrent-rasterbar/libtorrent-rasterbar.mk new file mode 100644 index 0000000000..ee65cc5146 --- /dev/null +++ b/package/libtorrent-rasterbar/libtorrent-rasterbar.mk @@ -0,0 +1,23 @@ +################################################################################ +# +# libtorrent-rasterbar +# +################################################################################ + +LIBTORRENT_RASTERBAR_VERSION = 1.1.11 +LIBTORRENT_RASTERBAR_SITE = https://github.com/arvidn/libtorrent/releases/download/libtorrent_$(subst .,_,$(LIBTORRENT_RASTERBAR_VERSION)) +LIBTORRENT_RASTERBAR_LICENSE = BSD-2-Clause +LIBTORRENT_RASTERBAR_LICENSE_FILES = COPYING +LIBTORRENT_RASTERBAR_DEPENDENCIES = host-pkgconf boost openssl +LIBTORRENT_RASTERBAR_INSTALL_STAGING = YES +LIBTORRENT_RASTERBAR_CONF_OPTS += --with-boost-libdir=$(STAGING_DIR)/usr/lib --disable-invariant-checks +LIBTORRENT_RASTERBAR_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" + +ifeq ($(BR2_ENABLE_LOCALE)$(BR2_PACKAGE_LIBICONV),y) +LIBTORRENT_RASTERBAR_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv) +LIBTORRENT_RASTERBAR_CONF_OPTS += --with-libiconv +else +LIBTORRENT_RASTERBAR_CONF_OPTS += --without-libiconv +endif + +$(eval $(autotools-package))
libtorrent is a feature complete C++ bittorrent implementation focusing on efficiency and scalability. https://www.libtorrent.org/ Signed-off-by: Philipp Richter <richterphilipp.pops@gmail.com> --- DEVELOPERS | 3 +++ package/Config.in | 1 + package/libtorrent-rasterbar/Config.in | 21 +++++++++++++++++ .../libtorrent-rasterbar.hash | 3 +++ .../libtorrent-rasterbar.mk | 23 +++++++++++++++++++ 5 files changed, 51 insertions(+) create mode 100644 package/libtorrent-rasterbar/Config.in create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.hash create mode 100644 package/libtorrent-rasterbar/libtorrent-rasterbar.mk