| Message ID | 20181125201729.19836-1-otavio@ossystems.com.br |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND | expand |
Hi Otavio, On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote: > > The setting is removed when running a `savedefconfig` using the > current setting set. It is being applied in preparation to some "setting set" is a bit confusing. > patches making changes to this defconfig. It would be good to mention that CONFIG_ARM_UNWIND is still selected automatically. Otherwise it may give the impression that such functionality is being removed. You could reword the commit log to something like this: CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is still selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. With the reworded commit log: Reviewed-by: Fabio Estevam <festevam@gmail.com>
Hello Fabio, On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam <festevam@gmail.com> wrote: > On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <otavio@ossystems.com.br> wrote: > > > > The setting is removed when running a `savedefconfig` using the > > current setting set. It is being applied in preparation to some > > "setting set" is a bit confusing. > > > patches making changes to this defconfig. > > It would be good to mention that CONFIG_ARM_UNWIND is still selected > automatically. > > Otherwise it may give the impression that such functionality is being removed. > > You could reword the commit log to something like this: > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is > still selected by the Kconfig logic. > This is done in preparation to making further changes to this defconfig cleaner. In fact, was removed and now selected. I changed the commit log as: ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. Do you agree?
Hi Otavio, On Sun, Nov 25, 2018 at 6:49 PM Otavio Salvador <otavio.salvador@ossystems.com.br> wrote: > In fact, was removed and now selected. Yes, correct. In 4.20-rc1 this option is automatically selected. > I changed the commit log as: > > ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but > selected by the Kconfig logic. This is done in preparation to making > further changes to this defconfig cleaner. > > Do you agree? Looks good to me, thanks.
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index aa02d18f44d1..0c887a059df3 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y CONFIG_PROVE_LOCKING=y # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_FTRACE is not set -# CONFIG_ARM_UNWIND is not set
The setting is removed when running a `savedefconfig` using the current setting set. It is being applied in preparation to some patches making changes to this defconfig. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> --- arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-)