diff mbox series

[V3,2/3] dt-bindings: mmc: sdhci-msm: Add entries for passing load values

Message ID 1539004739-32060-3-git-send-email-vbadigan@codeaurora.org
State Changes Requested, archived
Headers show
Series None | expand

Commit Message

Veerabhadrarao Badiganti Oct. 8, 2018, 1:18 p.m. UTC 
From: Vijay Viswanath <vviswana@codeaurora.org>

The load a particular sdhc controller should request from a regulator
is device specific and hence each device should individually vote for
the required load.

Signed-off-by: Vijay Viswanath <vviswana@codeaurora.org>
Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Rob Herring (Arm) Oct. 12, 2018, 2:55 p.m. UTC | #1 
On Mon, Oct 08, 2018 at 06:48:58PM +0530, Veerabhadrarao Badiganti wrote:
> From: Vijay Viswanath <vviswana@codeaurora.org>
> 
> The load a particular sdhc controller should request from a regulator
> is device specific and hence each device should individually vote for
> the required load.
> 
> Signed-off-by: Vijay Viswanath <vviswana@codeaurora.org>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 502b3b8..cb22178 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -25,6 +25,10 @@ Required properties:
>  	"xo"	- TCXO clock (optional)
>  	"cal"	- reference clock for RCLK delay calibration (optional)
>  	"sleep"	- sleep clock for RCLK delay calibration (optional)
> +- qcom,<supply>-current-level-microamp - specifies load levels for supply during BUS_ON and
> +					BUS_OFF states in power irq. Should be specified in
> +					pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively.
> +					Units uA.

Seems like something that should be common?
Veerabhadrarao Badiganti Nov. 8, 2018, 2:13 p.m. UTC | #2 
On 10/12/2018 8:25 PM, Rob Herring wrote:
> On Mon, Oct 08, 2018 at 06:48:58PM +0530, Veerabhadrarao Badiganti wrote:
>> From: Vijay Viswanath <vviswana@codeaurora.org>
>>
>> The load a particular sdhc controller should request from a regulator
>> is device specific and hence each device should individually vote for
>> the required load.
>>
>> Signed-off-by: Vijay Viswanath <vviswana@codeaurora.org>
>> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
>> ---
>>   Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> index 502b3b8..cb22178 100644
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
>> @@ -25,6 +25,10 @@ Required properties:
>>   	"xo"	- TCXO clock (optional)
>>   	"cal"	- reference clock for RCLK delay calibration (optional)
>>   	"sleep"	- sleep clock for RCLK delay calibration (optional)
>> +- qcom,<supply>-current-level-microamp - specifies load levels for supply during BUS_ON and
>> +					BUS_OFF states in power irq. Should be specified in
>> +					pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively.
>> +					Units uA.
> Seems like something that should be common?

Hi Rob,
Can you please little elaborate your comment?
Do mean this should be common for all vendors, not specific to qcom-mmc?


Thanks,
Veera
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
index 502b3b8..cb22178 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
@@ -25,6 +25,10 @@  Required properties:
 	"xo"	- TCXO clock (optional)
 	"cal"	- reference clock for RCLK delay calibration (optional)
 	"sleep"	- sleep clock for RCLK delay calibration (optional)
+- qcom,<supply>-current-level-microamp - specifies load levels for supply during BUS_ON and
+					BUS_OFF states in power irq. Should be specified in
+					pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively.
+					Units uA.
 
 Example:
 
@@ -36,7 +40,9 @@  Example:
 		non-removable;
 
 		vmmc-supply = <&pm8941_l20>;
+		qcom,vmmc-current-level-microamp = <200 570000>;
 		vqmmc-supply = <&pm8941_s3>;
+		qcom,vqmmc-current-level-microamp = <200 325000>;
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&sdc1_clk &sdc1_cmd &sdc1_data>;
@@ -53,7 +59,9 @@  Example:
 		cd-gpios = <&msmgpio 62 0x1>;
 
 		vmmc-supply = <&pm8941_l21>;
+		qcom,vmmc-current-level-microamp = <200 800000>;
 		vqmmc-supply = <&pm8941_l13>;
+		qcom,vqmmc-current-level-microamp = <200 22000>;
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&sdc2_clk &sdc2_cmd &sdc2_data>;