diff mbox series

[SRU,C/D/Unstable,1/1] USB: quirks: Add no-lpm quirk for Raydium touchscreens

Message ID 20181108074849.29070-3-kai.heng.feng@canonical.com
State New
Headers show
Series [SRU,C/D/Unstable,1/1] USB: quirks: Add no-lpm quirk for Raydium touchscreens | expand

Commit Message

Kai-Heng Feng Nov. 8, 2018, 7:48 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1802248

Raydium USB touchscreen fails to set config if LPM is enabled:
[    2.030658] usb 1-8: New USB device found, idVendor=2386, idProduct=3119
[    2.030659] usb 1-8: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[    2.030660] usb 1-8: Product: Raydium Touch System
[    2.030661] usb 1-8: Manufacturer: Raydium Corporation
[    7.132209] usb 1-8: can't set config #1, error -110

Same behavior can be observed on 2386:3114.

Raydium claims the touchscreen supports LPM under Windows, so I used
Microsoft USB Test Tools (MUTT) [1] to check its LPM status. MUTT shows
that the LPM doesn't work under Windows, either. So let's just disable LPM
for Raydium touchscreens.

[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/usb-test-tools

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit deefd24228a172d1b27d4a9adbfd2cdacd60ae64 linux-next)
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/usb/core/quirks.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thadeu Lima de Souza Cascardo Nov. 8, 2018, 12:22 p.m. UTC | #1
Applied to unstable master branch.

Thanks.
Cascardo.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Applied-to: unstable/master
Kleber Sacilotto de Souza Jan. 10, 2019, 10:51 a.m. UTC | #2
On 11/8/18 8:48 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1802248
>
> Raydium USB touchscreen fails to set config if LPM is enabled:
> [    2.030658] usb 1-8: New USB device found, idVendor=2386, idProduct=3119
> [    2.030659] usb 1-8: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> [    2.030660] usb 1-8: Product: Raydium Touch System
> [    2.030661] usb 1-8: Manufacturer: Raydium Corporation
> [    7.132209] usb 1-8: can't set config #1, error -110
>
> Same behavior can be observed on 2386:3114.
>
> Raydium claims the touchscreen supports LPM under Windows, so I used
> Microsoft USB Test Tools (MUTT) [1] to check its LPM status. MUTT shows
> that the LPM doesn't work under Windows, either. So let's just disable LPM
> for Raydium touchscreens.
>
> [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/usb-test-tools
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit deefd24228a172d1b27d4a9adbfd2cdacd60ae64 linux-next)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/usb/core/quirks.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 178d6c6063c0..99f525ac4b2e 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -411,6 +411,11 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	{ USB_DEVICE(0x2040, 0x7200), .driver_info =
>  			USB_QUIRK_CONFIG_INTF_STRINGS },
>  
> +	/* Raydium Touchscreen */
> +	{ USB_DEVICE(0x2386, 0x3114), .driver_info = USB_QUIRK_NO_LPM },
> +
> +	{ USB_DEVICE(0x2386, 0x3119), .driver_info = USB_QUIRK_NO_LPM },
> +
>  	/* DJI CineSSD */
>  	{ USB_DEVICE(0x2ca3, 0x0031), .driver_info = USB_QUIRK_NO_LPM },
>  

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>


Also applied to cosmic/master-next branch, removing the "linux-next"
part from the provenance.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 178d6c6063c0..99f525ac4b2e 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -411,6 +411,11 @@  static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x2040, 0x7200), .driver_info =
 			USB_QUIRK_CONFIG_INTF_STRINGS },
 
+	/* Raydium Touchscreen */
+	{ USB_DEVICE(0x2386, 0x3114), .driver_info = USB_QUIRK_NO_LPM },
+
+	{ USB_DEVICE(0x2386, 0x3119), .driver_info = USB_QUIRK_NO_LPM },
+
 	/* DJI CineSSD */
 	{ USB_DEVICE(0x2ca3, 0x0031), .driver_info = USB_QUIRK_NO_LPM },