| Message ID | 20181029044645.23322-1-sriharsha.basavapatna@broadcom.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | [ovs-dev] dpif: Restore a few lines with form feed characters | expand |
Bleep bloop. Greetings Sriharsha Basavapatna via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Sriharsha Basavapatna via dev <ovs-dev@openvswitch.org> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Lines checked: 60, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@bytheb.org Thanks, 0-day Robot
On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote: > A few lines with form feed characters (ASCII: ^L) were accidentally > deleted by a recent commit to support rebalancing of offloaded flows. > This patch reverts those lines. > > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Thanks for the patch. In the email headers, your name and email address show up as: From: Sriharsha Basavapatna via dev <ovs-dev@openvswitch.org> When this gets fed into Git, it ends up with "ovs-dev@openvswitch.org" credited with the patch, as well as "via dev" at the end of the name. That's not good. Can you send the patch from a "From" address that is appropriate for the commit? Thanks, Ben.
On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff <blp@ovn.org> wrote: > > On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote: > > A few lines with form feed characters (ASCII: ^L) were accidentally > > deleted by a recent commit to support rebalancing of offloaded flows. > > This patch reverts those lines. > > > > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") > > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > > Thanks for the patch. > > In the email headers, your name and email address show up as: > From: Sriharsha Basavapatna via dev <ovs-dev@openvswitch.org> > > When this gets fed into Git, it ends up with "ovs-dev@openvswitch.org" > credited with the patch, as well as "via dev" at the end of the name. > That's not good. Can you send the patch from a "From" address that is > appropriate for the commit? > > Thanks, > > Ben. Hi Ben, I'd reported this problem to Aaron sometime back and the the email thread is below; seems like some issues with patchwork. Thanks, -Harsha > On Thu, Sep 13, 2018 at 7:50 PM, Aaron Conole <aconole@bytheb.org> wrote: >> Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> writes: >> >>> Hi, >>> >>> I got this error below from 0-day robot. The patch contains my >>> sign-off, so I'm not sure what the issue is here. Please take a look >>> and let me know. >> >> Thanks for the report! > > Thanks for your response. > >> >> I think what happened was you sent to ovs-dev@openvswitch.org and that >> bounced the message to dev@openvswitch.org > > No; I just checked the git command that I issued; I did send it to > dev@openvswitch.org: > > # git send-email --to dev@openvswitch.org *.patch Okay - looking a bit closer, the mailing list has everything correct, but patchwork lists your mail coming via some kind of bounce. I'm lost at this point - I don't know how the mail gets routed from the list to PW. But it doesn't look like you've done anything incorrectly.
On Wed, Oct 31, 2018 at 09:01:59AM +0530, Sriharsha Basavapatna wrote: > On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff <blp@ovn.org> wrote: > > > > On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote: > > > A few lines with form feed characters (ASCII: ^L) were accidentally > > > deleted by a recent commit to support rebalancing of offloaded flows. > > > This patch reverts those lines. > > > > > > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") > > > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > > > > Thanks for the patch. > > > > In the email headers, your name and email address show up as: > > From: Sriharsha Basavapatna via dev <ovs-dev@openvswitch.org> > > > > When this gets fed into Git, it ends up with "ovs-dev@openvswitch.org" > > credited with the patch, as well as "via dev" at the end of the name. > > That's not good. Can you send the patch from a "From" address that is > > appropriate for the commit? > > > > Thanks, > > > > Ben. > > Hi Ben, > > I'd reported this problem to Aaron sometime back and the the email > thread is below; seems like some issues with patchwork. I didn't get the patch from patchwork but directly from the mailing list, so it's not a problem with patchwork. (You'll notice that when I quoted your email, the leader said "Sriharsha Basavapatna via dev wrote". That's because it's literally the From: line of the email that I replied to.)
On Wed, Oct 31, 2018 at 10:02 AM Ben Pfaff <blp@ovn.org> wrote: > > On Wed, Oct 31, 2018 at 09:01:59AM +0530, Sriharsha Basavapatna wrote: > > On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff <blp@ovn.org> wrote: > > > > > > On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote: > > > > A few lines with form feed characters (ASCII: ^L) were accidentally > > > > deleted by a recent commit to support rebalancing of offloaded flows. > > > > This patch reverts those lines. > > > > > > > > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") > > > > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > > > > > > Thanks for the patch. > > > > > > In the email headers, your name and email address show up as: > > > From: Sriharsha Basavapatna via dev <ovs-dev@openvswitch.org> > > > > > > When this gets fed into Git, it ends up with "ovs-dev@openvswitch.org" > > > credited with the patch, as well as "via dev" at the end of the name. > > > That's not good. Can you send the patch from a "From" address that is > > > appropriate for the commit? > > > > > > Thanks, > > > > > > Ben. > > > > Hi Ben, > > > > I'd reported this problem to Aaron sometime back and the the email > > thread is below; seems like some issues with patchwork. > > I didn't get the patch from patchwork but directly from the mailing > list, so it's not a problem with patchwork. > > (You'll notice that when I quoted your email, the leader said "Sriharsha > Basavapatna via dev wrote". That's because it's literally the From: > line of the email that I replied to.) Hi Ben, Not sure how "via dev ..." is getting added. Do you want me to explicitly specify "from: " to git send-email on the command line ? Let me know if there's anything else you can think of. Thanks, -Harsha
On Wed, Oct 31, 2018 at 04:56:07PM +0530, Sriharsha Basavapatna wrote: > On Wed, Oct 31, 2018 at 10:02 AM Ben Pfaff <blp@ovn.org> wrote: > > > > On Wed, Oct 31, 2018 at 09:01:59AM +0530, Sriharsha Basavapatna wrote: > > > On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff <blp@ovn.org> wrote: > > > > > > > > On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote: > > > > > A few lines with form feed characters (ASCII: ^L) were accidentally > > > > > deleted by a recent commit to support rebalancing of offloaded flows. > > > > > This patch reverts those lines. > > > > > > > > > > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") > > > > > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > > > > > > > > Thanks for the patch. > > > > > > > > In the email headers, your name and email address show up as: > > > > From: Sriharsha Basavapatna via dev <ovs-dev@openvswitch.org> > > > > > > > > When this gets fed into Git, it ends up with "ovs-dev@openvswitch.org" > > > > credited with the patch, as well as "via dev" at the end of the name. > > > > That's not good. Can you send the patch from a "From" address that is > > > > appropriate for the commit? > > > > > > > > Thanks, > > > > > > > > Ben. > > > > > > Hi Ben, > > > > > > I'd reported this problem to Aaron sometime back and the the email > > > thread is below; seems like some issues with patchwork. > > > > I didn't get the patch from patchwork but directly from the mailing > > list, so it's not a problem with patchwork. > > > > (You'll notice that when I quoted your email, the leader said "Sriharsha > > Basavapatna via dev wrote". That's because it's literally the From: > > line of the email that I replied to.) > > Hi Ben, > > Not sure how "via dev ..." is getting added. Do you want me to > explicitly specify "from: " to git send-email on the command line ? > Let me know if there's anything else you can think of. Try it.
diff --git a/lib/dpif.c b/lib/dpif.c index 7f981328e..59aa1dc7c 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -1661,7 +1661,7 @@ dpif_queue_to_priority(const struct dpif *dpif, uint32_t queue_id, log_operation(dpif, "queue_to_priority", error); return error; } - + void dpif_init(struct dpif *dpif, const struct dpif_class *dpif_class, const char *name, diff --git a/lib/dpif.h b/lib/dpif.h index 0df856d4f..475d5a674 100644 --- a/lib/dpif.h +++ b/lib/dpif.h @@ -769,7 +769,7 @@ struct dpif_op { void dpif_operate(struct dpif *, struct dpif_op **ops, size_t n_ops, enum dpif_offload_type); - + /* Upcalls. */ enum dpif_upcall_type { diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 28172cb05..e36cfa0ee 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -1010,7 +1010,7 @@ udpif_revalidator(void *arg) return NULL; } - + static enum upcall_type classify_upcall(enum dpif_upcall_type type, const struct nlattr *userdata, struct user_action_cookie *cookie)
A few lines with form feed characters (ASCII: ^L) were accidentally deleted by a recent commit to support rebalancing of offloaded flows. This patch reverts those lines. Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> --- lib/dpif.c | 2 +- lib/dpif.h | 2 +- ofproto/ofproto-dpif-upcall.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)