| Message ID | 20181005153638.1886-6-digetx@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Continuing the work on coupled regulators | expand |
On Fri, Oct 05, 2018 at 06:36:32PM +0300, Dmitry Osipenko wrote: > Redefine binding for regulator-coupled-max-spread property in a way that > max-spread values are defined per regulator couple instead of defining > single max-spread for the whole group of coupled regulators. > > With that change the following regulators coupling configuration will be > possible: > > regA: regulatorA { > regulator-coupled-with = <®B ®C>; > regulator-coupled-max-spread = <100000 300000>; > }; > > regB: regulatorB { > regulator-coupled-with = <®A ®C>; > regulator-coupled-max-spread = <100000 200000>; > }; > > regC: regulatorC { > regulator-coupled-with = <®A ®B>; > regulator-coupled-max-spread = <300000 200000>; > }; > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index a7cd36877bfe..9b525b657fca 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -76,8 +76,9 @@ Optional properties: > - regulator-coupled-with: Regulators with which the regulator > is coupled. The linkage is 2-way - all coupled regulators should be linked > with each other. A regulator should not be coupled with its supplier. > -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators > - in microvolts. > +- regulator-coupled-max-spread: Array of maximum spread between voltages of > + coupled regulators in microvolts, each value in the array relates to the > + corresponding couple specified by the regulator-coupled-with property. Is this in use already? How is a single entry handled? Rob
On Fri, 5 Oct 2018 18:36:32 +0300, Dmitry Osipenko wrote: > Redefine binding for regulator-coupled-max-spread property in a way that > max-spread values are defined per regulator couple instead of defining > single max-spread for the whole group of coupled regulators. > > With that change the following regulators coupling configuration will be > possible: > > regA: regulatorA { > regulator-coupled-with = <®B ®C>; > regulator-coupled-max-spread = <100000 300000>; > }; > > regB: regulatorB { > regulator-coupled-with = <®A ®C>; > regulator-coupled-max-spread = <100000 200000>; > }; > > regC: regulatorC { > regulator-coupled-with = <®A ®B>; > regulator-coupled-max-spread = <300000 200000>; > }; > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Oct 17, 2018 at 8:27 AM Rob Herring <robh@kernel.org> wrote: > > On Fri, 5 Oct 2018 18:36:32 +0300, Dmitry Osipenko wrote: > > Redefine binding for regulator-coupled-max-spread property in a way that > > max-spread values are defined per regulator couple instead of defining > > single max-spread for the whole group of coupled regulators. > > > > With that change the following regulators coupling configuration will be > > possible: > > > > regA: regulatorA { > > regulator-coupled-with = <®B ®C>; > > regulator-coupled-max-spread = <100000 300000>; > > }; > > > > regB: regulatorB { > > regulator-coupled-with = <®A ®C>; > > regulator-coupled-max-spread = <100000 200000>; > > }; > > > > regC: regulatorC { > > regulator-coupled-with = <®A ®B>; > > regulator-coupled-max-spread = <300000 200000>; > > }; > > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Sent this by mistake. Disregard as I have questions. Rob
On 10/17/18 4:25 PM, Rob Herring wrote: > On Fri, Oct 05, 2018 at 06:36:32PM +0300, Dmitry Osipenko wrote: >> Redefine binding for regulator-coupled-max-spread property in a way that >> max-spread values are defined per regulator couple instead of defining >> single max-spread for the whole group of coupled regulators. >> >> With that change the following regulators coupling configuration will be >> possible: >> >> regA: regulatorA { >> regulator-coupled-with = <®B ®C>; >> regulator-coupled-max-spread = <100000 300000>; >> }; >> >> regB: regulatorB { >> regulator-coupled-with = <®A ®C>; >> regulator-coupled-max-spread = <100000 200000>; >> }; >> >> regC: regulatorC { >> regulator-coupled-with = <®A ®B>; >> regulator-coupled-max-spread = <300000 200000>; >> }; >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt >> index a7cd36877bfe..9b525b657fca 100644 >> --- a/Documentation/devicetree/bindings/regulator/regulator.txt >> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt >> @@ -76,8 +76,9 @@ Optional properties: >> - regulator-coupled-with: Regulators with which the regulator >> is coupled. The linkage is 2-way - all coupled regulators should be linked >> with each other. A regulator should not be coupled with its supplier. >> -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators >> - in microvolts. >> +- regulator-coupled-max-spread: Array of maximum spread between voltages of >> + coupled regulators in microvolts, each value in the array relates to the >> + corresponding couple specified by the regulator-coupled-with property. > > Is this in use already? How is a single entry handled? No, it is not in use yet. Only some of the prerequisite patches were applied. Initially single entry was supposed to be re-used by all of regulator couples. Now single entry describes a single couple only.
On Wed, Oct 17, 2018 at 8:32 AM Dmitry Osipenko <digetx@gmail.com> wrote: > > On 10/17/18 4:25 PM, Rob Herring wrote: > > On Fri, Oct 05, 2018 at 06:36:32PM +0300, Dmitry Osipenko wrote: > >> Redefine binding for regulator-coupled-max-spread property in a way that > >> max-spread values are defined per regulator couple instead of defining > >> single max-spread for the whole group of coupled regulators. > >> > >> With that change the following regulators coupling configuration will be > >> possible: > >> > >> regA: regulatorA { > >> regulator-coupled-with = <®B ®C>; > >> regulator-coupled-max-spread = <100000 300000>; > >> }; > >> > >> regB: regulatorB { > >> regulator-coupled-with = <®A ®C>; > >> regulator-coupled-max-spread = <100000 200000>; > >> }; > >> > >> regC: regulatorC { > >> regulator-coupled-with = <®A ®B>; > >> regulator-coupled-max-spread = <300000 200000>; > >> }; > >> > >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > >> --- > >> Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > >> index a7cd36877bfe..9b525b657fca 100644 > >> --- a/Documentation/devicetree/bindings/regulator/regulator.txt > >> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > >> @@ -76,8 +76,9 @@ Optional properties: > >> - regulator-coupled-with: Regulators with which the regulator > >> is coupled. The linkage is 2-way - all coupled regulators should be linked > >> with each other. A regulator should not be coupled with its supplier. > >> -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators > >> - in microvolts. > >> +- regulator-coupled-max-spread: Array of maximum spread between voltages of > >> + coupled regulators in microvolts, each value in the array relates to the > >> + corresponding couple specified by the regulator-coupled-with property. > > > > Is this in use already? How is a single entry handled? > > No, it is not in use yet. Only some of the prerequisite patches were applied. Please make that clear in the commit message.
On 10/17/18 4:33 PM, Rob Herring wrote: > On Wed, Oct 17, 2018 at 8:32 AM Dmitry Osipenko <digetx@gmail.com> wrote: >> >> On 10/17/18 4:25 PM, Rob Herring wrote: >>> On Fri, Oct 05, 2018 at 06:36:32PM +0300, Dmitry Osipenko wrote: >>>> Redefine binding for regulator-coupled-max-spread property in a way that >>>> max-spread values are defined per regulator couple instead of defining >>>> single max-spread for the whole group of coupled regulators. >>>> >>>> With that change the following regulators coupling configuration will be >>>> possible: >>>> >>>> regA: regulatorA { >>>> regulator-coupled-with = <®B ®C>; >>>> regulator-coupled-max-spread = <100000 300000>; >>>> }; >>>> >>>> regB: regulatorB { >>>> regulator-coupled-with = <®A ®C>; >>>> regulator-coupled-max-spread = <100000 200000>; >>>> }; >>>> >>>> regC: regulatorC { >>>> regulator-coupled-with = <®A ®B>; >>>> regulator-coupled-max-spread = <300000 200000>; >>>> }; >>>> >>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >>>> --- >>>> Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- >>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt >>>> index a7cd36877bfe..9b525b657fca 100644 >>>> --- a/Documentation/devicetree/bindings/regulator/regulator.txt >>>> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt >>>> @@ -76,8 +76,9 @@ Optional properties: >>>> - regulator-coupled-with: Regulators with which the regulator >>>> is coupled. The linkage is 2-way - all coupled regulators should be linked >>>> with each other. A regulator should not be coupled with its supplier. >>>> -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators >>>> - in microvolts. >>>> +- regulator-coupled-max-spread: Array of maximum spread between voltages of >>>> + coupled regulators in microvolts, each value in the array relates to the >>>> + corresponding couple specified by the regulator-coupled-with property. >>> >>> Is this in use already? How is a single entry handled? >> >> No, it is not in use yet. Only some of the prerequisite patches were applied. > > Please make that clear in the commit message. Okay.
diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt index a7cd36877bfe..9b525b657fca 100644 --- a/Documentation/devicetree/bindings/regulator/regulator.txt +++ b/Documentation/devicetree/bindings/regulator/regulator.txt @@ -76,8 +76,9 @@ Optional properties: - regulator-coupled-with: Regulators with which the regulator is coupled. The linkage is 2-way - all coupled regulators should be linked with each other. A regulator should not be coupled with its supplier. -- regulator-coupled-max-spread: Max spread between voltages of coupled regulators - in microvolts. +- regulator-coupled-max-spread: Array of maximum spread between voltages of + coupled regulators in microvolts, each value in the array relates to the + corresponding couple specified by the regulator-coupled-with property. Deprecated properties: - regulator-compatible: If a regulator chip contains multiple
Redefine binding for regulator-coupled-max-spread property in a way that max-spread values are defined per regulator couple instead of defining single max-spread for the whole group of coupled regulators. With that change the following regulators coupling configuration will be possible: regA: regulatorA { regulator-coupled-with = <®B ®C>; regulator-coupled-max-spread = <100000 300000>; }; regB: regulatorB { regulator-coupled-with = <®A ®C>; regulator-coupled-max-spread = <100000 200000>; }; regC: regulatorC { regulator-coupled-with = <®A ®B>; regulator-coupled-max-spread = <300000 200000>; }; Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- Documentation/devicetree/bindings/regulator/regulator.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)