| Message ID | 20181006153642.10376-1-robimarko@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: spinand: winbond: Add support for W25N01GV | expand |
+Miquel Hi Robert, Please Cc the NAND mantainers when you send a NAND related patch (in case you don't know about it already, scripts/get_maintainer.pl should help you find who to Cc). On Sat, 6 Oct 2018 17:36:42 +0200 Robert Marko <robimarko@gmail.com> wrote: > W25N01GV is a single die version of the already supported > W25M02GV with half the capacity. Everything else is the > same so introduce support for W25N01GV. > > Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf > > Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5. > > Signed-off-by: Robert Marko <robimarko@gmail.com> Looks good. Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > drivers/mtd/nand/spi/winbond.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > --- a/drivers/mtd/nand/spi/winbond.c > +++ b/drivers/mtd/nand/spi/winbond.c > @@ -84,6 +84,14 @@ static const struct spinand_info winbond > 0, > SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL), > SPINAND_SELECT_TARGET(w25m02gv_select_target)), > + SPINAND_INFO("W25N01GV", 0xAA, > + NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(1, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)), > }; > > /** > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
On Fri, 2018-10-12 at 11:04 +0200, Boris Brezillon wrote: > +Miquel > > Hi Robert, > > Please Cc the NAND mantainers when you send a NAND related patch > (in case you don't know about it already, scripts/get_maintainer.pl > should help you find who to Cc). > Sorry, I knew about scripts/get_maintainer.pl but completelly forgot about it this time. > On Sat, 6 Oct 2018 17:36:42 +0200 > Robert Marko <robimarko@gmail.com> wrote: > > > W25N01GV is a single die version of the already supported > > W25M02GV with half the capacity. Everything else is the > > same so introduce support for W25N01GV. > > > > Datasheet: > > http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf > > > > Tested on 8devices Jalapeno dev board under OpenWrt running 4.19- > > rc5. > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > Looks good. > > Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> > > > --- > > drivers/mtd/nand/spi/winbond.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > --- a/drivers/mtd/nand/spi/winbond.c > > +++ b/drivers/mtd/nand/spi/winbond.c > > @@ -84,6 +84,14 @@ static const struct spinand_info winbond > > 0, > > SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL), > > SPINAND_SELECT_TARGET(w25m02gv_select_target)), > > + SPINAND_INFO("W25N01GV", 0xAA, > > + NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1), > > + NAND_ECCREQ(1, 512), > > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > + &write_cache_variants, > > + &update_cache_variants), > > + 0, > > + SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)), > > }; > > > > /** > > > > ______________________________________________________ > > Linux MTD discussion mailing list > > http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Robert, Boris Brezillon <boris.brezillon@bootlin.com> wrote on Fri, 12 Oct 2018 11:04:12 +0200: > +Miquel > > Hi Robert, > > Please Cc the NAND mantainers when you send a NAND related patch > (in case you don't know about it already, scripts/get_maintainer.pl > should help you find who to Cc). > > On Sat, 6 Oct 2018 17:36:42 +0200 > Robert Marko <robimarko@gmail.com> wrote: > > > W25N01GV is a single die version of the already supported > > W25M02GV with half the capacity. Everything else is the > > same so introduce support for W25N01GV. > > > > Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf > > > > Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5. > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > Looks good. > > Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> Applied to nand/next. Thanks, Miquèl
--- a/drivers/mtd/nand/spi/winbond.c +++ b/drivers/mtd/nand/spi/winbond.c @@ -84,6 +84,14 @@ static const struct spinand_info winbond 0, SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL), SPINAND_SELECT_TARGET(w25m02gv_select_target)), + SPINAND_INFO("W25N01GV", 0xAA, + NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1), + NAND_ECCREQ(1, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, + &write_cache_variants, + &update_cache_variants), + 0, + SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)), }; /**
W25N01GV is a single die version of the already supported W25M02GV with half the capacity. Everything else is the same so introduce support for W25N01GV. Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5. Signed-off-by: Robert Marko <robimarko@gmail.com> --- drivers/mtd/nand/spi/winbond.c | 8 ++++++++ 1 file changed, 8 insertions(+)