Message ID | 1539184516-8200-1-git-send-email-talel@amazon.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [1/2] dt-bindings: spi: dw: add compatible for Alpine spi controller | expand |
On Wed, 2018-10-10 at 18:15 +0300, Talel Shenhar wrote: > Add support for a new devicetree compatible string called > 'al,alpine-apb-ssi', which is necessary for the Amazon Alpine spi > controller. 'al,alpine-dw-apb-ssi' is used in the dw spi driver if > specified in the devicetree. Otherwise, fall back to driver default > behavior, i.e. original dw IP hw driver behavior. > > Signed-off-by: Talel Shenhar <talel@amazon.com> > Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> Shouldn't this be "amzn,alpine-apb-ssi"? The convention, and this IS documented, is to the use company's stock ticker symbol as the prefix, so as to have something grounded in the real world. I don't know of anyone else using a product line name as the company name in their dt bindings. Example, "snps,dw-apb-ssi", is named for Synopsis, not the Designware line.
On 10/11/2018 01:08 AM, Trent Piepho wrote: > On Wed, 2018-10-10 at 18:15 +0300, Talel Shenhar wrote: >> Add support for a new devicetree compatible string called >> 'al,alpine-apb-ssi', which is necessary for the Amazon Alpine spi >> controller. 'al,alpine-dw-apb-ssi' is used in the dw spi driver if >> specified in the devicetree. Otherwise, fall back to driver default >> behavior, i.e. original dw IP hw driver behavior. >> >> Signed-off-by: Talel Shenhar <talel@amazon.com> >> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> > Shouldn't this be "amzn,alpine-apb-ssi"? The convention, and this IS > documented, is to the use company's stock ticker symbol as the prefix, > so as to have something grounded in the real world. I don't know of > anyone else using a product line name as the company name in their dt > bindings. Example, "snps,dw-apb-ssi", is named for Synopsis, not the > Designware line. > updated the vendor prefix to "amazon" as described in bindings/vendor-prefixes.txt.
diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt index 642d3fb..d25b1f8 100644 --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt @@ -2,7 +2,7 @@ Synopsys DesignWare AMBA 2.0 Synchronous Serial Interface. Required properties: - compatible : "snps,dw-apb-ssi" or "mscc,<soc>-spi", where soc is "ocelot" or - "jaguar2" + "jaguar2", or "al,alpine-dw-apb-ssi" - reg : The register base for the controller. For "mscc,<soc>-spi", a second register set is required (named ICPU_CFG:SPI_MST) - interrupts : One interrupt, used by the controller.