| Message ID | 20110221090421.GF328@e-circ.dyndns.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 02/21/2011 10:04 AM, Kurt Van Dijck wrote: > I just found that the controller hardware name is not set for the Softing > driver. After this patch, "$ ip -d link show" looks nicer. > > Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Marc > --- > diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c > index 5157e15..aeea9f9 100644 > --- a/drivers/net/can/softing/softing_main.c > +++ b/drivers/net/can/softing/softing_main.c > @@ -633,6 +633,7 @@ static const struct net_device_ops softing_netdev_ops = { > }; > > static const struct can_bittiming_const softing_btr_const = { > + .name = "softing", > .tseg1_min = 1, > .tseg1_max = 16, > .tseg2_min = 1, > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21.02.2011 10:13, Marc Kleine-Budde wrote: > On 02/21/2011 10:04 AM, Kurt Van Dijck wrote: >> I just found that the controller hardware name is not set for the Softing >> driver. After this patch, "$ ip -d link show" looks nicer. >> >> Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be> > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > Hello Marc, i really appreciate your work regarding the CAN driver maintenance together with Wolfgang! Would it probably make sense to add your name to the drivers/net/can section in the MAINTAINERS file so that Dave and the other listeners on netdev-ML can appraise your Acked-by more easily? Regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Marc Kleine-Budde <mkl@pengutronix.de> Date: Mon, 21 Feb 2011 10:13:37 +0100 > On 02/21/2011 10:04 AM, Kurt Van Dijck wrote: >> I just found that the controller hardware name is not set for the Softing >> driver. After this patch, "$ ip -d link show" looks nicer. >> >> Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be> > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c index 5157e15..aeea9f9 100644 --- a/drivers/net/can/softing/softing_main.c +++ b/drivers/net/can/softing/softing_main.c @@ -633,6 +633,7 @@ static const struct net_device_ops softing_netdev_ops = { }; static const struct can_bittiming_const softing_btr_const = { + .name = "softing", .tseg1_min = 1, .tseg1_max = 16, .tseg2_min = 1,
I just found that the controller hardware name is not set for the Softing driver. After this patch, "$ ip -d link show" looks nicer. Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html