| Message ID | 1298610378-3105-1-git-send-email-r64343@freescale.com |
|---|---|
| State | Accepted |
| Commit | 775adc3d44c8076d3e475fabebb61c08421c4421 |
| Headers | show |
On Fri, 2011-02-25 at 13:06 +0800, Jason Liu wrote: > In the function nand_do_write_oob, the comments > has one typo, this patch fix it. > > - /* Do not allow reads past end of device */ > + /* Do not allow write past end of device */ > if (unlikely(to >= mtd->size || > ops->ooboffs + ops->ooblen > > ((mtd->size >> chip->page_shift) - > (to >> chip->page_shift)) * len)) { > DEBUG(MTD_DEBUG_LEVEL0, "%s: Attempt write beyond " > "end of device\n", __func__); > return -EINVAL; > } > > Signed-off-by: Jason Liu <r64343@freescale.com> Oh, please, do not copy the patch into the commit message! It is enough to say that you fix a typo in a commentary. But I've amended the commit message and pushed the patch to my l2-mtd-2.6.git tree, thanks!
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index a9c6ce7..da76040 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -2377,7 +2377,7 @@ static int nand_do_write_oob(struct mtd_info *mtd, loff_t to, return -EINVAL; } - /* Do not allow reads past end of device */ + /* Do not allow write past end of device */ if (unlikely(to >= mtd->size || ops->ooboffs + ops->ooblen > ((mtd->size >> chip->page_shift) -
In the function nand_do_write_oob, the comments has one typo, this patch fix it. - /* Do not allow reads past end of device */ + /* Do not allow write past end of device */ if (unlikely(to >= mtd->size || ops->ooboffs + ops->ooblen > ((mtd->size >> chip->page_shift) - (to >> chip->page_shift)) * len)) { DEBUG(MTD_DEBUG_LEVEL0, "%s: Attempt write beyond " "end of device\n", __func__); return -EINVAL; } Signed-off-by: Jason Liu <r64343@freescale.com> --- drivers/mtd/nand/nand_base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)