| Message ID | 20180925145616.12610-4-m.felsch@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | Fixes for mcp23s08 | expand |
On 25/09/2018 10:56 PM, Marco Felsch wrote: > This cosmetic patch replaces the 's' by a 'x', since the 's' is a > indication for SPI devices. Furthermore the datasheet refers to mcp23x08 > too. > This breaks general kernel naming convention. Drivers are generally named after the first chip they support. And will cause everyone to have to update their kernel config for no benefit IMO. > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > drivers/pinctrl/Kconfig | 2 +- > drivers/pinctrl/Makefile | 2 +- > drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} | 0 > 3 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} (100%) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index e86752be1f19..1f312f479eb4 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -151,7 +151,7 @@ config PINCTRL_GEMINI > select GENERIC_PINCONF > select MFD_SYSCON > > -config PINCTRL_MCP23S08 > +config PINCTRL_MCP23X08 > tristate "Microchip MCP23xxx I/O expander" > depends on SPI_MASTER || I2C > depends on I2C || I2C=n > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index 46ef9bd52096..036c34f7d099 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -19,7 +19,7 @@ obj-$(CONFIG_PINCTRL_DIGICOLOR) += pinctrl-digicolor.o > obj-$(CONFIG_PINCTRL_FALCON) += pinctrl-falcon.o > obj-$(CONFIG_PINCTRL_GEMINI) += pinctrl-gemini.o > obj-$(CONFIG_PINCTRL_MAX77620) += pinctrl-max77620.o > -obj-$(CONFIG_PINCTRL_MCP23S08) += pinctrl-mcp23s08.o > +obj-$(CONFIG_PINCTRL_MCP23X08) += pinctrl-mcp23x08.o > obj-$(CONFIG_PINCTRL_MESON) += meson/ > obj-$(CONFIG_PINCTRL_OXNAS) += pinctrl-oxnas.o > obj-$(CONFIG_PINCTRL_PALMAS) += pinctrl-palmas.o > diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23x08.c > similarity index 100% > rename from drivers/pinctrl/pinctrl-mcp23s08.c > rename to drivers/pinctrl/pinctrl-mcp23x08.c >
On 18-09-26 07:59, Phil Reid wrote: > On 25/09/2018 10:56 PM, Marco Felsch wrote: > > This cosmetic patch replaces the 's' by a 'x', since the 's' is a > > indication for SPI devices. Furthermore the datasheet refers to mcp23x08 > > too. > > > > This breaks general kernel naming convention. Drivers are generally named after the > first chip they support. > And will cause everyone to have to update their kernel config for no benefit IMO. Okay, thanks for the explanation. Regards, Marco > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > drivers/pinctrl/Kconfig | 2 +- > > drivers/pinctrl/Makefile | 2 +- > > drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} | 0 > > 3 files changed, 2 insertions(+), 2 deletions(-) > > rename drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} (100%) > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > index e86752be1f19..1f312f479eb4 100644 > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -151,7 +151,7 @@ config PINCTRL_GEMINI > > select GENERIC_PINCONF > > select MFD_SYSCON > > -config PINCTRL_MCP23S08 > > +config PINCTRL_MCP23X08 > > tristate "Microchip MCP23xxx I/O expander" > > depends on SPI_MASTER || I2C > > depends on I2C || I2C=n > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > > index 46ef9bd52096..036c34f7d099 100644 > > --- a/drivers/pinctrl/Makefile > > +++ b/drivers/pinctrl/Makefile > > @@ -19,7 +19,7 @@ obj-$(CONFIG_PINCTRL_DIGICOLOR) += pinctrl-digicolor.o > > obj-$(CONFIG_PINCTRL_FALCON) += pinctrl-falcon.o > > obj-$(CONFIG_PINCTRL_GEMINI) += pinctrl-gemini.o > > obj-$(CONFIG_PINCTRL_MAX77620) += pinctrl-max77620.o > > -obj-$(CONFIG_PINCTRL_MCP23S08) += pinctrl-mcp23s08.o > > +obj-$(CONFIG_PINCTRL_MCP23X08) += pinctrl-mcp23x08.o > > obj-$(CONFIG_PINCTRL_MESON) += meson/ > > obj-$(CONFIG_PINCTRL_OXNAS) += pinctrl-oxnas.o > > obj-$(CONFIG_PINCTRL_PALMAS) += pinctrl-palmas.o > > diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23x08.c > > similarity index 100% > > rename from drivers/pinctrl/pinctrl-mcp23s08.c > > rename to drivers/pinctrl/pinctrl-mcp23x08.c > > > > > -- > Regards > Phil Reid > >
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index e86752be1f19..1f312f479eb4 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -151,7 +151,7 @@ config PINCTRL_GEMINI select GENERIC_PINCONF select MFD_SYSCON -config PINCTRL_MCP23S08 +config PINCTRL_MCP23X08 tristate "Microchip MCP23xxx I/O expander" depends on SPI_MASTER || I2C depends on I2C || I2C=n diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 46ef9bd52096..036c34f7d099 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -19,7 +19,7 @@ obj-$(CONFIG_PINCTRL_DIGICOLOR) += pinctrl-digicolor.o obj-$(CONFIG_PINCTRL_FALCON) += pinctrl-falcon.o obj-$(CONFIG_PINCTRL_GEMINI) += pinctrl-gemini.o obj-$(CONFIG_PINCTRL_MAX77620) += pinctrl-max77620.o -obj-$(CONFIG_PINCTRL_MCP23S08) += pinctrl-mcp23s08.o +obj-$(CONFIG_PINCTRL_MCP23X08) += pinctrl-mcp23x08.o obj-$(CONFIG_PINCTRL_MESON) += meson/ obj-$(CONFIG_PINCTRL_OXNAS) += pinctrl-oxnas.o obj-$(CONFIG_PINCTRL_PALMAS) += pinctrl-palmas.o diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23x08.c similarity index 100% rename from drivers/pinctrl/pinctrl-mcp23s08.c rename to drivers/pinctrl/pinctrl-mcp23x08.c
This cosmetic patch replaces the 's' by a 'x', since the 's' is a indication for SPI devices. Furthermore the datasheet refers to mcp23x08 too. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/Makefile | 2 +- drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/pinctrl/{pinctrl-mcp23s08.c => pinctrl-mcp23x08.c} (100%)