Message ID | 20180914171916.21298-1-colin.king@canonical.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | net: caif: remove redundant null check on frontpkt | expand |
Hello! On 09/14/2018 08:19 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > It is impossible for frontpkt to be null at the point of the null > check because it has been assigned from rearpkt and there is no > way realpkt can be null at the point of the assignment because rearpkt? > of the sanity checking and exit paths taken previously. Remove > the redundant null check. > > Detected by CoverityScan, CID#114434 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> [...] MBR, Sergei
On 14/09/18 18:54, Sergei Shtylyov wrote: > Hello! > > On 09/14/2018 08:19 PM, Colin King wrote: > >> From: Colin Ian King <colin.king@canonical.com> >> >> It is impossible for frontpkt to be null at the point of the null >> check because it has been assigned from rearpkt and there is no >> way realpkt can be null at the point of the assignment because > > rearpkt? Good spot. Can this be fixed up when the patch is applied? > >> of the sanity checking and exit paths taken previously. Remove >> the redundant null check. >> >> Detected by CoverityScan, CID#114434 ("Logically dead code") >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > [...] > > MBR, Sergei >
From: Colin King <colin.king@canonical.com> Date: Fri, 14 Sep 2018 18:19:16 +0100 > From: Colin Ian King <colin.king@canonical.com> > > It is impossible for frontpkt to be null at the point of the null > check because it has been assigned from rearpkt and there is no > way realpkt can be null at the point of the assignment because > of the sanity checking and exit paths taken previously. Remove > the redundant null check. > > Detected by CoverityScan, CID#114434 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Appied to net-next with typo fixed. Thanks.
diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c index b82440e1fcb4..a931a71ef6df 100644 --- a/net/caif/cfrfml.c +++ b/net/caif/cfrfml.c @@ -264,9 +264,6 @@ static int cfrfml_transmit(struct cflayer *layr, struct cfpkt *pkt) frontpkt = rearpkt; rearpkt = NULL; - err = -ENOMEM; - if (frontpkt == NULL) - goto out; err = -EPROTO; if (cfpkt_add_head(frontpkt, head, 6) < 0) goto out;