Message ID | 20180903105017.31106-1-pvorel@suse.cz |
---|---|
State | Accepted |
Delegated to: | Petr Vorel |
Headers | show |
Series | [1/1] runltp: Remove RHOST setup | expand |
Hi! > To be honest, I'd prefer removing -N option from runltp or replace it > with info "Run network tests via network.sh script" (+ remove > scenario_groups/network). Hmm, that may be a good solution for the moment, but in the long term we may want to have a single tool to run all our tests > I'm looking forward the day this crazy script is replaced with something > more convenient. Yes indeed, but it seems that I will need another hackweek to make the proof of concept more usable...
Hi, > Hi! > > To be honest, I'd prefer removing -N option from runltp or replace it > > with info "Run network tests via network.sh script" (+ remove > > scenario_groups/network). > Hmm, that may be a good solution for the moment, but in the long term we > may want to have a single tool to run all our tests Understand. In that case I'll apply this patch as it unifies the behavior with network.sh. > > I'm looking forward the day this crazy script is replaced with something > > more convenient. > Yes indeed, but it seems that I will need another hackweek to make the > proof of concept more usable... Thanks a lot for your work. I'll help at least with the testing. Kind regards, Petr
Hi, > Hi! > > To be honest, I'd prefer removing -N option from runltp or replace it > > with info "Run network tests via network.sh script" (+ remove > > scenario_groups/network). > Hmm, that may be a good solution for the moment, but in the long term we > may want to have a single tool to run all our tests Just to clarify: network tests are able to run by either runner (runltp or network.sh). It's just the issue that runltp in inflexible for network tests. It's because all network tests load tst_net.sh themselves. So with the new runner, network tests will be able to be run by it anyway. > > I'm looking forward the day this crazy script is replaced with something > > more convenient. > Yes indeed, but it seems that I will need another hackweek to make the > proof of concept more usable... Kind regards, Petr
> as RSH is deprecated. The default management link of network tests are > network namespaces. For remote management is better to setup SSH via: > TST_USE_SSH=1 > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- Pushed. Kind regards, Petr
diff --git a/runltp b/runltp index bbbb58771..5e2f5668d 100755 --- a/runltp +++ b/runltp @@ -570,30 +570,6 @@ main() INSTANCES="$INSTANCES -O ${TMP}" } - [ "$RUN_NETEST" -eq 1 ] && \ - { - [ -z "$RHOST" ] || [ -z "$PASSWD" ] && \ - { - [ -z "$RHOST" ] && \ - { - printf "INFO: Enter RHOST = 'name of the remote host machine'" - printf "\n-> " - read RHOST - } - - [ -z "$PASSWD" ] && \ - { - printf "\nINFO: " - printf "Enter PASSWD = 'root passwd of the remote host machine'" - printf "\n-> " - read PASSWD - } - export RHOST=$RHOST - export PASSWD=$PASSWD - echo "WARNING: security of $RHOST may be compromised" - } - } - # If user does not provide a command file select a default set of testcases # to execute. if [ -z "$CMDFILES" ] && [ -z "$CMDFILEADDR" ]; then
as RSH is deprecated. The default management link of network tests are network namespaces. For remote management is better to setup SSH via: TST_USE_SSH=1 Signed-off-by: Petr Vorel <pvorel@suse.cz> --- To be honest, I'd prefer removing -N option from runltp or replace it with info "Run network tests via network.sh script" (+ remove scenario_groups/network). I'm looking forward the day this crazy script is replaced with something more convenient. Kind regards, Petr --- runltp | 24 ------------------------ 1 file changed, 24 deletions(-)