| Message ID | 20180807093226.5624-2-rf@opensource.cirrus.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] pinctrl: madera: Set is_generic | expand |
On Tue, Aug 7, 2018 at 11:32 AM Richard Fitzgerald <rf@opensource.cirrus.com> wrote: > The pin_config_[get|set] functions should return ENOTSUPP if > the requested attribute isn't supported. > > Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c index 4f9b7e3b7cf2..4ba56ca5a9be 100644 --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c @@ -801,7 +801,7 @@ static int madera_pin_conf_get(struct pinctrl_dev *pctldev, unsigned int pin, result = 1; break; default: - break; + return -ENOTSUPP; } *config = pinconf_to_config_packed(param, result); @@ -905,7 +905,7 @@ static int madera_pin_conf_set(struct pinctrl_dev *pctldev, unsigned int pin, conf[1] &= ~MADERA_GP1_DIR; break; default: - break; + return -ENOTSUPP; } ++configs;
The pin_config_[get|set] functions should return ENOTSUPP if the requested attribute isn't supported. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> --- drivers/pinctrl/cirrus/pinctrl-madera-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)