| Message ID | 20180813145027.16346-11-thierry.reding@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | staging: media: tegra-vdea: Add Tegra124 support | expand |
On Monday, 13 August 2018 17:50:23 MSK Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > There is no point in keeping the VDE module out of reset when it is not > in use. Reset it on runtime suspend. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/staging/media/tegra-vde/tegra-vde.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c > b/drivers/staging/media/tegra-vde/tegra-vde.c index > 3bc0bfcfe34e..4b3c6ab3c77e 100644 > --- a/drivers/staging/media/tegra-vde/tegra-vde.c > +++ b/drivers/staging/media/tegra-vde/tegra-vde.c > @@ -1226,6 +1226,7 @@ static int tegra_vde_runtime_suspend(struct device > *dev) } > > reset_control_assert(vde->rst_bsev); > + reset_control_assert(vde->rst); > > usleep_range(2000, 4000); There is also no point to reset VDE while it is powered off, then why do we that?
diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c index 3bc0bfcfe34e..4b3c6ab3c77e 100644 --- a/drivers/staging/media/tegra-vde/tegra-vde.c +++ b/drivers/staging/media/tegra-vde/tegra-vde.c @@ -1226,6 +1226,7 @@ static int tegra_vde_runtime_suspend(struct device *dev) } reset_control_assert(vde->rst_bsev); + reset_control_assert(vde->rst); usleep_range(2000, 4000);