diff mbox series

[04/13] lib: fwts_firmware: remove some empty lines

Message ID 20180814112435.22166-5-colin.king@canonical.com
State Accepted
Headers show
Series lib: minor code clean up | expand

Commit Message

Colin Ian King Aug. 14, 2018, 11:24 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

No functional change, just clean up some empty lines.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_firmware.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Alex Hung Aug. 14, 2018, 7:14 p.m. UTC | #1 
On 2018-08-14 04:24 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> No functional change, just clean up some empty lines.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_firmware.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
> index 3191a31f..ad11ebed 100644
> --- a/src/lib/src/fwts_firmware.c
> +++ b/src/lib/src/fwts_firmware.c
> @@ -63,7 +63,6 @@ fwts_firmware_type fwts_firmware_detect(void)
>   int fwts_firmware_features(void)
>   {
>   	int features = 0;
> -
>   	struct stat ipmi_statbuf;
>   
>   	switch (fwts_firmware_detect()) {
> @@ -106,7 +105,6 @@ const char *fwts_firmware_feature_string(const fwts_firmware_feature features)
>   			invalid_feature_names);
>   
>   	for (p = str, i = 0; i < n; i++) {
> -
>   		if (!(features & feature_names[i].feature))
>   			continue;
>   
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Aug. 16, 2018, 9:03 a.m. UTC | #2 
On 08/14/2018 07:24 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> No functional change, just clean up some empty lines.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_firmware.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
> index 3191a31f..ad11ebed 100644
> --- a/src/lib/src/fwts_firmware.c
> +++ b/src/lib/src/fwts_firmware.c
> @@ -63,7 +63,6 @@ fwts_firmware_type fwts_firmware_detect(void)
>  int fwts_firmware_features(void)
>  {
>  	int features = 0;
> -
>  	struct stat ipmi_statbuf;
>  
>  	switch (fwts_firmware_detect()) {
> @@ -106,7 +105,6 @@ const char *fwts_firmware_feature_string(const fwts_firmware_feature features)
>  			invalid_feature_names);
>  
>  	for (p = str, i = 0; i < n; i++) {
> -
>  		if (!(features & feature_names[i].feature))
>  			continue;
>  

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
index 3191a31f..ad11ebed 100644
--- a/src/lib/src/fwts_firmware.c
+++ b/src/lib/src/fwts_firmware.c
@@ -63,7 +63,6 @@  fwts_firmware_type fwts_firmware_detect(void)
 int fwts_firmware_features(void)
 {
 	int features = 0;
-
 	struct stat ipmi_statbuf;
 
 	switch (fwts_firmware_detect()) {
@@ -106,7 +105,6 @@  const char *fwts_firmware_feature_string(const fwts_firmware_feature features)
 			invalid_feature_names);
 
 	for (p = str, i = 0; i < n; i++) {
-
 		if (!(features & feature_names[i].feature))
 			continue;