| Message ID | 20180808115724.gh5mbbi6twzqbqao@kili.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c42d3be0c06f0c1c416054022aa535c08a1f9b39 |
| Headers | show |
| Series | powerpc: fix size calculation using resource_size() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | success | Test checkpatch on branch next |
| snowpatch_ozlabs/build-ppc64le | success | Test build-ppc64le on branch next |
| snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch next |
| snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch next |
| snowpatch_ozlabs/build-ppc32 | success | Test build-ppc32 on branch next |
On 08/08/2018 04:57 AM, Dan Carpenter wrote: > The problem is the the calculation should be "end - start + 1" but the > plus one is missing in this calculation. > > Fixes: 8626816e905e ("powerpc: add support for MPIC message register API") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Static analysis. Not tested. Looks sane to me. Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > > diff --git a/arch/powerpc/sysdev/mpic_msgr.c b/arch/powerpc/sysdev/mpic_msgr.c > index eb69a5186243..280e964e1aa8 100644 > --- a/arch/powerpc/sysdev/mpic_msgr.c > +++ b/arch/powerpc/sysdev/mpic_msgr.c > @@ -196,7 +196,7 @@ static int mpic_msgr_probe(struct platform_device *dev) > > /* IO map the message register block. */ > of_address_to_resource(np, 0, &rsrc); > - msgr_block_addr = ioremap(rsrc.start, rsrc.end - rsrc.start); > + msgr_block_addr = ioremap(rsrc.start, resource_size(&rsrc)); > if (!msgr_block_addr) { > dev_err(&dev->dev, "Failed to iomap MPIC message registers"); > return -EFAULT; >
On Wed, 2018-08-08 at 11:57:24 UTC, Dan Carpenter wrote: > The problem is the the calculation should be "end - start + 1" but the > plus one is missing in this calculation. > > Fixes: 8626816e905e ("powerpc: add support for MPIC message register API") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c42d3be0c06f0c1c416054022aa535 cheers
diff --git a/arch/powerpc/sysdev/mpic_msgr.c b/arch/powerpc/sysdev/mpic_msgr.c index eb69a5186243..280e964e1aa8 100644 --- a/arch/powerpc/sysdev/mpic_msgr.c +++ b/arch/powerpc/sysdev/mpic_msgr.c @@ -196,7 +196,7 @@ static int mpic_msgr_probe(struct platform_device *dev) /* IO map the message register block. */ of_address_to_resource(np, 0, &rsrc); - msgr_block_addr = ioremap(rsrc.start, rsrc.end - rsrc.start); + msgr_block_addr = ioremap(rsrc.start, resource_size(&rsrc)); if (!msgr_block_addr) { dev_err(&dev->dev, "Failed to iomap MPIC message registers"); return -EFAULT;
The problem is the the calculation should be "end - start + 1" but the plus one is missing in this calculation. Fixes: 8626816e905e ("powerpc: add support for MPIC message register API") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Static analysis. Not tested.