| Message ID | 1533640705-7974-2-git-send-email-ivan.hu@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] uefi: clean and check status with magic value ~0ULL (LP: #1784365) | expand |
On 07/08/18 12:18, Ivan Hu wrote: > uefivarinfo actually call to runtime services provided by UEFI firmware to > get the variable infomation. It should be on UNSAFE category. > > Signed-off-by: Ivan Hu <ivan.hu@canonical.com> > --- > src/uefi/uefivarinfo/uefivarinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/uefi/uefivarinfo/uefivarinfo.c b/src/uefi/uefivarinfo/uefivarinfo.c > index a54a636..58b8f68 100644 > --- a/src/uefi/uefivarinfo/uefivarinfo.c > +++ b/src/uefi/uefivarinfo/uefivarinfo.c > @@ -253,6 +253,6 @@ static fwts_framework_ops uefivarinfo_ops = { > .minor_tests = uefivarinfo_tests > }; > > -FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV) > +FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV) > > #endif > Seems like a very good idea to mark it unsafe. Acked-by: Colin Ian King <colin.king@canonical.com>
On 2018-08-07 04:24 AM, Colin Ian King wrote: > On 07/08/18 12:18, Ivan Hu wrote: >> uefivarinfo actually call to runtime services provided by UEFI firmware to >> get the variable infomation. It should be on UNSAFE category. >> >> Signed-off-by: Ivan Hu <ivan.hu@canonical.com> >> --- >> src/uefi/uefivarinfo/uefivarinfo.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/uefi/uefivarinfo/uefivarinfo.c b/src/uefi/uefivarinfo/uefivarinfo.c >> index a54a636..58b8f68 100644 >> --- a/src/uefi/uefivarinfo/uefivarinfo.c >> +++ b/src/uefi/uefivarinfo/uefivarinfo.c >> @@ -253,6 +253,6 @@ static fwts_framework_ops uefivarinfo_ops = { >> .minor_tests = uefivarinfo_tests >> }; >> >> -FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV) >> +FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV) >> >> #endif >> > > Seems like a very good idea to mark it unsafe. > > Acked-by: Colin Ian King <colin.king@canonical.com> > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/uefi/uefivarinfo/uefivarinfo.c b/src/uefi/uefivarinfo/uefivarinfo.c index a54a636..58b8f68 100644 --- a/src/uefi/uefivarinfo/uefivarinfo.c +++ b/src/uefi/uefivarinfo/uefivarinfo.c @@ -253,6 +253,6 @@ static fwts_framework_ops uefivarinfo_ops = { .minor_tests = uefivarinfo_tests }; -FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV) +FWTS_REGISTER("uefivarinfo", &uefivarinfo_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV) #endif
uefivarinfo actually call to runtime services provided by UEFI firmware to get the variable infomation. It should be on UNSAFE category. Signed-off-by: Ivan Hu <ivan.hu@canonical.com> --- src/uefi/uefivarinfo/uefivarinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)