| Message ID | bdd735da9a3c8159756b084ca96b555437057fa4.1530766981.git.viresh.kumar@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt: thermal: Fix broken cooling-maps | expand |
On 05-07-18, 10:39, Viresh Kumar wrote: > Allow cooling devices sharing same trip point with same contribution > value to share the cooling map as well. Otherwise the same information > will be duplicated for each device sharing the trip point. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index cc553f0952c5..eb7ee91556a5 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -97,8 +97,8 @@ get assigned to trip points of the zone. The cooling devices are expected > to be loaded in the target system. > > Required properties: > -- cooling-device: A phandle of a cooling device with its specifier, > - Type: phandle + referring to which cooling device is used in this > +- cooling-device: A list of phandles of cooling devices with their specifiers, > + Type: phandle + referring to which cooling devices are used in this > cooling specifier binding. In the cooling specifier, the first cell > is the minimum cooling state and the second cell > is the maximum cooling state used in this map. > @@ -276,12 +276,7 @@ thermal-zones { > }; > map1 { > trip = <&cpu_alert1>; > - cooling-device = <&fan0 5 THERMAL_NO_LIMIT>; > - }; > - map2 { > - trip = <&cpu_alert1>; > - cooling-device = > - <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + cooling-device = <&fan0 5 THERMAL_NO_LIMIT>, <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > }; > }; > }; Any objections to this ? Can you guys provide Acks ?
On Thu, Jul 05, 2018 at 10:39:23AM +0530, Viresh Kumar wrote: > Allow cooling devices sharing same trip point with same contribution > value to share the cooling map as well. Otherwise the same information > will be duplicated for each device sharing the trip point. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index cc553f0952c5..eb7ee91556a5 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt @@ -97,8 +97,8 @@ get assigned to trip points of the zone. The cooling devices are expected to be loaded in the target system. Required properties: -- cooling-device: A phandle of a cooling device with its specifier, - Type: phandle + referring to which cooling device is used in this +- cooling-device: A list of phandles of cooling devices with their specifiers, + Type: phandle + referring to which cooling devices are used in this cooling specifier binding. In the cooling specifier, the first cell is the minimum cooling state and the second cell is the maximum cooling state used in this map. @@ -276,12 +276,7 @@ thermal-zones { }; map1 { trip = <&cpu_alert1>; - cooling-device = <&fan0 5 THERMAL_NO_LIMIT>; - }; - map2 { - trip = <&cpu_alert1>; - cooling-device = - <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&fan0 5 THERMAL_NO_LIMIT>, <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };
Allow cooling devices sharing same trip point with same contribution value to share the cooling map as well. Otherwise the same information will be duplicated for each device sharing the trip point. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)