Message ID | 20180610221645.GA26123@piout.net |
---|---|
State | Accepted |
Headers | show |
Series | [GIT,PULL] RTC for 4.18 | expand |
Hi Alexandre, On 10/06/18 23:16, Alexandre Belloni wrote: > Hi Linus, > > Here is the pull-request for the RTC subsystem for 4.18. > > Setting the supported range from drivers for RTCs failing soon has > started. A few fixes are developed along the way. > Some drivers have been switched to SPDX by their maintainers. > > The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: > > Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git tags/rtc-4.18 > > for you to fetch changes up to e4302aec8a0646828a701443e303eb5ef48b37f5: > > rtc: pxa: fix probe function (2018-06-07 20:11:08 +0200) > > ---------------------------------------------------------------- > RTC for 4.18 > > Subsystem: > - rework of the rtc-test driver which allows to test the core more thoroughly > - rtc_set_alarm() now fails early when alarms are not supported > > Drivers: > - mktime is now replaced by mktime64 > - RTC range added for 88pm80x, ab-b5ze-s3, at91rm9200, brcmstb-waketimer, > ds1685, ftrtc010, ls1x, mxc_v2, rx8581, sprd, st-lpc, tps6586x, tps65910 and > vr41xx > - Fixed a possible race condition in probe functions > - pxa: fix the probe function that is broken since v4.3 > - stm32: now supports stm32mp1 > > ---------------------------------------------------------------- > Alexandre Belloni (49): ... > rtc: tps6586x: let the core handle rtc range Sorry I am missing the original mail with the above change, but I have noticed on v4.18-rc1 that rtc wake-ups from suspend are no longer working on one of our Tegra boards. The bisect points to the above change and reverting it fixes the problem. I have not had chance to dig further, but if you have any thoughts, please let me know. Thanks! Jon
Hi, On 26/06/2018 16:51:40+0100, Jon Hunter wrote: > > rtc: tps6586x: let the core handle rtc range > > Sorry I am missing the original mail with the above change, but I > have noticed on v4.18-rc1 that rtc wake-ups from suspend are no > longer working on one of our Tegra boards. The bisect points to the > above change and reverting it fixes the problem. I have not had > chance to dig further, but if you have any thoughts, please let me > know. Thanks for the report, does the following patch fix the issue: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=1b287f23b0a1fcb2b502dae981a8024be379391e
On 26/06/18 17:15, Alexandre Belloni wrote: > Hi, > > On 26/06/2018 16:51:40+0100, Jon Hunter wrote: >>> rtc: tps6586x: let the core handle rtc range >> >> Sorry I am missing the original mail with the above change, but I >> have noticed on v4.18-rc1 that rtc wake-ups from suspend are no >> longer working on one of our Tegra boards. The bisect points to the >> above change and reverting it fixes the problem. I have not had >> chance to dig further, but if you have any thoughts, please let me >> know. > > > Thanks for the report, does the following patch fix the issue: > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=1b287f23b0a1fcb2b502dae981a8024be379391e Thanks. I gave the above a test, but still not waking-up from suspend. Cheers Jon
On 26/06/2018 17:54:57+0100, Jon Hunter wrote: > > On 26/06/18 17:15, Alexandre Belloni wrote: > > Hi, > > > > On 26/06/2018 16:51:40+0100, Jon Hunter wrote: > >>> rtc: tps6586x: let the core handle rtc range > >> > >> Sorry I am missing the original mail with the above change, but I > >> have noticed on v4.18-rc1 that rtc wake-ups from suspend are no > >> longer working on one of our Tegra boards. The bisect points to the > >> above change and reverting it fixes the problem. I have not had > >> chance to dig further, but if you have any thoughts, please let me > >> know. > > > > > > Thanks for the report, does the following patch fix the issue: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=1b287f23b0a1fcb2b502dae981a8024be379391e > > Thanks. I gave the above a test, but still not waking-up from suspend. > Ok, I probably found the issue but the fix is not immediate. I'll try to post something tomorrow.
Hi Alexandre, On 26/06/18 22:31, Alexandre Belloni wrote: > On 26/06/2018 17:54:57+0100, Jon Hunter wrote: >> >> On 26/06/18 17:15, Alexandre Belloni wrote: >>> Hi, >>> >>> On 26/06/2018 16:51:40+0100, Jon Hunter wrote: >>>>> rtc: tps6586x: let the core handle rtc range >>>> >>>> Sorry I am missing the original mail with the above change, but I >>>> have noticed on v4.18-rc1 that rtc wake-ups from suspend are no >>>> longer working on one of our Tegra boards. The bisect points to the >>>> above change and reverting it fixes the problem. I have not had >>>> chance to dig further, but if you have any thoughts, please let me >>>> know. >>> >>> >>> Thanks for the report, does the following patch fix the issue: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=1b287f23b0a1fcb2b502dae981a8024be379391e >> >> Thanks. I gave the above a test, but still not waking-up from suspend. >> > > Ok, I probably found the issue but the fix is not immediate. I'll try to > post something tomorrow. Sorry if I missed it, but did you send a fix for this? Cheers Jon
On 09/07/2018 13:04:36+0100, Jon Hunter wrote: > > Ok, I probably found the issue but the fix is not immediate. I'll try to > > post something tomorrow. > > Sorry if I missed it, but did you send a fix for this? > Not yet, I'll keep you copied. I was missing the serial cable of my T20 board with this PMIC. I'll try to find some time later this week to solve that. If I can't fix it on time, I'll revert the patch.
Hi Jon, Can you test that one? https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=4393575d9aa250c74335f8b37e0466b872b5080 This fixes setting alarms on the TPS658623 of my T20 board but I don't get the interrupt I'm expecting. However, I don't get interrupts with the offending patch reverted so hopefully, this fix is sufficient. On 09/07/2018 14:17:47+0200, Alexandre Belloni wrote: > On 09/07/2018 13:04:36+0100, Jon Hunter wrote: > > > Ok, I probably found the issue but the fix is not immediate. I'll try to > > > post something tomorrow. > > > > Sorry if I missed it, but did you send a fix for this? > > > > Not yet, I'll keep you copied. I was missing the serial cable of my T20 > board with this PMIC. I'll try to find some time later this week to > solve that. > > If I can't fix it on time, I'll revert the patch. > > > -- > Alexandre Belloni, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com
Hi Alexandre. On 10/07/18 23:14, Alexandre Belloni wrote: > Hi Jon, > > Can you test that one? > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=4393575d9aa250c74335f8b37e0466b872b5080 > > This fixes setting alarms on the TPS658623 of my T20 board but I don't > get the interrupt I'm expecting. However, I don't get interrupts with > the offending patch reverted so hopefully, this fix is sufficient. Yes this fixes the problem. Feel free to add my ... Tested-by: Jon Hunter <jonathanh@nvidia.com> Cheers! Jon
On 11/07/2018 10:17:11+0100, Jon Hunter wrote: > Hi Alexandre. > > On 10/07/18 23:14, Alexandre Belloni wrote: > > Hi Jon, > > > > Can you test that one? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/patch/?id=4393575d9aa250c74335f8b37e0466b872b5080 > > > > This fixes setting alarms on the TPS658623 of my T20 board but I don't > > get the interrupt I'm expecting. However, I don't get interrupts with > > the offending patch reverted so hopefully, this fix is sufficient. > > Yes this fixes the problem. Feel free to add my ... > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Great ! Thank you for your patience, I'll send it as a fix before Sunday.