Message ID | 20180709150043.13737-1-antoine.tenart@bootlin.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | [net-next] net: mvpp2: explicitly include linux/interrupt.h | expand |
+10 Yan Markman Tel. 05-44732819 -----Original Message----- From: Antoine Tenart [mailto:antoine.tenart@bootlin.com] Sent: Monday, July 09, 2018 6:01 PM To: davem@davemloft.net Cc: Antoine Tenart <antoine.tenart@bootlin.com>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; thomas.petazzoni@bootlin.com; maxime.chevallier@bootlin.com; gregory.clement@bootlin.com; miquel.raynal@bootlin.com; Nadav Haklai <nadavh@marvell.com>; Stefan Chulski <stefanc@marvell.com>; Yan Markman <ymarkman@marvell.com>; mw@semihalf.com Subject: [EXT] [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h External Email ---------------------------------------------------------------------- The Marvell PPv2 driver uses interrupts and tasklet but does not explicitly include linux/interrupt.h, relying on implicit includes. This one particularly is included by chance after a long unlogical chain of inclusions. Fix this so we do not get future build breaks. Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h index 81a66cce7fa8..18834619bb3a 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h @@ -12,6 +12,7 @@ #ifndef _MVPP2_H_ #define _MVPP2_H_ +#include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/netdevice.h> #include <linux/phy.h> -- 2.17.1
From: Antoine Tenart <antoine.tenart@bootlin.com> Date: Mon, 9 Jul 2018 17:00:43 +0200 > The Marvell PPv2 driver uses interrupts and tasklet but does not > explicitly include linux/interrupt.h, relying on implicit includes. This > one particularly is included by chance after a long unlogical chain of > inclusions. Fix this so we do not get future build breaks. > > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> Applied.
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h index 81a66cce7fa8..18834619bb3a 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h @@ -12,6 +12,7 @@ #ifndef _MVPP2_H_ #define _MVPP2_H_ +#include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/netdevice.h> #include <linux/phy.h>
The Marvell PPv2 driver uses interrupts and tasklet but does not explicitly include linux/interrupt.h, relying on implicit includes. This one particularly is included by chance after a long unlogical chain of inclusions. Fix this so we do not get future build breaks. Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + 1 file changed, 1 insertion(+)