| Message ID | 20180705155127.GA1458@embeddedor.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: baytrail: Mark expected switch fall-throughs | expand |
On Thu, Jul 05, 2018 at 10:51:27AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1292308 ("Missing break in switch") > Addresses-Coverity-ID: 1292309 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 5, 2018 at 5:51 PM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1292308 ("Missing break in switch") > Addresses-Coverity-ID: 1292309 ("Missing break in switch") I hope these special tags are accepted by the community at large. Has there been discussion? > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Patch applied with Mika's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus, On 07/09/2018 08:42 AM, Linus Walleij wrote: > On Thu, Jul 5, 2018 at 5:51 PM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Addresses-Coverity-ID: 1292308 ("Missing break in switch") >> Addresses-Coverity-ID: 1292309 ("Missing break in switch") > > I hope these special tags are accepted by the community at large. > Has there been discussion? > Yes. This is information we want to keep on the changelog: http://lkml.iu.edu/hypermail/linux/kernel/1710.3/04013.html >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Patch applied with Mika's ACK. > Thanks -- Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 6b52ea1..3420e7e 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1542,11 +1542,13 @@ static void byt_irq_unmask(struct irq_data *d) switch (irqd_get_trigger_type(d)) { case IRQ_TYPE_LEVEL_HIGH: value |= BYT_TRIG_LVL; + /* fall through */ case IRQ_TYPE_EDGE_RISING: value |= BYT_TRIG_POS; break; case IRQ_TYPE_LEVEL_LOW: value |= BYT_TRIG_LVL; + /* fall through */ case IRQ_TYPE_EDGE_FALLING: value |= BYT_TRIG_NEG; break;
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1292308 ("Missing break in switch") Addresses-Coverity-ID: 1292309 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/pinctrl/intel/pinctrl-baytrail.c | 2 ++ 1 file changed, 2 insertions(+)