| Message ID | 1770bc23-75f1-d462-b8a3-61e81ade4c3c@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] r8169: fix mac address change | expand |
On Jul 2 22:49, Heiner Kallweit wrote: > Network core refuses to change mac address because flag > IFF_LIVE_ADDR_CHANGE isn't set. Set this missing flag. > > Fixes: 1f7aa2bc268e ("r8169: simplify rtl_set_mac_address") > Reported-by: Corinna Vinschen <vinschen@redhat.com> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/realtek/r8169.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index f80ac894..a390db27 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7607,6 +7607,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > NETIF_F_HW_VLAN_CTAG_RX; > dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO | > NETIF_F_HIGHDMA; > + dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; > > tp->cp_cmd |= RxChkSum | RxVlan; > > -- > 2.18.0 Tested-by: Corinna Vinschen <vinschen@redhat.com> This patch allows to change the MAC any time, just as before 1f7aa2bc268e, and thus also fixes the problem reported in https://www.spinics.net/lists/netdev/msg510926.html Thanks, Corinna
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Mon, 2 Jul 2018 22:49:35 +0200 > Network core refuses to change mac address because flag > IFF_LIVE_ADDR_CHANGE isn't set. Set this missing flag. > > Fixes: 1f7aa2bc268e ("r8169: simplify rtl_set_mac_address") > Reported-by: Corinna Vinschen <vinschen@redhat.com> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied and queued up for -stable.
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index f80ac894..a390db27 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -7607,6 +7607,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) NETIF_F_HW_VLAN_CTAG_RX; dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO | NETIF_F_HIGHDMA; + dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; tp->cp_cmd |= RxChkSum | RxVlan;
Network core refuses to change mac address because flag IFF_LIVE_ADDR_CHANGE isn't set. Set this missing flag. Fixes: 1f7aa2bc268e ("r8169: simplify rtl_set_mac_address") Reported-by: Corinna Vinschen <vinschen@redhat.com> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169.c | 1 + 1 file changed, 1 insertion(+)