| Message ID | 90e6ba4fc224adef20049b65fe56@google.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Feb 3, 2011 at 11:44 AM, <dnovillo@google.com> wrote: > Reviewers: gcc-patches_gcc.gnu.org, iant2, > > Description: > Only send mail to bugzilla and gcc-cvs when a commit happens in trunk > or any of the release branches. I think this is wrong. We want all branches still to send to gcc-cvs. In fact for some other branches we want to send to bugzilla too. Stuff like tms and GOMP and Tree-SSA was all developed on a branch and they started to get bug reports. I think people should rather be more careful at what they add to commit messages rather than a huge change like this. -- Pinski
On Thu, Feb 03, 2011 at 07:44:33PM +0000, dnovillo@google.com wrote: > Reviewers: gcc-patches_gcc.gnu.org, iant2, > > Description: > Only send mail to bugzilla and gcc-cvs when a commit happens in trunk > or any of the release branches. I'd very much prefer if all commits to all branches would still go to gcc-cvs (I search in gcc-cvs mailbox almost daily and need it even for our vendor branches), just if it could be configurable for which branches commits don't get forwarded to gcc-bugs/bugzilla (which is what I'd happily disable e.g. for branches/redhat/*). Jakub
On Thu, Feb 3, 2011 at 11:58 AM, Jakub Jelinek <jakub@redhat.com> wrote: > On Thu, Feb 03, 2011 at 07:44:33PM +0000, dnovillo@google.com wrote: >> Reviewers: gcc-patches_gcc.gnu.org, iant2, >> >> Description: >> Only send mail to bugzilla and gcc-cvs when a commit happens in trunk >> or any of the release branches. > > I'd very much prefer if all commits to all branches would still go to > gcc-cvs, I agree.
On Feb 3, 2011, at 11:49 AM, Andrew Pinski wrote: > On Thu, Feb 3, 2011 at 11:44 AM, <dnovillo@google.com> wrote: >> Only send mail to bugzilla and gcc-cvs when a commit happens in trunk >> or any of the release branches. > > I think this is wrong. I agree as well. Say for example a vendor does a vendor patch on a vendor branch (unreviewed unapproved), this work is still handy for a maintainer to have visibility into for a possible fix, when they get around to addressing the issue.
Thanks folks. I've dropped the patch. Diego.
Index: svnmailer.conf =================================================================== --- svnmailer.conf (revision 169804) +++ svnmailer.conf (working copy) @@ -87,3 +87,4 @@ to_addr = java-cvs@gcc.gnu.org to_addr = gcc-cvs@gcc.gnu.org #to_addr = dberlin@dberlin.org bugzilla_to_addr = gcc-bugzilla@gcc.gnu.org +for_repos = .*/trunk$|.*/branches/gcc-.*-branch$ Please review this at http://codereview.appspot.com/4000059/ Affected files: M svnmailer.conf Index: svnmailer.conf =================================================================== --- svnmailer.conf (revision 169804) +++ svnmailer.conf (working copy) @@ -87,3 +87,4 @@ to_addr = java-cvs@gcc.gnu.org to_addr = gcc-cvs@gcc.gnu.org #to_addr = dberlin@dberlin.org bugzilla_to_addr = gcc-bugzilla@gcc.gnu.org +for_repos = .*/trunk$|.*/branches/gcc-.*-branch$