| Message ID | 20180619053125.16792-6-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtd: rawnand: support MT29F1G08ABAFAWP-ITE:F | expand |
On Tue, 19 Jun 2018 17:31:24 +1200 Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron > NAND flash. > Fixes: 789157e41a06 ("mtd: rawnand: allow vendors to declare (un)supported features") Cc: <stable@vger.kernel.org> No need to send a new version, I'll add that when queuing the patch. Miquel, if you're okay, I'm gonna take this patch in the mtd/fixes branch and let you deal with other patches in this series. > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > Changes in v2: > - New > > drivers/mtd/nand/raw/nand_micron.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c > index e582c9e61715..d1e8f57544a0 100644 > --- a/drivers/mtd/nand/raw/nand_micron.c > +++ b/drivers/mtd/nand/raw/nand_micron.c > @@ -66,7 +66,9 @@ static int micron_nand_onfi_init(struct nand_chip *chip) > > if (p->supports_set_get_features) { > set_bit(ONFI_FEATURE_ADDR_READ_RETRY, p->set_feature_list); > + set_bit(ONFI_FEATURE_ON_DIE_ECC, p->set_feature_list); > set_bit(ONFI_FEATURE_ADDR_READ_RETRY, p->get_feature_list); > + set_bit(ONFI_FEATURE_ON_DIE_ECC, p->get_feature_list); > } > > return 0;
Hi Boris, Chris, On Tue, 19 Jun 2018 07:40:56 +0200, Boris Brezillon <boris.brezillon@bootlin.com> wrote: > On Tue, 19 Jun 2018 17:31:24 +1200 > Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > > > Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron > > NAND flash. > > > > Fixes: 789157e41a06 ("mtd: rawnand: allow vendors to declare (un)supported features") Sorry for breaking it in my previous series. > Cc: <stable@vger.kernel.org> > > No need to send a new version, I'll add that when queuing the patch. > > Miquel, if you're okay, I'm gonna take this patch in the mtd/fixes branch > and let you deal with other patches in this series. Yes please, take this one. * Chris, I'll take patches 1, 2, 3 with Boris comments. * Patch 4 I think I'll just drop it as nobody can test it (and it's a oneliner). I prefer people requesting a feature than complaining about a bug :) * Boris will take patch 5 in the mtd/fixes branch. * I'll let you write a v3 for patch 6 only. Thanks, Miquèl
> On Tue, 19 Jun 2018 17:31:24 +1200 > Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > > > Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron > > NAND flash. > > > > Fixes: 789157e41a06 ("mtd: rawnand: allow vendors to declare (un)supported features") > Cc: <stable@vger.kernel.org> > > No need to send a new version, I'll add that when queuing the patch. > > Miquel, if you're okay, I'm gonna take this patch in the mtd/fixes branch > and let you deal with other patches in this series. > > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
On 19/06/18 18:53, Miquel Raynal wrote: > Hi Boris, Chris, > > On Tue, 19 Jun 2018 07:40:56 +0200, Boris Brezillon > <boris.brezillon@bootlin.com> wrote: > >> On Tue, 19 Jun 2018 17:31:24 +1200 >> Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: >> >>> Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron >>> NAND flash. >>> >> >> Fixes: 789157e41a06 ("mtd: rawnand: allow vendors to declare (un)supported features") > > Sorry for breaking it in my previous series. > >> Cc: <stable@vger.kernel.org> >> >> No need to send a new version, I'll add that when queuing the patch. >> >> Miquel, if you're okay, I'm gonna take this patch in the mtd/fixes branch >> and let you deal with other patches in this series. > > Yes please, take this one. > > * Chris, I'll take patches 1, 2, 3 with Boris comments. OK. I also got a kbuild report on include/linux/mtd/rawnand.h:788: warning: Function parameter or member 'fixup_onfi_param_page' not described in 'nand_manufacturer_ops' Do you want me to send a v3 for that? (given our timezones I'll just send it anyway and you can choose to take it or just stick with v2). > * Patch 4 I think I'll just drop it as nobody can test it (and it's a > oneliner). I prefer people requesting a feature than complaining > about a bug :) Agreed. It's in the mailing list archive now if someone needs it we can resurrect it from there > * Boris will take patch 5 in the mtd/fixes branch. Thanks all. Sorry our emails crossed so I couldn't just send #5 as a fix on it's own. > * I'll let you write a v3 for patch 6 only. I'll have a read through the old thread and see if I can make sense of it.
Hi Chris, On Tue, 19 Jun 2018 21:22:00 +0000, Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote: > On 19/06/18 18:53, Miquel Raynal wrote: > > Hi Boris, Chris, > > > > On Tue, 19 Jun 2018 07:40:56 +0200, Boris Brezillon > > <boris.brezillon@bootlin.com> wrote: > > > >> On Tue, 19 Jun 2018 17:31:24 +1200 > >> Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > >> > >>> Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron > >>> NAND flash. > >>> > >> > >> Fixes: 789157e41a06 ("mtd: rawnand: allow vendors to declare (un)supported features") > > > > Sorry for breaking it in my previous series. > > > >> Cc: <stable@vger.kernel.org> > >> > >> No need to send a new version, I'll add that when queuing the patch. > >> > >> Miquel, if you're okay, I'm gonna take this patch in the mtd/fixes branch > >> and let you deal with other patches in this series. > > > > Yes please, take this one. > > > > * Chris, I'll take patches 1, 2, 3 with Boris comments. > > OK. > > I also got a kbuild report on > > include/linux/mtd/rawnand.h:788: warning: Function parameter or member > 'fixup_onfi_param_page' not described in 'nand_manufacturer_ops' > > Do you want me to send a v3 for that? (given our timezones I'll just > send it anyway and you can choose to take it or just stick with v2). I'll take v3 for sure, thanks for already sending it. > > > * Patch 4 I think I'll just drop it as nobody can test it (and it's a > > oneliner). I prefer people requesting a feature than complaining > > about a bug :) > > Agreed. It's in the mailing list archive now if someone needs it we can > resurrect it from there > > > * Boris will take patch 5 in the mtd/fixes branch. > > Thanks all. Sorry our emails crossed so I couldn't just send #5 as a fix > on it's own. > > > * I'll let you write a v3 for patch 6 only. > > I'll have a read through the old thread and see if I can make sense of it. Thanks! Miquèl
On Tue, 19 Jun 2018 17:31:24 +1200 Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron > NAND flash. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Queued to master (AKA mtd/fixes). Thanks, Boris > --- > Changes in v2: > - New > > drivers/mtd/nand/raw/nand_micron.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c > index e582c9e61715..d1e8f57544a0 100644 > --- a/drivers/mtd/nand/raw/nand_micron.c > +++ b/drivers/mtd/nand/raw/nand_micron.c > @@ -66,7 +66,9 @@ static int micron_nand_onfi_init(struct nand_chip *chip) > > if (p->supports_set_get_features) { > set_bit(ONFI_FEATURE_ADDR_READ_RETRY, p->set_feature_list); > + set_bit(ONFI_FEATURE_ON_DIE_ECC, p->set_feature_list); > set_bit(ONFI_FEATURE_ADDR_READ_RETRY, p->get_feature_list); > + set_bit(ONFI_FEATURE_ON_DIE_ECC, p->get_feature_list); > } > > return 0;
diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c index e582c9e61715..d1e8f57544a0 100644 --- a/drivers/mtd/nand/raw/nand_micron.c +++ b/drivers/mtd/nand/raw/nand_micron.c @@ -66,7 +66,9 @@ static int micron_nand_onfi_init(struct nand_chip *chip) if (p->supports_set_get_features) { set_bit(ONFI_FEATURE_ADDR_READ_RETRY, p->set_feature_list); + set_bit(ONFI_FEATURE_ON_DIE_ECC, p->set_feature_list); set_bit(ONFI_FEATURE_ADDR_READ_RETRY, p->get_feature_list); + set_bit(ONFI_FEATURE_ON_DIE_ECC, p->get_feature_list); } return 0;
Add ONFI_FEATURE_ON_DIE_ECC to the set/get features list for Micron NAND flash. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Changes in v2: - New drivers/mtd/nand/raw/nand_micron.c | 2 ++ 1 file changed, 2 insertions(+)