| Message ID | 20180607053431.24333-1-stewart@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hw/bt.c: quieten all the noisy BT/IPMI messages | expand |
On 07/06/18 15:34, Stewart Smith wrote: > Suggested-by: Oliver O'Halloran <oohall@gmail.com> > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > --- YES THANKYOU Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
On Thu, Jun 7, 2018 at 3:34 PM, Stewart Smith <stewart@linux.ibm.com> wrote: > Suggested-by: Oliver O'Halloran <oohall@gmail.com> > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > --- > hw/bt.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/bt.c b/hw/bt.c > index 338a9da58635..17c6de4ecf58 100644 > --- a/hw/bt.c > +++ b/hw/bt.c > @@ -88,8 +88,8 @@ > #define BT_Q_DBG(msg, fmt, args...) \ > _BT_Q_LOG(PR_DEBUG, msg, fmt, ##args) > > -#define BT_Q_INF(msg, fmt, args...) \ > - _BT_Q_LOG(PR_INFO, msg, fmt, ##args) > +#define BT_Q_TRACE(msg, fmt, args...) \ > + _BT_Q_LOG(PR_TRACE, msg, fmt, ##args) > > struct bt_msg { > struct list_node link; > @@ -270,7 +270,7 @@ static void bt_send_msg(struct bt_msg *bt_msg) > for (i = 0; i < ipmi_msg->req_size; i++) > bt_outb(ipmi_msg->data[i], BT_HOST2BMC); > > - BT_Q_INF(bt_msg, "Message sent to host"); > + BT_Q_TRACE(bt_msg, "Message sent to host"); > bt_msg->send_count++; > > bt_outb(BT_CTRL_H2B_ATN, BT_CTRL); > @@ -362,7 +362,7 @@ static void bt_get_resp(void) > ipmi_msg->data[i] = bt_inb(BT_HOST2BMC); > bt_set_h_busy(false); > > - BT_Q_INF(bt_msg, "IPMI MSG done"); > + BT_Q_TRACE(bt_msg, "IPMI MSG done"); > > list_del(&bt_msg->link); > bt.queue_len--; Yeah-boiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiied-by: Oliver O'Halloran <oohall@gmail.com> > -- > 2.17.1 >
Just make the output more fun with https://patchwork.ozlabs.org/patch/845957/ and nobody will ever complain about noisy logging again. On Thursday, 7 June 2018 3:53:02 PM AEST Oliver wrote: > On Thu, Jun 7, 2018 at 3:34 PM, Stewart Smith <stewart@linux.ibm.com> wrote: > > Suggested-by: Oliver O'Halloran <oohall@gmail.com> > > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > > --- > > hw/bt.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/hw/bt.c b/hw/bt.c > > index 338a9da58635..17c6de4ecf58 100644 > > --- a/hw/bt.c > > +++ b/hw/bt.c > > @@ -88,8 +88,8 @@ > > #define BT_Q_DBG(msg, fmt, args...) \ > > _BT_Q_LOG(PR_DEBUG, msg, fmt, ##args) > > > > -#define BT_Q_INF(msg, fmt, args...) \ > > - _BT_Q_LOG(PR_INFO, msg, fmt, ##args) > > +#define BT_Q_TRACE(msg, fmt, args...) \ > > + _BT_Q_LOG(PR_TRACE, msg, fmt, ##args) > > > > struct bt_msg { > > struct list_node link; > > @@ -270,7 +270,7 @@ static void bt_send_msg(struct bt_msg *bt_msg) > > for (i = 0; i < ipmi_msg->req_size; i++) > > bt_outb(ipmi_msg->data[i], BT_HOST2BMC); > > > > - BT_Q_INF(bt_msg, "Message sent to host"); > > + BT_Q_TRACE(bt_msg, "Message sent to host"); > > bt_msg->send_count++; > > > > bt_outb(BT_CTRL_H2B_ATN, BT_CTRL); > > @@ -362,7 +362,7 @@ static void bt_get_resp(void) > > ipmi_msg->data[i] = bt_inb(BT_HOST2BMC); > > bt_set_h_busy(false); > > > > - BT_Q_INF(bt_msg, "IPMI MSG done"); > > + BT_Q_TRACE(bt_msg, "IPMI MSG done"); > > > > list_del(&bt_msg->link); > > bt.queue_len--; > > Yeah-boiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiied-by: > Oliver O'Halloran <oohall@gmail.com> > > > -- > > 2.17.1 > > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot >
Alistair Popple <alistair@popple.id.au> writes: > Just make the output more fun with https://patchwork.ozlabs.org/patch/845957/ > and nobody will ever complain about noisy logging again. If it was birds rather than a cat, then maybe it'd get merged :)
Stewart Smith <stewart@linux.ibm.com> writes: > Suggested-by: Oliver O'Halloran <oohall@gmail.com> > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > --- > hw/bt.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Merged to master as of 8f650b6d55b4060cca7b8a2fa2850bc73890b179.
diff --git a/hw/bt.c b/hw/bt.c index 338a9da58635..17c6de4ecf58 100644 --- a/hw/bt.c +++ b/hw/bt.c @@ -88,8 +88,8 @@ #define BT_Q_DBG(msg, fmt, args...) \ _BT_Q_LOG(PR_DEBUG, msg, fmt, ##args) -#define BT_Q_INF(msg, fmt, args...) \ - _BT_Q_LOG(PR_INFO, msg, fmt, ##args) +#define BT_Q_TRACE(msg, fmt, args...) \ + _BT_Q_LOG(PR_TRACE, msg, fmt, ##args) struct bt_msg { struct list_node link; @@ -270,7 +270,7 @@ static void bt_send_msg(struct bt_msg *bt_msg) for (i = 0; i < ipmi_msg->req_size; i++) bt_outb(ipmi_msg->data[i], BT_HOST2BMC); - BT_Q_INF(bt_msg, "Message sent to host"); + BT_Q_TRACE(bt_msg, "Message sent to host"); bt_msg->send_count++; bt_outb(BT_CTRL_H2B_ATN, BT_CTRL); @@ -362,7 +362,7 @@ static void bt_get_resp(void) ipmi_msg->data[i] = bt_inb(BT_HOST2BMC); bt_set_h_busy(false); - BT_Q_INF(bt_msg, "IPMI MSG done"); + BT_Q_TRACE(bt_msg, "IPMI MSG done"); list_del(&bt_msg->link); bt.queue_len--;
Suggested-by: Oliver O'Halloran <oohall@gmail.com> Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- hw/bt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)