| Message ID | b752eb09-23c8-199a-585d-dffeeb8dab3d@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PULL] u-boot-sh/master | expand |
On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: > The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: > > Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 > 10:08:20 -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-sh.git master > > for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: > > ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 > +0200) > NAK. First, there are a lot of should be fix style errors in the new files in drivers/pinctrl/renesas/. Second, you have build failures: https://travis-ci.org/trini/u-boot/jobs/391819805 https://travis-ci.org/trini/u-boot/jobs/391819826
On 06/14/2018 01:19 PM, Tom Rini wrote: > On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: > >> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: >> >> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 >> 10:08:20 -0400) >> >> are available in the Git repository at: >> >> git://git.denx.de/u-boot-sh.git master >> >> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: >> >> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 >> +0200) >> > > NAK. First, there are a lot of should be fix style errors in > the new files in drivers/pinctrl/renesas/. Second, you have build > failures: > https://travis-ci.org/trini/u-boot/jobs/391819805 > https://travis-ci.org/trini/u-boot/jobs/391819826 Great, thanks! If the travis didn't vomit constant false positives recently, I'd trust it. With what it does now, I cannot trust it anymore.
On Thu, Jun 14, 2018 at 01:35:05PM +0200, Marek Vasut wrote: > On 06/14/2018 01:19 PM, Tom Rini wrote: > > On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: > > > >> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: > >> > >> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 > >> 10:08:20 -0400) > >> > >> are available in the Git repository at: > >> > >> git://git.denx.de/u-boot-sh.git master > >> > >> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: > >> > >> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 > >> +0200) > >> > > > > NAK. First, there are a lot of should be fix style errors in > > the new files in drivers/pinctrl/renesas/. Second, you have build > > failures: > > https://travis-ci.org/trini/u-boot/jobs/391819805 > > https://travis-ci.org/trini/u-boot/jobs/391819826 > > Great, thanks! > > If the travis didn't vomit constant false positives recently, I'd trust > it. With what it does now, I cannot trust it anymore. Can you elaborate?
On 06/14/2018 03:07 PM, Tom Rini wrote: > On Thu, Jun 14, 2018 at 01:35:05PM +0200, Marek Vasut wrote: >> On 06/14/2018 01:19 PM, Tom Rini wrote: >>> On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: >>> >>>> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: >>>> >>>> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 >>>> 10:08:20 -0400) >>>> >>>> are available in the Git repository at: >>>> >>>> git://git.denx.de/u-boot-sh.git master >>>> >>>> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: >>>> >>>> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 >>>> +0200) >>>> >>> >>> NAK. First, there are a lot of should be fix style errors in >>> the new files in drivers/pinctrl/renesas/. Second, you have build >>> failures: >>> https://travis-ci.org/trini/u-boot/jobs/391819805 >>> https://travis-ci.org/trini/u-boot/jobs/391819826 >> >> Great, thanks! >> >> If the travis didn't vomit constant false positives recently, I'd trust >> it. With what it does now, I cannot trust it anymore. > > Can you elaborate? Don't you see the constant random timeouts during builds for some targets? I cannot get a successful build on the first try almost never these days, I have to keep restarting until I see that different targets failed during each build with a timeout and then extrapolate that the build is actually fine from that. It's annoying. And then there is the other category of boards which indicate "red" failure marker due to ie. DT problems, which if you pull DTs from Linux is something you cannot really fix on the U-Boot side right away, but rather fix in Linux and then resync.
On Thu, Jun 14, 2018 at 10:58:22PM +0200, Marek Vasut wrote: > On 06/14/2018 03:07 PM, Tom Rini wrote: > > On Thu, Jun 14, 2018 at 01:35:05PM +0200, Marek Vasut wrote: > >> On 06/14/2018 01:19 PM, Tom Rini wrote: > >>> On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: > >>> > >>>> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: > >>>> > >>>> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 > >>>> 10:08:20 -0400) > >>>> > >>>> are available in the Git repository at: > >>>> > >>>> git://git.denx.de/u-boot-sh.git master > >>>> > >>>> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: > >>>> > >>>> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 > >>>> +0200) > >>>> > >>> > >>> NAK. First, there are a lot of should be fix style errors in > >>> the new files in drivers/pinctrl/renesas/. Second, you have build > >>> failures: > >>> https://travis-ci.org/trini/u-boot/jobs/391819805 > >>> https://travis-ci.org/trini/u-boot/jobs/391819826 > >> > >> Great, thanks! > >> > >> If the travis didn't vomit constant false positives recently, I'd trust > >> it. With what it does now, I cannot trust it anymore. > > > > Can you elaborate? > > Don't you see the constant random timeouts during builds for some > targets? I cannot get a successful build on the first try almost never > these days, I have to keep restarting until I see that different targets > failed during each build with a timeout and then extrapolate that the > build is actually fine from that. It's annoying. I see maybe 2-5 of those per day when I'm busy, which is annoying, but I've never had it fail a second time in a row. > And then there is the other category of boards which indicate "red" > failure marker due to ie. DT problems, which if you pull DTs from Linux > is something you cannot really fix on the U-Boot side right away, but > rather fix in Linux and then resync. Yes, there are DT warnings that should be fixed. But they aren't travis errors, only actual fail to builds (like in the above, which indeed are confusingly DT related, but not a travis problem at all, I see them locally too) and new C warnings.
On 06/14/2018 11:42 PM, Tom Rini wrote: > On Thu, Jun 14, 2018 at 10:58:22PM +0200, Marek Vasut wrote: >> On 06/14/2018 03:07 PM, Tom Rini wrote: >>> On Thu, Jun 14, 2018 at 01:35:05PM +0200, Marek Vasut wrote: >>>> On 06/14/2018 01:19 PM, Tom Rini wrote: >>>>> On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: >>>>> >>>>>> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: >>>>>> >>>>>> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 >>>>>> 10:08:20 -0400) >>>>>> >>>>>> are available in the Git repository at: >>>>>> >>>>>> git://git.denx.de/u-boot-sh.git master >>>>>> >>>>>> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: >>>>>> >>>>>> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 >>>>>> +0200) >>>>>> >>>>> >>>>> NAK. First, there are a lot of should be fix style errors in >>>>> the new files in drivers/pinctrl/renesas/. Second, you have build >>>>> failures: >>>>> https://travis-ci.org/trini/u-boot/jobs/391819805 >>>>> https://travis-ci.org/trini/u-boot/jobs/391819826 >>>> >>>> Great, thanks! >>>> >>>> If the travis didn't vomit constant false positives recently, I'd trust >>>> it. With what it does now, I cannot trust it anymore. >>> >>> Can you elaborate? >> >> Don't you see the constant random timeouts during builds for some >> targets? I cannot get a successful build on the first try almost never >> these days, I have to keep restarting until I see that different targets >> failed during each build with a timeout and then extrapolate that the >> build is actually fine from that. It's annoying. > > I see maybe 2-5 of those per day when I'm busy, which is annoying, but > I've never had it fail a second time in a row. Good for you. >> And then there is the other category of boards which indicate "red" >> failure marker due to ie. DT problems, which if you pull DTs from Linux >> is something you cannot really fix on the U-Boot side right away, but >> rather fix in Linux and then resync. > > Yes, there are DT warnings that should be fixed. But they aren't travis > errors, only actual fail to builds (like in the above, which indeed are > confusingly DT related, but not a travis problem at all, I see them > locally too) and new C warnings. I'd prefer to see only errors which are relevant in the logs. Oh well.
On Fri, Jun 15, 2018 at 06:09:49AM +0200, Marek Vasut wrote: > On 06/14/2018 11:42 PM, Tom Rini wrote: > > On Thu, Jun 14, 2018 at 10:58:22PM +0200, Marek Vasut wrote: > >> On 06/14/2018 03:07 PM, Tom Rini wrote: > >>> On Thu, Jun 14, 2018 at 01:35:05PM +0200, Marek Vasut wrote: > >>>> On 06/14/2018 01:19 PM, Tom Rini wrote: > >>>>> On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: > >>>>> > >>>>>> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: > >>>>>> > >>>>>> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 > >>>>>> 10:08:20 -0400) > >>>>>> > >>>>>> are available in the Git repository at: > >>>>>> > >>>>>> git://git.denx.de/u-boot-sh.git master > >>>>>> > >>>>>> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: > >>>>>> > >>>>>> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 > >>>>>> +0200) > >>>>>> > >>>>> > >>>>> NAK. First, there are a lot of should be fix style errors in > >>>>> the new files in drivers/pinctrl/renesas/. Second, you have build > >>>>> failures: > >>>>> https://travis-ci.org/trini/u-boot/jobs/391819805 > >>>>> https://travis-ci.org/trini/u-boot/jobs/391819826 > >>>> > >>>> Great, thanks! > >>>> > >>>> If the travis didn't vomit constant false positives recently, I'd trust > >>>> it. With what it does now, I cannot trust it anymore. > >>> > >>> Can you elaborate? > >> > >> Don't you see the constant random timeouts during builds for some > >> targets? I cannot get a successful build on the first try almost never > >> these days, I have to keep restarting until I see that different targets > >> failed during each build with a timeout and then extrapolate that the > >> build is actually fine from that. It's annoying. > > > > I see maybe 2-5 of those per day when I'm busy, which is annoying, but > > I've never had it fail a second time in a row. > > Good for you. > > >> And then there is the other category of boards which indicate "red" > >> failure marker due to ie. DT problems, which if you pull DTs from Linux > >> is something you cannot really fix on the U-Boot side right away, but > >> rather fix in Linux and then resync. > > > > Yes, there are DT warnings that should be fixed. But they aren't travis > > errors, only actual fail to builds (like in the above, which indeed are > > confusingly DT related, but not a travis problem at all, I see them > > locally too) and new C warnings. > > I'd prefer to see only errors which are relevant in the logs. Oh well. Then fix the kernel dts. I swear when I looked into these last they're just as visible there.
On Fri, Jun 15, 2018 at 5:42 AM, Tom Rini <trini@konsulko.com> wrote: > On Thu, Jun 14, 2018 at 10:58:22PM +0200, Marek Vasut wrote: >> On 06/14/2018 03:07 PM, Tom Rini wrote: >> > On Thu, Jun 14, 2018 at 01:35:05PM +0200, Marek Vasut wrote: >> >> On 06/14/2018 01:19 PM, Tom Rini wrote: >> >>> On Wed, Jun 13, 2018 at 06:05:08AM +0200, Marek Vasut wrote: >> >>> >> >>>> The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: >> >>>> >> >>>> Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 >> >>>> 10:08:20 -0400) >> >>>> >> >>>> are available in the Git repository at: >> >>>> >> >>>> git://git.denx.de/u-boot-sh.git master >> >>>> >> >>>> for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: >> >>>> >> >>>> ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 >> >>>> +0200) >> >>>> >> >>> >> >>> NAK. First, there are a lot of should be fix style errors in >> >>> the new files in drivers/pinctrl/renesas/. Second, you have build >> >>> failures: >> >>> https://travis-ci.org/trini/u-boot/jobs/391819805 >> >>> https://travis-ci.org/trini/u-boot/jobs/391819826 >> >> >> >> Great, thanks! >> >> >> >> If the travis didn't vomit constant false positives recently, I'd trust >> >> it. With what it does now, I cannot trust it anymore. >> > >> > Can you elaborate? >> >> Don't you see the constant random timeouts during builds for some >> targets? I cannot get a successful build on the first try almost never >> these days, I have to keep restarting until I see that different targets >> failed during each build with a timeout and then extrapolate that the >> build is actually fine from that. It's annoying. > > I see maybe 2-5 of those per day when I'm busy, which is annoying, but > I've never had it fail a second time in a row. > I guess the instability came from "The command "sudo apt-get install libisl15 -y" failed and exited with 100 during". I saw this almost every build. And even some build wass restarted for the 2nd time, it still failed. >> And then there is the other category of boards which indicate "red" >> failure marker due to ie. DT problems, which if you pull DTs from Linux >> is something you cannot really fix on the U-Boot side right away, but >> rather fix in Linux and then resync. > > Yes, there are DT warnings that should be fixed. But they aren't travis > errors, only actual fail to builds (like in the above, which indeed are > confusingly DT related, but not a travis problem at all, I see them > locally too) and new C warnings. > Regards, Bin
The following changes since commit 813d1fb56dc0af9567feb86cd71c49f14662044b: Merge branch 'master' of git://git.denx.de/u-boot-ubi (2018-06-08 10:08:20 -0400) are available in the Git repository at: git://git.denx.de/u-boot-sh.git master for you to fetch changes up to 0a52b00627c4fb6b100745c97910b75c99f3f4a9: ARM: rmobile: Fix environment placement on Draak (2018-06-10 16:34:43 +0200) ---------------------------------------------------------------- Marek Vasut (8): pinctrl: renesas: Sync Gen2 PFC tables with Linux v4.17 pinctrl: renesas: Sync Gen3 PFC tables with Linux v4.17 ARM: rmobile: Sync Gen2 DTS with Linux v4.17 ARM: rmobile: Sync Gen3 DTS with Linux v4.17 ARM: rmobile: Zap CONFIG_SYS_CLK_FREQ where applicable ARM: rmobile: Point load address to more sane area on Gen2 ARM: rmobile: Point load address to more sane area on Gen3 ARM: rmobile: Fix environment placement on Draak arch/arm/dts/r8a7790-lager.dts | 310 +++++++++----- arch/arm/dts/r8a7790.dtsi | 2877 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------- arch/arm/dts/r8a7791-koelsch.dts | 259 ++++++----- arch/arm/dts/r8a7791-porter.dts | 151 ++++--- arch/arm/dts/r8a7791.dtsi | 3008 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------- arch/arm/dts/r8a7792.dtsi | 587 +++++++++++++------------ arch/arm/dts/r8a7793-gose.dts | 262 +++++++----- arch/arm/dts/r8a7793.dtsi | 2409 +++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------- arch/arm/dts/r8a7794-alt.dts | 56 ++- arch/arm/dts/r8a7794-silk.dts | 189 ++++++--- arch/arm/dts/r8a7794.dtsi | 2416 +++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------- arch/arm/dts/r8a7795.dtsi | 602 +++++++++++++++++++++----- arch/arm/dts/r8a7796.dtsi | 556 ++++++++++++++++++------ arch/arm/dts/r8a77965.dtsi | 127 +++++- arch/arm/dts/r8a77970-eagle.dts | 66 +-- arch/arm/dts/r8a77970.dtsi | 328 ++++++++++++-- arch/arm/dts/r8a77995-draak.dts | 124 ++++++ arch/arm/dts/r8a77995.dtsi | 423 +++++++++++++++++- arch/arm/dts/salvator-common.dtsi | 85 +++- arch/arm/dts/ulcb.dtsi | 22 +- drivers/pinctrl/renesas/pfc-r8a7790.c | 8 +- drivers/pinctrl/renesas/pfc-r8a7791.c | 84 +++- drivers/pinctrl/renesas/pfc-r8a7794.c | 473 +++++++++++++++++++++ drivers/pinctrl/renesas/pfc-r8a7795.c | 1968 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------- drivers/pinctrl/renesas/pfc-r8a7796.c | 1048 +++++++++++++++++++++++++++++++-------------- drivers/pinctrl/renesas/pfc-r8a77970.c | 873 ++++++++++++++++--------------------- drivers/pinctrl/renesas/pfc-r8a77990.c | 3446 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- drivers/pinctrl/renesas/pfc-r8a77995.c | 695 +++++++++++++++++++++++++++++- drivers/pinctrl/renesas/sh_pfc.h | 5 +- include/configs/draak.h | 6 +- include/configs/ebisu.h | 4 - include/configs/rcar-gen2-common.h | 3 +- include/configs/rcar-gen3-common.h | 3 +- include/configs/salvator-x.h | 4 - include/configs/ulcb.h | 4 - 35 files changed, 16030 insertions(+), 7451 deletions(-)